Selectors: compatibleWith() method added.

Author: Smoren

src/Interfaces/ArraySelectorInterface.php

@@ -21,6 +21,17 @@ interface ArraySelectorInterface
      */
     public function select(ArrayViewInterface $source, ?bool $readonly = null): ArrayViewInterface;
 
+    /**
+     * Checks if the selector is compatible with the given view.
+     *
+     * @template T View elements type.
+     *
+     * @param ArrayViewInterface<T> $view the view to check compatibility with.
+     *
+     * @return bool true if the element is compatible, false otherwise
+     */
+    public function compatibleWith(ArrayViewInterface $view): bool;
+
     /**
      * Return value of the selector.
      *

src/Selectors/IndexListSelector.php

@@ -45,6 +45,22 @@ public function select(ArrayViewInterface $source, ?bool $readonly = null): Arra
         return new ArrayIndexListView($source, $this->value, $readonly ?? $source->isReadonly());
     }
 
+    /**
+     * Checks if the selector is compatible with the given view.
+     *
+     * @template T View elements type.
+     *
+     * @param ArrayViewInterface<T> $view the view to check compatibility with.
+     *
+     * @return bool true if the element is compatible, false otherwise
+     *
+     * {@inheritDoc}
+     */
+    public function compatibleWith(ArrayViewInterface $view): bool
+    {
+        return \count($this->value) === 0 || \max($this->value) < \count($view) && \min($this->value) >= -\count($view);
+    }
+
     /**
      * {@inheritDoc}
      */

src/Selectors/MaskSelector.php

@@ -45,6 +45,22 @@ public function select(ArrayViewInterface $source, ?bool $readonly = null): Arra
         return new ArrayMaskView($source, $this->value, $readonly ?? $source->isReadonly());
     }
 
+    /**
+     * Checks if the selector is compatible with the given view.
+     *
+     * @template T View elements type.
+     *
+     * @param ArrayViewInterface<T> $view the view to check compatibility with.
+     *
+     * @return bool true if the element is compatible, false otherwise
+     *
+     * {@inheritDoc}
+     */
+    public function compatibleWith(ArrayViewInterface $view): bool
+    {
+        return \count($this->value) === \count($view);
+    }
+
     /**
      * {@inheritDoc}
      */

src/Selectors/SliceSelector.php

@@ -42,6 +42,22 @@ public function select(ArrayViewInterface $source, ?bool $readonly = null): Arra
         return new ArraySliceView($source, $this, $readonly ?? $source->isReadonly());
     }
 
+    /**
+     * Checks if the selector is compatible with the given view.
+     *
+     * @template T View elements type.
+     *
+     * @param ArrayViewInterface<T> $view the view to check compatibility with.
+     *
+     * @return bool true if the element is compatible, false otherwise
+     *
+     * {@inheritDoc}
+     */
+    public function compatibleWith(ArrayViewInterface $view): bool
+    {
+        return true;
+    }
+
     /**
      * {@inheritDoc}
      */

src/Traits/ArrayViewAccessTrait.php

@@ -42,7 +42,7 @@ public function offsetExists($offset): bool
         }
 
         if ($offset instanceof ArraySelectorInterface) {
-            return true;
+            return $offset->compatibleWith($this);
         }
 
         return false;

tests/unit/ArrayIndexListView/IssetTest.php

@@ -2,17 +2,16 @@
 
 namespace Smoren\ArrayView\Tests\Unit\ArrayIndexListView;
 
+use Smoren\ArrayView\Exceptions\IndexError;
 use Smoren\ArrayView\Selectors\IndexListSelector;
-use Smoren\ArrayView\Selectors\MaskSelector;
-use Smoren\ArrayView\Views\ArrayIndexListView;
 use Smoren\ArrayView\Views\ArrayView;
 
 class IssetTest extends \Codeception\Test\Unit
 {
     /**
-     * @dataProvider dataProviderForIssetTrue
+     * @dataProvider dataProviderForIssetSingleTrue
      */
-    public function testIssetTrue(array $source, array $indexes)
+    public function testIssetSingleTrue(array $source, array $indexes)
     {
         $view = ArrayView::toView($source);
         $subview = $view->subview(new IndexListSelector($indexes));
@@ -28,9 +27,9 @@ public function testIssetTrue(array $source, array $indexes)
     }
 
     /**
-     * @dataProvider dataProviderForIssetFalse
+     * @dataProvider dataProviderForIssetSingleFalse
      */
-    public function testIssetFalse(array $source, array $indexes, array $expected)
+    public function testIssetSingleFalse(array $source, array $indexes, array $expected)
     {
         $view = ArrayView::toView($source);
         $subview = $view->subview(new IndexListSelector($indexes));
@@ -40,7 +39,36 @@ public function testIssetFalse(array $source, array $indexes, array $expected)
         }
     }
 
-    public function dataProviderForIssetTrue(): array
+    /**
+     * @dataProvider dataProviderForIssetSelectorTrue
+     */
+    public function testIssetSelectorTrue(array $source, array $indexes)
+    {
+        $view = ArrayView::toView($source);
+
+        $this->assertTrue(isset($view[new IndexListSelector($indexes)]));
+
+        $subview = $view->subview(new IndexListSelector($indexes));
+        $this->assertSame(\count($indexes), \count($subview));
+
+        $subview = $view[new IndexListSelector($indexes)];
+        $this->assertSame(\count($indexes), \count($subview));
+    }
+
+    /**
+     * @dataProvider dataProviderForIssetSelectorFalse
+     */
+    public function testIssetSelectorFalse(array $source, array $indexes)
+    {
+        $view = ArrayView::toView($source);
+
+        $this->assertFalse(isset($view[new IndexListSelector($indexes)]));
+
+        $this->expectException(IndexError::class);
+        $_ = $view[new IndexListSelector($indexes)];
+    }
+
+    public function dataProviderForIssetSingleTrue(): array
     {
         return [
             [[1], [0]],
@@ -57,7 +85,7 @@ public function dataProviderForIssetTrue(): array
         ];
     }
 
-    public static function dataProviderForIssetFalse(): array
+    public function dataProviderForIssetSingleFalse(): array
     {
         return [
             [[], [], [-2, -1, 0, 1, 2]],
@@ -76,4 +104,46 @@ public static function dataProviderForIssetFalse(): array
             [[1, 2, 3, 4, 5, 6, 7, 8, 9], [1, 1, 5, 5, 3], [-8, -7, -6, 5, 6, 7]],
         ];
     }
+
+    public function dataProviderForIssetSelectorTrue(): array
+    {
+        return [
+            [[1], []],
+            [[1], [0]],
+            [[1], [-1]],
+            [[1], [0, 0]],
+            [[1], [0, 0, 0]],
+            [[1, 2], []],
+            [[1, 2], [0]],
+            [[1, 2], [-1, -2]],
+            [[1, 2], [1]],
+            [[1, 2], [0, 1]],
+            [[1, 2, 3, 4, 5, 6, 7, 8, 9], []],
+            [[1, 2, 3, 4, 5, 6, 7, 8, 9], [1, 3, 5, 7]],
+            [[1, 2, 3, 4, 5, 6, 7, 8, 9], [7, 5, 3, 1]],
+            [[1, 2, 3, 4, 5, 6, 7, 8, 9], [1, 5, 3, 7]],
+            [[1, 2, 3, 4, 5, 6, 7, 8, 9], [0, 1, 7, 8]],
+            [[1, 2, 3, 4, 5, 6, 7, 8, 9], []],
+            [[1, 2, 3, 4, 5, 6, 7, 8, 9], [1, 1, 5, 5, 3]],
+        ];
+    }
+
+    public function dataProviderForIssetSelectorFalse(): array
+    {
+        return [
+            [[1], [0, 1]],
+            [[1], [1, -1, -2]],
+            [[1], [0, 1, 0, -1, -2]],
+            [[1], [1, -1]],
+            [[1], [0, 0, -2]],
+            [[1, 2], [2]],
+            [[1, 2], [1, 2]],
+            [[1, 2], [0, 1, 2]],
+            [[1, 2, 3, 4, 5, 6, 7, 8, 9], [1, 3, 5, -10]],
+            [[1, 2, 3, 4, 5, 6, 7, 8, 9], [9, 5, 3, 1]],
+            [[1, 2, 3, 4, 5, 6, 7, 8, 9], [1, 10, 9, 7]],
+            [[1, 2, 3, 4, 5, 6, 7, 8, 9], [-10, 1, 7, 10]],
+            [[1, 2, 3, 4, 5, 6, 7, 8, 9], [1, 1, 50, 5, 3]],
+        ];
+    }
 }