Merge pull request #61 from Snailedlt/feature/only_check_for_stroke_attr_if_used_by_icomoon

Feature/only check for stroke attr if used by icomoon

Author: Snailedlt

.editorconfig

@@ -0,0 +1,14 @@
+root = true
+
+[*]
+charset = utf-8
+end_of_line = lf
+insert_final_newline = true
+
+[**.json]
+indent_style = space
+indent_size = 4
+trim_trailing_whitespace = true
+
+[**.svg]
+trim_trailing_whitespace = false

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -1,6 +1,6 @@
 name: Bug Report
-description: Report a bug/issue that you found in the SVGs, CSS files, etc.
-title: '[BUG] <bug name>'
+description: Report a bug/issue that you found in the SVGs, CSS files, or any other bug you encounter.
+title: '[BUG]: <bug name>'
 labels: [bug]
 body:
   - type: markdown
@@ -18,7 +18,7 @@ body:
     id: description
     attributes:
       label: Bug description
-      description: Short description of the bug that you found. Provide images/code if applicable.
+      description: Short description of the bug. Provide images/code if applicable.
     validations:
       required: true
 

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -1,6 +1,6 @@
 name: Feature Request
 description: Requesting a new feature or changes to an existing feature
-title: '[FEATURE REQUEST] <feature name>'
+title: '[FEATURE REQUEST]: <feature name>'
 labels: [enhancement]
 body:
   - type: markdown
@@ -15,13 +15,21 @@ body:
           required: true
 
   - type: textarea
-    id: currentproblem
+    id: description
     attributes:
-      label: Problem
-      description: Tell us about the problem and its negative impacts.
+      label: Description
+      description: Write down a detailed description of the feature.
     validations:
       required: true
 
+    - type: textarea
+      id: context
+      attributes:
+        label: Context
+        description: Why is this change important to you? How would you use it? How can it benefit other users?
+      validations:
+        required: true
+
   - type: textarea
     id: possiblesolution
     attributes:

.github/ISSUE_TEMPLATE/icon_request.yml

@@ -1,5 +1,5 @@
 name: Icon Request
-description: Requesting a new icon or changes to an existing icon
+description: Request a new icon, or changes to an existing icon
 title: '[ICON REQUEST]: <icon name>'
 labels: ["request:icon"]
 body:

.github/ISSUE_TEMPLATE/other.yml

@@ -1,6 +1,6 @@
 name: Other
-description: Use this for any other issues. Do not create blank issues
-title: "[OTHER] <description>"
+description: Use this for any other issues. Please do NOT create blank issues
+title: "[OTHER]: <description>"
 labels: ["awaiting triage"]
 body:
   - type: markdown

.github/PULL_REQUEST_TEMPLATE/new_feature.md

@@ -4,10 +4,11 @@
 - [ ] PR does not match another non-stale PR currently opened
 
 ## Features
-<!-- List your features here and the benefits they bring. Include images/codes as appropriate -->
+<!-- List your features here and the benefits they bring. Include images/codes if appropriate -->
 
 **This PR closes NONE**
 <!-- List issues that this PR would close above. Ex: This PR closes #1, #2, #3. -->
+<!-- If your pull request does not fix any issue, it's best to make an issue OR remove this section, depending on your changes. -->
 
 ## Notes
 <!-- List anything note-worthy here (potential issues, this needs to be merged to `master` before working, etc.). -->

.github/PULL_REQUEST_TEMPLATE/new_icon.md

@@ -2,11 +2,11 @@
 
 <!-- Tick the checkboxes to ensure you've done everything correctly -->
 - [ ] PR does not match another non-stale PR currently opened
-- [ ] PR name matches the format *new icon: <i>Icon name</i> (<i>versions separated by comma</i>)*. More details [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview)
+- [ ] PR name matches the format *new icon: <i>Icon name</i> (<i>versions separated by comma</i>)*. More details [here](https://github.com/devicons/devicon/wiki/Overview-on-Submitting-Icons)
 - [ ] PR's base is the `develop` branch.
-- [ ] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines)
-- [ ] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards)
-- [ ] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-)
+- [ ] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/wiki/Organizing-SVGs)
+- [ ] SVG matches the standards laid out [here](https://github.com/devicons/devicon/wiki/SVG-Standards)
+- [ ] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/wiki/Updating-the-%60devicon.json%60)
 
 <!-- Refer to the [contributing](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon) guidelines for more details. -->
 

.github/drafts/stale.yml

@@ -10,13 +10,16 @@ jobs:
       - uses: actions/stale@main
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
-          stale-pr-message: 'Hello there,
-          we noticed that this PR has been inactive for a while now. If there are any changes which are suitable for our repository,
-          we would love to have it. It would be great if you can continue with this PR, but if you cannot, we might fork your changes and merge the changes ourselves.
+          stale-pr-message: "Hello there,
+          we have noticed that this PR has been inactive for a while now. If there are any changes which are suitable for our repository,
+          we would love to have it. It would be great if you can continue with this PR, but if you can't, we might fork your changes and merge them ourselves.
 
-          Since GitHub tracks contributions by commits, you will still be credited.
+          Since GitHub tracks contributions by commits, you'll still be credited.
+          Let us know what you think about this. :slight_smile:
 
-          Let us know what you think 😃'
+
+          Feel free to [join our Discord server](https://discord.gg/hScy8KWACQ) for support, hangouts, and more
+          Thank you and have a nice day!"
         stale-pr-label: 'stale'
         days-before-pr-stale: 30
         days-before-pr-close: -1

.github/pull_request_template.md

@@ -1,5 +1,11 @@
-### Adding a New Icon? 
-- Add `?quick_pull=1&template=new_icon.md` to the end of your current URL and press `Enter`
+<!--
 
-### Adding a New Feature or fixing a bug? 
-- Add `?quick_pull=1&template=new_feature.md` to the end of your current URL and press `Enter`.
+Adding a New Icon?
+
+- Add `?quick_pull=1&template=new_icon.md` to the end of your current URL and press `Enter`.
+
+Adding a New Feature or fixing a bug?
+
+- Add `?quick_pull=1&template=new_feature.md` to the end of your current URL and press `Enter`.
+
+-->

.github/scripts/build_assets/util.py

@@ -1,4 +1,5 @@
 import os
+from pathlib import Path
 import re
 from typing import List
 import platform
@@ -71,7 +72,23 @@ def find_object_added_in_pr(icons: List[dict], pr_title: str):
         raise Exception(message)
 
 
+def is_svg_in_font_attribute(svg_file_path: Path, devicon_object: dict): 
+    """
+    Check if svg is in devicon.json's font attribute.
+    :param svg_file_path, the path to a single svg icon
+    :devicon_object, an object for a single icon inside devicon.json
+    :return true if the svg exists in the devicon_object's font attribute, false if it doesn't
+    """
+    icon_version = svg_file_path.name.split('-', 1)[1]
+    font_object = devicon_object["versions"]["font"]
+    return icon_version in font_object
+
+
 valid_svg_filename_pattern = re.compile(r"-(original|plain|line)(-wordmark)?\.svg$")
 def is_svg_name_valid(filename: str):
     return valid_svg_filename_pattern.search(filename) is not None
 
+
+valid_svg_version_pattern = re.compile(r"^(original|plain|line)(-wordmark)?$")
+def is_svg_version_valid(version):
+    return valid_svg_version_pattern.search(version) is not None