Fix Lua error in form selection, fixes #291

Author: Snakybo

CHANGELOG.md

@@ -13,6 +13,7 @@ The format of this changelog is based on [Keep a Changelog](https://keepachangel
 ### Fixed
 
 * Fix bindings created in the global scope not actually being global
+* Fix a Lua error with the stance/form selector on Burning Crusade Anniversary [#291]
 
 ## [1.17.3] - 2026-01-25
 
@@ -1846,6 +1847,7 @@ The format of this changelog is based on [Keep a Changelog](https://keepachangel
 [0.4.0]: https://github.com/Snakybo/Clicked/releases/tag/0.4.0
 [0.3.0]: https://github.com/Snakybo/Clicked/releases/tag/0.3.0
 
+[#291]: https://github.com/Snakybo/Clicked/issues/291
 [#288]: https://github.com/Snakybo/Clicked/issues/288
 [#287]: https://github.com/Snakybo/Clicked/issues/287
 [#286]: https://github.com/Snakybo/Clicked/issues/286

Clicked/Conditions/MacroConditions.lua

@@ -28,9 +28,8 @@ local config = {
 			label = "Form / Stance",
 			negatable = true,
 			availableValues = function(class, specialization)
-				local specIds = Utils.GetRelevantSpecializationIds(class, specialization)
-
 				if Addon.EXPANSION_LEVEL >= Addon.Expansion.MOP then
+					local specIds = Utils.GetRelevantSpecializationIds(class, specialization)
 					return Addon:GetLocalizedForms(specIds)
 				else
 					return Addon:GetLocalizedForms(class)

Clicked/Core/LocaleUtils.lua

@@ -673,7 +673,7 @@ else
 	--- Get a localized list of all available classic shapeshift forms for the  given class names.
 	--- If the `classNames` parameter is `nil` it will return results for the player's current class.
 	---
-	--- @param classes? string[]
+	--- @param classes string[]
 	--- @return table<integer,string> items
 	--- @return integer[] order
 	function Addon:GetLocalizedForms(classes)
@@ -683,8 +683,7 @@ else
 		--- @type integer[]
 		local order = {}
 
-		if classes == nil then
-			classes = {}
+		if #classes == 0 then
 			classes[1] = select(2, UnitClass("player"))
 		end
 
@@ -735,14 +734,14 @@ else
 				end
 			-- Find specialization with the highest number of forms out of the selected specializations
 			else
-				for _, className in ipairs(classes) do
-					local forms = Addon:GetShapeshiftForms(className)
+			for _, className in ipairs(classes) do
+				local forms = Addon:GetShapeshiftForms(className)
 
-					if #forms > max then
-						max = #forms
-					end
+				if #forms > max then
+					max = #forms
 				end
 			end
+			end
 
 			-- start at 0 because [form:0] is no form
 			for i = 0, max do