Autopopulate macro from items and cancelaura, generate based on full binding

Author: Snakybo

CHANGELOG.md

@@ -19,6 +19,7 @@ The format of this changelog is based on [Keep a Changelog](https://keepachangel
 * Add option to prevent toggling an ability off [#248]
 * Make key options respect macro condtions where able [#251]
 * Add option to automatically fall back to action bar abilities when no other macro conditions are met [#257]
+* Automatically populate macro when converting from a spell, item, or cancelaura binding [#264] (by [Gateswong])
 
 ### Fixed
 
@@ -1733,14 +1734,15 @@ The format of this changelog is based on [Keep a Changelog](https://keepachangel
 [0.4.0]: https://github.com/Snakybo/Clicked/releases/tag/0.4.0
 [0.3.0]: https://github.com/Snakybo/Clicked/releases/tag/0.3.0
 
-[#267]: https://github.com/Snakybo/Clicked/pull/267
-[#265]: https://github.com/Snakybo/Clicked/pull/265
-[#263]: https://github.com/Snakybo/Clicked/pull/263
-[#257]: https://github.com/Snakybo/Clicked/pull/257
-[#251]: https://github.com/Snakybo/Clicked/pull/251
-[#248]: https://github.com/Snakybo/Clicked/pull/248
-[#247]: https://github.com/Snakybo/Clicked/pull/247
-[#245]: https://github.com/Snakybo/Clicked/pull/245
+[#267]: https://github.com/Snakybo/Clicked/issues/267
+[#265]: https://github.com/Snakybo/Clicked/issues/265
+[#264]: https://github.com/Snakybo/Clicked/pull/264
+[#263]: https://github.com/Snakybo/Clicked/issues/263
+[#257]: https://github.com/Snakybo/Clicked/issues/257
+[#251]: https://github.com/Snakybo/Clicked/issues/251
+[#248]: https://github.com/Snakybo/Clicked/issues/248
+[#247]: https://github.com/Snakybo/Clicked/issues/247
+[#245]: https://github.com/Snakybo/Clicked/issues/245
 [#243]: https://github.com/Snakybo/Clicked/issues/243
 [#242]: https://github.com/Snakybo/Clicked/pull/242
 [#241]: https://github.com/Snakybo/Clicked/issues/241
@@ -1857,3 +1859,4 @@ The format of this changelog is based on [Keep a Changelog](https://keepachangel
 [nihilistzsche]: https://github.com/nihilistzsche
 [Aeceon]: https://github.com/Aeceon
 [m33shoq]: https://github.com/m33shoq
+[Gateswong]: https://github.com/Gateswong

Clicked/BindingConfig/BindingConfig.lua

@@ -991,21 +991,37 @@ function Addon.BindingConfig.Window:CreateTreeFrame()
 								if binding.actionType ~= type then
 									first = first or binding
 
-									-- When converting spell to macro, try pre-define name, icon and a "/cast" in macro.
-									if binding.actionType == Clicked.ActionType.SPELL and type == Clicked.ActionType.MACRO then
-										if binding.action.spellValue then
-											local spellName = C_Spell.GetSpellName(binding.action.spellValue)
-											local iconId, _ = C_Spell.GetSpellTexture(binding.action.spellValue)
-											if spellName then
-												binding.action.macroName = "Cast " .. spellName .. " (Macro)"
-												binding.action.macroValue = "/cast " .. spellName
-											end
-											if iconId then
-												binding.action.macroIcon = iconId
-											end
+									-- When converting to any macro, try to fill in the macro name, value and icon
+									if type == Clicked.ActionType.MACRO and Addon:IsNilOrEmpty(binding.action.macroValue) then
+										local name = nil
+										local icon = nil
+										local format = nil
+
+										if binding.actionType == Clicked.ActionType.SPELL then
+											name = C_Spell.GetSpellName(binding.action.spellValue)
+											icon = C_Spell.GetSpellTexture(binding.action.spellValue)
+											format = Addon.L["Cast %s"]
+										elseif binding.actionType == Clicked.ActionType.ITEM then
+											name = C_Item.GetItemNameByID(binding.action.itemValue)
+											icon = C_Item.GetItemIconByID(binding.action.itemValue)
+											format = Addon.L["Use %s"]
+										elseif binding.actionType == Clicked.ActionType.CANCELAURA then
+											name = C_Spell.GetSpellName(binding.action.auraName)
+											icon = C_Spell.GetSpellTexture(binding.action.auraName)
+											format = Addon.L["Cancel %s"]
 										end
+
+										if name ~= nil and format ~= nil then
+											binding.action.macroName = string.format(format, name)
+										end
+
+										if icon ~= nil then
+											binding.action.macroIcon = icon
+										end
+
+										binding.action.macroValue = Addon:GetMacroForBindings({ binding }, Addon.InteractionType.REGULAR, true)
 									end
-									
+
 									binding.actionType = type
 
 									Addon:ReloadBinding(binding, true)

Clicked/Core/BindingProcessor.lua

@@ -1201,9 +1201,10 @@ end
 ---
 --- @param bindings Binding[]
 --- @param interactionType number
+--- @param ignoreActionBar? boolean
 --- @return string macro
 --- @return string segments
-function Addon:GetMacroForBindings(bindings, interactionType)
+function Addon:GetMacroForBindings(bindings, interactionType, ignoreActionBar)
 	assert(type(bindings) == "table", "bad argument #1, expected table but got " .. type(bindings))
 	assert(type(interactionType) == "number", "bad argument #1, expected number but got " .. type(interactionType))
 
@@ -1347,7 +1348,7 @@ function Addon:GetMacroForBindings(bindings, interactionType)
 		do
 			local actionBar = {}
 
-			if Addon.db.profile.options.autoBindActionBar and interactionType == Addon.InteractionType.REGULAR then
+			if not ignoreActionBar and Addon.db.profile.options.autoBindActionBar and interactionType == Addon.InteractionType.REGULAR then
 				actionBar = Addon.SpellLibrary:GetActionBarSpells()
 			end