Implement metrics with the prometeus endpoint (#215)

* Implement metrics with the prometeus endpoint

* Add the metrics service

* Remove service yaml

* Self-review fixes

Author: s-vitaliy

.helm/templates/deployment.yaml

@@ -79,6 +79,8 @@ spec:
             value: {{ .Values.settings.telemetry.clusterName | default  "arcane-cluster"}}
           - name: ARCANE_OPERATOR__TELEMETRY__LOG_LEVEL
             value: {{ .Values.settings.telemetry.logLevel | default  "info"}}
+          - name: ARCANE_OPERATOR__TELEMETRY__METRICS_BIND_ADDRESS
+            value: {{ .Values.settings.telemetry.metricsBindAddressOverride | default (printf "0.0.0.0:%v" .Values.settings.telemetry.metricsPort) }}
       {{- if .Values.datadog.enabled }}
           - name: DATADOG__API_KEY
             valueFrom:

.helm/templates/service-metrics.yaml

@@ -0,0 +1,20 @@
+apiVersion: v1
+kind: Service
+metadata:
+  name: {{ include "app.name" . }}-metrics
+  labels:
+    {{- include "app.labels" $ | nindent 4 }}
+  {{- with .Values.additionalAnnotations }}
+  annotations:
+    {{- toYaml . | nindent 4 }}
+  {{- end }}
+spec:
+  type: ClusterIP
+  ports:
+    - port: {{ .Values.settings.telemetry.metricsPort }}
+      targetPort: {{ .Values.settings.telemetry.metricsPort }}
+      protocol: TCP
+      name: metrics
+  selector:
+    {{- include "app.selectorLabels" $ | nindent 4 }}
+

.helm/values.yaml

@@ -215,6 +215,14 @@ settings:
     # Name of the cluster the operator is deployed in
     clusterName: "arcane-cluster"
 
+    # Metrics bind port
+    metricsPort: 9090
+
+    # Address to bind the metrics endpoint to
+    # Note that if this is overridden, a corresponding Service resource must be created to expose the metrics endpoint
+    metricsBindAddressOverride: ""
+
+
 # Observability settings for Datadog
 datadog:
 

appconfig.yaml

@@ -10,4 +10,5 @@ periodic-metrics-reporter:
 
 telemetry:
   log-level: "Info"
-  cluster-name: "arcane-cluster"
+  cluster-name: "arcane-cluster"
+  metrics-bind-address: ":9090"

main.go

@@ -27,6 +27,7 @@ import (
 	"os/exec"
 	controllerruntime "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/manager"
+	metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
 	"strings"
 )
 
@@ -90,6 +91,9 @@ func main() {
 	}
 
 	mgr, err := controllerruntime.NewManager(kubeconfig, controllerruntime.Options{
+		Metrics: metricsserver.Options{
+			BindAddress: appConfig.Telemetry.MetricsBindAddress,
+		},
 		Scheme: scheme,
 	})
 	if err != nil {

telemetry/logging_config.go

@@ -6,4 +6,7 @@ type Config struct {
 
 	// ClusterName sets the name of the cluster where the application is running.
 	ClusterName string `mapstructure:"cluster-name,omitempty"`
+
+	// MetricsBindAddress sets the address for binding the metrics server.
+	MetricsBindAddress string `mapstructure:"metrics-bind-address,omitempty"`
 }