Skip to content

Commit 7d8c4fd

Browse files
committed
Self-review fixes
1 parent d5cab58 commit 7d8c4fd

File tree

2 files changed

+1
-43
lines changed

2 files changed

+1
-43
lines changed

.helm/templates/cron-job-garbage-collector.yaml

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -66,50 +66,8 @@ spec:
6666
| head -n $HISTORY_LIMIT \
6767
| xargs --no-run-if-empty -n2 kubectl delete backfillrequests --namespace
6868
env:
69-
- name: APPLICATION_VERSION
70-
value: "{{ (default (printf "v%s" .Chart.AppVersion) .Values.garbageCollector.image.tag) }}"
7169
- name: HISTORY_LIMIT
7270
value: "{{ .Values.garbageCollector.historyLimit }}"
73-
{{- if .Values.datadog.enabled }}
74-
- name: DATADOG__API_KEY
75-
valueFrom:
76-
secretKeyRef:
77-
name: {{ .Values.datadog.apiKeySecret | quote }}
78-
key: {{ .Values.datadog.apiKeySecretKey | quote }}
79-
- name: DATADOG__ENDPOINT
80-
value: {{ .Values.datadog.endpoint | quote }}
81-
- name: DATADOG__APPLICATION_HOST
82-
valueFrom:
83-
fieldRef:
84-
fieldPath: metadata.name
85-
{{- if .Values.datadog.enableOriginDetection }}
86-
- name: DD_ENTITY_ID
87-
valueFrom:
88-
fieldRef:
89-
fieldPath: metadata.uid
90-
{{- end }}
91-
{{- if .Values.datadog.tracer.enabled }}
92-
- name: DD_INSTRUMENTATION_TELEMETRY_ENABLED
93-
value: {{ not .Values.datadog.tracer.disable_vendor_telemetry | quote }}
94-
- name: DD_TRACE_ENABLED
95-
value: {{ .Values.datadog.tracer.enabled | quote }}
96-
- name: DD_TRACE_AGENT_URL
97-
value: {{ .Values.datadog.tracer.agent_url | quote }}
98-
- name: DD_ENV
99-
value: {{ .Values.datadog.tracer.service_env | quote }}
100-
{{- end }}
101-
- name: DATADOG__SERVICE_NAME
102-
value: {{ .Values.datadog.serviceName }}
103-
- name: DD_SERVICE
104-
value: {{ .Values.datadog.serviceName }}
105-
- name: DD_VERSION
106-
value: "{{ (default (printf "v%s" .Chart.AppVersion) .Values.garbageCollector.image.tag) }}"
107-
- name: DD_DOGSTATSD_URL
108-
value: {{ .Values.datadog.statsdUrl | quote }}
109-
{{- end }}
110-
{{- with .Values.extraEnv }}
111-
{{- toYaml . | nindent 14 }}
112-
{{- end }}
11371
{{- if .Values.extraEnvFrom }}
11472
envFrom:
11573
{{- with .Values.extraEnvFrom }}

.helm/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ garbageCollector:
296296
restartPolicy: "OnFailure"
297297

298298
# Maximum length of the BackfillRequest deletion history
299-
historyLimit: 10
299+
historyLimit: 300
300300

301301
# Resource constraints for the garbage collector job
302302
resources: {}

0 commit comments

Comments
 (0)