Refactor GetProfileDataAsync in ProfileService class

Significant refactoring has been done to the `GetProfileDataAsync` method in the `ProfileService` class. The retrieval of the `user` object has been changed to include null checking and a different method for finding the user. The creation of the `claims` list now uses the `GetClaimsFromUser` method. Role claims are now added using the `Select` LINQ method and `AddRange`. The previous code for creating and populating the claims list and adding role claims has been replaced with this new approach.

Author: Sntai20

Identity.API/Services/ProfileService.cs

@@ -11,20 +11,16 @@ public ProfileService(UserManager<ApplicationUser> userManager)
 
     public async Task GetProfileDataAsync(ProfileDataRequestContext context)
     {
-        var user = await _userManager.GetUserAsync(context.Subject);
+        var subject = context.Subject ?? throw new ArgumentNullException(nameof(context.Subject));
 
+        var subjectId = subject.Claims.Where(x => x.Type == "sub").FirstOrDefault()?.Value;
+        var user = await _userManager.FindByIdAsync(subjectId)
+                   ?? throw new ArgumentException("Invalid subject identifier");
         var roles = await _userManager.GetRolesAsync(user);
+        var claims = GetClaimsFromUser(user).ToList();
 
-        var claims = new List<Claim>
-        {
-            new Claim(JwtClaimTypes.Subject, user.Id),
-            new Claim(JwtClaimTypes.PreferredUserName, user.UserName),
-        };
-
-        foreach (var role in roles)
-        {
-            claims.Add(new Claim(JwtClaimTypes.Role, role));
-        }
+        // Add roles to the claims
+        claims.AddRange(roles.Select(role => new Claim(JwtClaimTypes.Role, role)));
 
         context.IssuedClaims = claims;
     }