Update rule editor font size immediately

Add support for listening to preference changes. Use this to immediately update
editor fonts when the user changes the preference. This makes the new shortcuts
very handy.

Author: garfieldnate

src/main/java/edu/umich/soar/visualsoar/dialogs/prefs/PreferencesDialog.java

@@ -87,7 +87,7 @@ public PreferencesDialog(final Frame owner) {
             BorderFactory.createEmptyBorder(10, 10, 10, 10)));
     editorFontPanel.add(Box.createHorizontalBox());
     editorFontPanel.add(new JLabel("Font Size: "));
-    editorFontField.setText(String.valueOf(SoarDocument.getFontSize()));
+    editorFontField.setText(Prefs.editorFontSize.get());
     editorFontPanel.add(editorFontField);
 
     ruleEditorPanel.setLayout(new BoxLayout(ruleEditorPanel, BoxLayout.Y_AXIS));
@@ -155,8 +155,7 @@ public void actionPerformed(ActionEvent e) {
 
             // Set a new font size
             int fontSize = getFontSize();
-            if (fontSize != SoarDocument.getFontSize()) {
-              SoarDocument.setFontSize(fontSize);
+            if (fontSize != Prefs.editorFontSize.getInt()) {
               Prefs.editorFontSize.setInt(fontSize);
             }
           }
@@ -168,7 +167,7 @@ public void actionPerformed(ActionEvent e) {
    * enforce min/max rules.
    */
   private int getFontSize() {
-    int fontSize = SoarDocument.getFontSize();
+    int fontSize = Prefs.editorFontSize.getInt();
     try {
       fontSize = Integer.parseInt(editorFontField.getText());
     } catch (NumberFormatException nfe) {

src/main/java/edu/umich/soar/visualsoar/misc/Prefs.java

@@ -9,10 +9,17 @@
 import java.io.IOException;
 import java.io.PrintWriter;
 import java.nio.file.FileSystems;
+import java.util.ArrayList;
+import java.util.List;
 import java.util.Vector;
 import java.util.prefs.BackingStoreException;
 import java.util.prefs.Preferences;
 
+/**
+ * Preference values are persisted on the user's computer. Clients can listen for changes by
+ * creating a {@link PrefsChangeListener} and passing it to {@link
+ * #addChangeListener(PrefsChangeListener)} for the particular preference of interest.
+ */
 public enum Prefs {
     openFolder(System.getProperty("user.dir")),
     autoTileEnabled(true),
@@ -347,6 +354,15 @@ public static void addRecentProject(File newbie, boolean readOnly) {
   private final boolean defBoolean;
   private final int defInt;
 
+  public interface PrefsChangeListener {
+    /**
+     * @param newValue new String, boolean, or integer value
+     */
+    void onPreferenceChanged(Object newValue);
+  }
+
+  private final List<PrefsChangeListener> listeners = new ArrayList<>();
+
   Prefs(String def) {
     this.def = def;
     this.defBoolean = false;
@@ -365,36 +381,52 @@ public static void addRecentProject(File newbie, boolean readOnly) {
     this.defInt = def;
   }
 
-    public String get() {
-        return preferences.get(this.toString(), def);
-    }
+  public void addChangeListener(PrefsChangeListener listener) {
+    listeners.add(listener);
+  }
 
-    public void set(String value) {
-        preferences.put(this.toString(), value);
-    }
+  public void removeChangeListener(PrefsChangeListener listener) {
+    listeners.remove(listener);
+  }
 
-    public boolean getBoolean() {
-        return preferences.getBoolean(this.toString(), defBoolean);
+  private void notifyListeners(Object newValue) {
+    for (PrefsChangeListener listener : listeners) {
+      listener.onPreferenceChanged(newValue);
     }
+  }
 
-    public void setBoolean(boolean value) {
-        preferences.putBoolean(this.toString(), value);
-    }
+  public String get() {
+    return preferences.get(this.toString(), def);
+  }
+
+  public void set(String value) {
+    preferences.put(this.toString(), value);
+    notifyListeners(value);
+  }
+
+  public boolean getBoolean() {
+    return preferences.getBoolean(this.toString(), defBoolean);
+  }
+
+  public void setBoolean(boolean value) {
+    preferences.putBoolean(this.toString(), value);
+    notifyListeners(value);
+  }
 
   public int getInt() {
     return preferences.getInt(this.toString(), defInt);
   }
 
   public void setInt(int value) {
     preferences.putInt(this.toString(), value);
+    notifyListeners(value);
   }
 
-    public static void flush() {
-        try {
-            preferences.flush();
-        } catch (BackingStoreException e) {
-            e.printStackTrace();
-        }
+  public static void flush() {
+    try {
+      preferences.flush();
+    } catch (BackingStoreException e) {
+      e.printStackTrace();
     }
-
+  }
 }

src/main/java/edu/umich/soar/visualsoar/ruleeditor/EditorPane.java

@@ -258,6 +258,17 @@ public void read(Reader in) throws IOException {
     }
   }
 
+  @Override
+  public void removeNotify() {
+    super.removeNotify();
+
+    // perform document cleanup
+    SoarDocument doc = getSoarDocument();
+    if (doc != null) {
+      doc.close();
+    }
+  }
+
   /** Colors the syntax of the whole document */
   public void colorSyntax() {
     getSoarDocument().colorSyntax(new StringReader(getText()));

src/main/java/edu/umich/soar/visualsoar/ruleeditor/SoarDocument.java

@@ -5,6 +5,8 @@
 import edu.umich.soar.visualsoar.misc.SyntaxColor;
 import edu.umich.soar.visualsoar.parser.*;
 
+import javax.swing.*;
+import javax.swing.event.DocumentEvent;
 import javax.swing.text.*;
 import java.awt.*;
 import java.io.IOException;
@@ -34,27 +36,51 @@ public class SoarDocument extends DefaultStyledDocument {
 
     /** to support Read-Only mode */
     public boolean isReadOnly = false;
+    private Prefs.PrefsChangeListener fontSizeListener;
 
 
-    public SoarDocument() {
+  public SoarDocument() {
         colorTable = Prefs.getSyntaxColors().clone();
 
         //set font size and style
         Style defaultStyle = this.getStyle("default");
         MutableAttributeSet attributeSet = new SimpleAttributeSet();
-        SoarDocument.fontSize = Integer.parseInt(Prefs.editorFontSize.get());
-        StyleConstants.setFontSize(attributeSet, SoarDocument.fontSize);
+        StyleConstants.setFontSize(attributeSet, Prefs.editorFontSize.getInt());
         defaultStyle.addAttributes(attributeSet);
-    }
 
-    public static int getFontSize() {
-        return SoarDocument.fontSize;
-    }
+        fontSizeListener = newVal -> {
+          try {
+            int newFontSize = (int) newVal;
+            setFontSize(newFontSize);
+          } catch (ClassCastException e) {
+            e.printStackTrace();
+          }
+        };
 
-    public static void setFontSize(int size) {
-        SoarDocument.fontSize = size;
+        Prefs.editorFontSize.addChangeListener(fontSizeListener);
     }
 
+  public void setFontSize(int size) {
+    SoarDocument.fontSize = size;
+
+    // Create or update a style for the font size
+    StyleContext context = StyleContext.getDefaultStyleContext();
+    Style fontStyle = context.getStyle(StyleContext.DEFAULT_STYLE);
+
+    // Update the font size in the style
+    MutableAttributeSet attributeSet = new SimpleAttributeSet();
+    StyleConstants.setFontSize(attributeSet, size);
+    fontStyle.addAttributes(attributeSet);
+
+    // Apply the updated style to the entire document
+    SwingUtilities.invokeLater(() -> {
+      setCharacterAttributes(0, getLength(), attributeSet, false);
+
+      // Notify observers to repaint the editor
+      fireChangedUpdate(new DefaultDocumentEvent(0, getLength(), DocumentEvent.EventType.CHANGE));
+    });
+  }
+
     public String getLastInsertedText() {
         return this.lastInsertedText;
     }
@@ -1158,5 +1184,13 @@ public String cropComments(String prevLine) {
         return prevLine;
     }
 
-
+  /** Cleanup method to be called when the document is closed. */
+  public void close() {
+    // Remove the font size listener so that we don't accumulate them every time a new window
+    // is opened and closed
+    if (fontSizeListener != null) {
+      Prefs.editorFontSize.removeChangeListener(fontSizeListener);
+      fontSizeListener = null;
+    }
+  }
 } // class SoarDocument