Fix unresponsive operator hierarchy font size

and call UI-updating actions on the EDT everywhere for consistency and to avoid
deadlocks.

Author: garfieldnate

src/main/java/edu/umich/soar/visualsoar/datamap/DataMapTree.java

@@ -379,14 +379,13 @@ public DataMapTree(DataMap initParent, TreeModel model, SoarWorkingMemoryModel _
     }//ctor
 
   private void setFontSize(int fontSize) {
-    final Font newSizedFont =
-      new Font(
-        getFont().getName(),
-        getFont().getStyle(),
-        fontSize);
-    setFont(newSizedFont);
-    setRowHeight(fontSize + ROW_TEXT_MARGIN);
-    FontUtils.setContainerFontSize(contextMenu, fontSize);
+    final Font newSizedFont = new Font(getFont().getName(), getFont().getStyle(), fontSize);
+    SwingUtilities.invokeLater(
+        () -> {
+          setFont(newSizedFont);
+          setRowHeight(fontSize + ROW_TEXT_MARGIN);
+          FontUtils.setContainerFontSize(contextMenu, fontSize);
+        });
   }
 
     /**

src/main/java/edu/umich/soar/visualsoar/mainframe/MainFrame.java

@@ -227,20 +227,26 @@ public void windowClosing(WindowEvent e)
     Prefs.editorFontSize.addChangeListener(newValue -> setFontSize((int) newValue));
 	}//MainFrame ctor
 
-////////////////////////////////////////
-// Methods
-////////////////////////////////////////
+  ////////////////////////////////////////
+  // Methods
+  ////////////////////////////////////////
 
   private void setFontSize(int fontSize) {
-    setMenuBarFontSize(getJMenuBar(), fontSize);
-    feedbackListBorder.setTitleFont(getResizedFont(feedbackListBorder.getTitleFont(), fontSize));
-    UIManager.getLookAndFeelDefaults().forEach((key, value) -> {
-      if (key.toString().endsWith(".font") && value instanceof Font) {
-        Font oldFont = (Font) value;
-        Font newFont = new Font(oldFont.getName(), oldFont.getStyle(), fontSize);
-        UIManager.put(key, newFont);
-      }
-    });
+    SwingUtilities.invokeLater(
+        () -> {
+          setMenuBarFontSize(getJMenuBar(), fontSize);
+          feedbackListBorder.setTitleFont(
+              getResizedFont(feedbackListBorder.getTitleFont(), fontSize));
+          UIManager.getLookAndFeelDefaults()
+              .forEach(
+                  (key, value) -> {
+                    if (key.toString().endsWith(".font") && value instanceof Font) {
+                      Font oldFont = (Font) value;
+                      Font newFont = new Font(oldFont.getName(), oldFont.getStyle(), fontSize);
+                      UIManager.put(key, newFont);
+                    }
+                  });
+        });
   }
 
   private boolean canAutoTile() {

src/main/java/edu/umich/soar/visualsoar/mainframe/feedback/FeedbackCellRenderer.java

@@ -17,6 +17,7 @@ public FeedbackCellRenderer() {
     setOpaque(true);
   }
 
+  /** This method should only be called from the EDT, and it does not take care to do so itself. */
   void setFontSize(int fontSize) {
     final Font newSizedFont = new Font(getFont().getName(), getFont().getStyle(), fontSize);
     setFont(newSizedFont);

src/main/java/edu/umich/soar/visualsoar/mainframe/feedback/FeedbackList.java

@@ -107,9 +107,12 @@ else if (SwingUtilities.isRightMouseButton(e)) {
 
   private void setFontSize(int fontSize) {
     final Font newSizedFont = new Font(getFont().getName(), getFont().getStyle(), fontSize);
-    setFont(newSizedFont);
-    setContainerFontSize(rightClickContextMenu, fontSize);
-    cellRenderer.setFontSize(fontSize);
+    SwingUtilities.invokeLater(
+        () -> {
+          setFont(newSizedFont);
+          setContainerFontSize(rightClickContextMenu, fontSize);
+          cellRenderer.setFontSize(fontSize);
+        });
   }
 
 ///////////////////////////////////////////////////////////////////

src/main/java/edu/umich/soar/visualsoar/operatorwindow/OperatorWindow.java

@@ -51,6 +51,8 @@ public class OperatorWindow extends JTree {
     DragGestureListener dgListener = new OWDragGestureListener();
 
   private ProjectModel projectModel;
+
+  private final DefaultTreeCellRenderer owCellRenderer = new OperatorWindowRenderer();
   private static OperatorWindow s_OperatorWindow;
 
   private static final int ROW_TEXT_MARGIN = 7;
@@ -63,7 +65,7 @@ public class OperatorWindow extends JTree {
    */
   private OperatorWindow() {
 
-    setCellRenderer(new OperatorWindowRenderer());
+    setCellRenderer(owCellRenderer);
 
     s_OperatorWindow = this;
 
@@ -119,15 +121,16 @@ public void mouseReleased(MouseEvent e) {
     }
     setFontSize(Prefs.editorFontSize.getInt());
     Prefs.editorFontSize.addChangeListener(
-        newValue -> {
-          setFontSize((int) newValue);
-        });
+        newValue -> setFontSize((int) newValue));
   }
 
   private void setFontSize(int fontSize) {
     final Font newSizedFont = new Font(getFont().getName(), getFont().getStyle(), fontSize);
-    setFont(newSizedFont);
-    setRowHeight(fontSize + ROW_TEXT_MARGIN);
+    SwingUtilities.invokeLater(() -> {
+      setFont(newSizedFont);
+      owCellRenderer.setFont(newSizedFont);
+      setRowHeight(fontSize + ROW_TEXT_MARGIN);
+    });
   }
 
     /**

src/main/java/edu/umich/soar/visualsoar/ruleeditor/RuleEditor.java

@@ -1040,8 +1040,11 @@ private void initMenuBar() {
     }
 
   private void setFontSize(int fontSize) {
-    setMenuBarFontSize(getJMenuBar(), fontSize);
-    setContainerFontSize(editorPane.getContextMenu(), fontSize);
+    SwingUtilities.invokeLater(
+        () -> {
+          setMenuBarFontSize(getJMenuBar(), fontSize);
+          setContainerFontSize(editorPane.getContextMenu(), fontSize);
+        });
   }
 
     private void initMenuBarExternFile() {