working non-wonky key typing pass-through

The key was using keyTyped instead of keyDown, which allows closing and passing
the key type to the parent, which inserts the typed letter..

Also select position 0 by default.

Also show and clear instructions.

Author: garfieldnate

src/main/java/edu/umich/soar/visualsoar/components/AutocompletePopup.java

@@ -1,13 +1,5 @@
 package edu.umich.soar.visualsoar.components;
 
-import javax.swing.BorderFactory;
-import javax.swing.JList;
-import javax.swing.JPanel;
-import javax.swing.JPopupMenu;
-import javax.swing.JScrollPane;
-import javax.swing.ListSelectionModel;
-import javax.swing.text.BadLocationException;
-import javax.swing.text.JTextComponent;
 import java.awt.BorderLayout;
 import java.awt.Color;
 import java.awt.Dimension;
@@ -22,8 +14,15 @@
 import java.util.Set;
 import java.util.Vector;
 import java.util.function.Consumer;
+import javax.swing.BorderFactory;
+import javax.swing.JList;
+import javax.swing.JPanel;
+import javax.swing.JPopupMenu;
+import javax.swing.JScrollPane;
+import javax.swing.ListSelectionModel;
+import javax.swing.text.BadLocationException;
+import javax.swing.text.JTextComponent;
 
-// WIP; need to draw out state diagram. Log 40 minutes.
 public class AutocompletePopup extends JPopupMenu {
 
   private static final Set<Integer> CURSOR_MOVEMENT_PASSTHROUGH_KEYS =
@@ -41,6 +40,7 @@ public AutocompletePopup(
     int maxVisibleRows = Math.min(suggestions.size(), 10); // Limit to 10 rows max
     // Create the suggestion list
     JList<String> suggestionList = new JList<>(new Vector<>(suggestions));
+    suggestionList.setSelectedIndex(0);
     suggestionList.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
     suggestionList.setVisibleRowCount(maxVisibleRows);
 
@@ -74,11 +74,6 @@ public void mouseMoved(MouseEvent e) {
         new KeyAdapter() {
           @Override
           public void keyPressed(KeyEvent e) {
-            if (e.getKeyCode() == KeyEvent.VK_ESCAPE) {
-              setVisible(false);
-              e.consume();
-              return;
-            }
             if (e.getKeyCode() == KeyEvent.VK_ENTER) {
               int index = suggestionList.getSelectedIndex();
               if (index >= 0) {
@@ -89,6 +84,8 @@ public void keyPressed(KeyEvent e) {
                 return;
               }
             }
+            // UP/DOWN keys navigate selection; custom handling here allows wrapping between
+            // start/end of list
             if (e.getKeyCode() == KeyEvent.VK_UP || e.getKeyCode() == KeyEvent.VK_DOWN) {
               int index = suggestionList.getSelectedIndex();
               if (index == -1) {
@@ -106,13 +103,20 @@ public void keyPressed(KeyEvent e) {
               e.consume();
               return;
             }
+            // Unambiguous cursor movement keys are passed through to parent after closing this
+            // popup
             if (CURSOR_MOVEMENT_PASSTHROUGH_KEYS.contains(e.getKeyCode())) {
               setVisible(false);
-              // Pass the event to the parent component to handle cursor movement
               parent.dispatchEvent(e);
-              return;
             }
           }
+
+          @Override
+          public void keyTyped(KeyEvent e) {
+            // typing closes the popup and types in the parent
+            setVisible(false);
+            parent.dispatchEvent(e);
+          }
         });
 
     // Calculate the preferred height based on the number of items
@@ -145,4 +149,9 @@ public void keyPressed(KeyEvent e) {
       ex.printStackTrace();
     }
   }
+
+
+  public String shortInstructions() {
+    return "UP/DOWN to select; ENTER to confirm";
+  }
 }

src/main/java/edu/umich/soar/visualsoar/mainframe/feedback/FeedbackManager.java

@@ -90,6 +90,10 @@ public void clearFeedback() {
     onCountUpdate.accept(feedbackList.getListSize());
   }
 
+  public void clearStatusBar() {
+    statusBar.setText("");
+  }
+
   /**
    * Method updates the status bar text with a message
    */

src/main/java/edu/umich/soar/visualsoar/ruleeditor/EditorPane.java

@@ -35,6 +35,10 @@ public static void setCurrentSelectionOccurrenceHighlightColor(Color c) {
     occurrenceHighlightPainter = new DefaultHighlighter.DefaultHighlightPainter(c);
   }
 
+  protected void processKeyEvent(KeyEvent e) {
+    super.processKeyEvent(e);
+  }
+
   public EditorPane() {
 
     if (Prefs.highlightingEnabled.getBoolean()) {

src/main/java/edu/umich/soar/visualsoar/ruleeditor/RuleEditor.java

@@ -1845,6 +1845,24 @@ private void showAutocompletePopup(int pos, String userType, List<String> comple
       return;
     }
     autocompletePopup = new AutocompletePopup(editorPane, pos, completeMatches, (selected) -> insertCompletion(pos, userType, selected));
+    MainFrame.getMainFrame().getFeedbackManager().setStatusBarMsg(autocompletePopup.shortInstructions());
+    autocompletePopup.addPopupMenuListener(new PopupMenuListener() {
+      @Override
+      public void popupMenuWillBecomeVisible(PopupMenuEvent e) {
+
+      }
+
+      @Override
+      public void popupMenuWillBecomeInvisible(PopupMenuEvent e) {
+        MainFrame.getMainFrame().getFeedbackManager().clearStatusBar();
+        autocompletePopup = null;
+      }
+
+      @Override
+      public void popupMenuCanceled(PopupMenuEvent e) {
+
+      }
+    });
   }
 
   private void hideAutocompletePopup() {