fix: 1190 fusager account creation DROM and Corse (#1029)

## Ticket(s) lié(s)
1190
## Description
Correction de la création de compte pour les utilisateurs OVA dont le
SIRET dépend d'une DROM ou de la région Corse

Author: l-scherer

packages/backend/src/controllers/authentication/email/__tests__/register.test.js

@@ -102,11 +102,11 @@ describe("register controller", () => {
     User.read.mockResolvedValue([]);
     insee.getEtablissement.mockResolvedValue({
       adresseEtablissement: {
-        codePostalEtablissement: "75001",
+        codeCommuneEtablissement: "75101",
       },
     });
     getFichesTerritoireForRegionByInseeCode.mockResolvedValue({
-      terCode: "TER123",
+      inseeCode: "75101",
     });
     User.registerByEmail.mockRejectedValue(new Error("DB failure"));
 
@@ -119,11 +119,11 @@ describe("register controller", () => {
     User.read.mockResolvedValue([]);
     insee.getEtablissement.mockResolvedValue({
       adresseEtablissement: {
-        codePostalEtablissement: "75001",
+        codeCommuneEtablissement: "75101",
       },
     });
     getFichesTerritoireForRegionByInseeCode.mockResolvedValue({
-      terCode: "TER123",
+      inseeCode: "75101",
     });
     User.registerByEmail.mockResolvedValue({
       user: { id: 1 },
@@ -142,11 +142,11 @@ describe("register controller", () => {
     User.read.mockResolvedValue([]);
     insee.getEtablissement.mockResolvedValue({
       adresseEtablissement: {
-        codePostalEtablissement: "75001",
+        codeCommuneEtablissement: "75101",
       },
     });
     getFichesTerritoireForRegionByInseeCode.mockResolvedValue({
-      terCode: "TER123",
+      inseeCode: "75101",
     });
     User.registerByEmail.mockResolvedValue({
       user: { id: 1 },

packages/backend/src/controllers/authentication/email/register.js

@@ -56,9 +56,10 @@ module.exports = async function register(req, res, next) {
   let territoire = "";
   try {
     const etablissement = await insee.getEtablissement(siret);
-    const codePostal =
-      etablissement.adresseEtablissement.codePostalEtablissement;
-    territoire = await getFichesTerritoireForRegionByInseeCode(codePostal);
+    const inseeCode = String(
+      etablissement.adresseEtablissement.codeCommuneEtablissement,
+    );
+    territoire = await getFichesTerritoireForRegionByInseeCode({ inseeCode });
   } catch (error) {
     log.w("DONE with error");
     return next(error);

packages/backend/src/services/Territoire.js

@@ -1,6 +1,7 @@
 const AppError = require("../utils/error");
 const logger = require("../utils/logger");
 const pool = require("../utils/pgpool").getPool();
+const getCodeTerritoireByInseeCode = require("../utils/geo");
 
 const log = logger(module.filename);
 const {
@@ -56,22 +57,19 @@ const query = {
     FROM geo.territoires ter
     INNER JOIN back.fiche_territoire fte ON fte.ter_code = ter.code
     WHERE ter.code <> 'FRA'`,
-  selectTerritoiresByInseeCode: (inseeCode) => [
-    `
-    SELECT
-      ft.id,
-      ft.ter_code AS "terCode",
-      ft.service_mail AS "serviceMail",
-      ft.service_telephone AS "serviceTelephone",
-      ft.corresp_vao_nom AS "correspVaoNom",
-      ft.corresp_vao_prenom AS "correspVaoPrenom",
-      ft.edited_at AS "editedAt"
-    FROM back.fiche_territoire ft
-    JOIN geo.territoires t ON ft.ter_code = t.parent_code
-    WHERE t.code = $1;
-    `,
-    [inseeCode],
-  ],
+  selectTerritoiresByInseeCode: `
+  SELECT
+    ft.id,
+    ft.ter_code AS "terCode",
+    ft.service_mail AS "serviceMail",
+    ft.service_telephone AS "serviceTelephone",
+    ft.corresp_vao_nom AS "correspVaoNom",
+    ft.corresp_vao_prenom AS "correspVaoPrenom",
+    ft.edited_at AS "editedAt"
+  FROM back.fiche_territoire ft
+  JOIN geo.territoires t ON ft.ter_code = t.parent_code
+  WHERE t.code = $1;
+`,
 
   update: `
       UPDATE back.fiche_territoire
@@ -170,10 +168,12 @@ module.exports.update = async (id, { nom, prenom, email, telephone }) => {
   return { territoire: response.rows[0] };
 };
 
-module.exports.getFichesTerritoireForRegionByInseeCode = async (InseeCode) => {
-  const code = InseeCode.substring(0, 2);
-  const { rows } = await pool.query(
-    ...query.selectTerritoiresByInseeCode(code),
-  );
+module.exports.getFichesTerritoireForRegionByInseeCode = async ({
+  inseeCode,
+}) => {
+  const terCode = getCodeTerritoireByInseeCode({ inseeCode });
+  const { rows } = await pool.query(query.selectTerritoiresByInseeCode, [
+    terCode,
+  ]);
   return rows[0];
 };

packages/backend/src/services/__tests__/territoires.test.js

@@ -0,0 +1,33 @@
+jest.mock("../../utils/error");
+const pgpool = require("../../utils/pgpool");
+
+jest.mock("../../utils/pgpool", () => {
+  const mockQuery = jest.fn();
+  return {
+    getPool: jest.fn(() => ({ query: mockQuery })),
+    __mockQuery: mockQuery,
+  };
+});
+
+describe("Service Territoire", () => {
+  describe("getFichesTerritoireForRegionByInseeCode", () => {
+    it("should return a valid id for any valid inseeCode", async () => {
+      const pool = pgpool.getPool();
+
+      pool.query.mockImplementation((sql, params) => {
+        expect(sql).toMatch(/SELECT/);
+        expect(params).toEqual(["972"]);
+        return Promise.resolve({ rows: [{ id: 12, terCode: "MAR" }] });
+      });
+
+      const ficheTerritoire = require("../Territoire");
+      const result =
+        await ficheTerritoire.getFichesTerritoireForRegionByInseeCode({
+          inseeCode: "97200",
+        });
+
+      expect(result).toEqual({ id: 12, terCode: "MAR" });
+      expect(pool.query).toHaveBeenCalledTimes(1);
+    });
+  });
+});

packages/backend/src/utils/geo.js

@@ -0,0 +1,6 @@
+module.exports = function getCodeTerritoireByInseeCode({ inseeCode } = {}) {
+  if (!inseeCode) return "";
+  return inseeCode.startsWith("97")
+    ? inseeCode.slice(0, 3)
+    : inseeCode.slice(0, 2);
+};

packages/backend/src/utils/geo.spec.js

@@ -0,0 +1,43 @@
+/*
+Test Geo
+ */
+const getCodeTerritoireByInseeCode = require("./geo");
+
+describe("getCodeTerritoireByInseeCode", () => {
+  it("should return first 2 digits for metropolitan France codes", () => {
+    expect(getCodeTerritoireByInseeCode({ inseeCode: "75056" })).toBe("75");
+    expect(getCodeTerritoireByInseeCode({ inseeCode: "13001" })).toBe("13");
+    expect(getCodeTerritoireByInseeCode({ inseeCode: "06088" })).toBe("06");
+  });
+
+  it("should return first 3 digits for overseas codes starting with 97", () => {
+    expect(getCodeTerritoireByInseeCode({ inseeCode: "97123" })).toBe("971");
+    expect(getCodeTerritoireByInseeCode({ inseeCode: "97245" })).toBe("972");
+    expect(getCodeTerritoireByInseeCode({ inseeCode: "97356" })).toBe("973");
+    expect(getCodeTerritoireByInseeCode({ inseeCode: "97489" })).toBe("974");
+    expect(getCodeTerritoireByInseeCode({ inseeCode: "97612" })).toBe("976");
+  });
+
+  it("should handle short codes correctly", () => {
+    expect(getCodeTerritoireByInseeCode({ inseeCode: "97" })).toBe("97");
+    expect(getCodeTerritoireByInseeCode({ inseeCode: "971" })).toBe("971");
+    expect(getCodeTerritoireByInseeCode({ inseeCode: "75" })).toBe("75");
+  });
+
+  it("should return first 2 characters for Corsica codes (2A/2B)", () => {
+    expect(getCodeTerritoireByInseeCode({ inseeCode: "2A004" })).toBe("2A");
+    expect(getCodeTerritoireByInseeCode({ inseeCode: "2A200" })).toBe("2A");
+    expect(getCodeTerritoireByInseeCode({ inseeCode: "2B033" })).toBe("2B");
+    expect(getCodeTerritoireByInseeCode({ inseeCode: "2B300" })).toBe("2B");
+  });
+
+  it("should handle empty string", () => {
+    expect(getCodeTerritoireByInseeCode({ inseeCode: "" })).toBe("");
+  });
+
+  it("should handle non-string input gracefully", () => {
+    expect(getCodeTerritoireByInseeCode({ inseeCode: null })).toBe("");
+    expect(getCodeTerritoireByInseeCode({ inseeCode: undefined })).toBe("");
+    expect(getCodeTerritoireByInseeCode()).toBe(""); // test du cas sans argument
+  });
+});