Skip to content

Commit 5901320

Browse files
committed
Back to --loglevel=silent
1 parent 31e0d46 commit 5901320

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

src/shadow/npm/bin.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,10 @@ export default async function shadowBin(
4747
constants.distShadowNpmInjectPath,
4848
// Lazily access constants.shadowBinPath.
4949
await installLinks(constants.shadowBinPath, binName),
50-
// Add `--no-progress` and `--loglevel=error` flags to fix input being
51-
// swallowed by the npm spinner.
50+
// Add `--no-progress` to fix input being swallowed by the npm spinner.
5251
'--no-progress',
53-
// Add the '--loglevel=error' flag if a loglevel flag is not provided.
54-
...(binArgs.some(isLoglevelFlag) ? [] : ['--loglevel', 'error']),
52+
// Add the '--loglevel=silent' flag if a loglevel flag is not provided.
53+
...(binArgs.some(isLoglevelFlag) ? [] : ['--loglevel', 'silent']),
5554
...binArgs,
5655
...otherArgs
5756
],

src/utils/npm.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export function safeNpmInstall(options?: SafeNpmInstallOptions) {
4242
).filter(a => !isAuditFlag(a) && !isFundFlag(a) && !isProgressFlag(a))
4343
const otherArgs = terminatorPos === -1 ? [] : args.slice(terminatorPos)
4444
const isSilent = !useDebug && !npmArgs.some(isLoglevelFlag)
45-
const logLevelArgs = isSilent ? ['--loglevel', 'error'] : []
45+
const logLevelArgs = isSilent ? ['--loglevel', 'silent'] : []
4646
const spawnPromise = spawn(
4747
// Lazily access constants.execPath.
4848
constants.execPath,
@@ -67,10 +67,9 @@ export function safeNpmInstall(options?: SafeNpmInstallOptions) {
6767
// Avoid code paths for 'audit' and 'fund'.
6868
'--no-audit',
6969
'--no-fund',
70-
// Add `--no-progress` flag to fix input being swallowed by the spinner
71-
// when running the command with recent versions of npm.
70+
// Add `--no-progress` to fix input being swallowed by the npm spinner.
7271
'--no-progress',
73-
// Add '--loglevel=error' if a loglevel flag is not provided and the
72+
// Add '--loglevel=silent' if a loglevel flag is not provided and the
7473
// SOCKET_CLI_DEBUG environment variable is not truthy.
7574
...logLevelArgs,
7675
...npmArgs,

0 commit comments

Comments
 (0)