Skip to content

Commit 980461a

Browse files
author
Pelle Wessman
committed
Fix types on TS@next
1 parent 9e14438 commit 980461a

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

lib/commands/info/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ async function fetchPackageData (pkgName, pkgVersion, { includeAllIssues, strict
147147
const result = await handleApiCall(socketSdk.getIssuesByNPMPackage(pkgName, pkgVersion), spinner, 'looking up package')
148148

149149
if (result.success === false) {
150-
return handleUnsuccessfulApiResponse(result, spinner)
150+
return handleUnsuccessfulApiResponse('getIssuesByNPMPackage', result, spinner)
151151
}
152152

153153
// Conclude the status of the API call

lib/commands/report/create.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ async function createReport (packagePaths, { config, cwd, debugLog, dryRun }) {
224224
const result = await handleApiCall(apiCall, spinner, 'creating report')
225225

226226
if (result.success === false) {
227-
return handleUnsuccessfulApiResponse(result, spinner)
227+
return handleUnsuccessfulApiResponse('createReport', result, spinner)
228228
}
229229

230230
// Conclude the status of the API call

lib/commands/report/view.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ export async function fetchReportData (reportId, { includeAllIssues, strict }) {
134134
const result = await handleApiCall(socketSdk.getReport(reportId), spinner, 'fetching report')
135135

136136
if (result.success === false) {
137-
return handleUnsuccessfulApiResponse(result, spinner)
137+
return handleUnsuccessfulApiResponse('getReport', result, spinner)
138138
}
139139

140140
// Conclude the status of the API call

lib/utils/api-helpers.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,13 @@ import { ErrorWithCause } from 'pony-cause'
44
import { AuthError } from './errors.js'
55

66
/**
7-
* @template T
7+
* @template {import('@socketsecurity/sdk').SocketSdkOperations} T
8+
* @param {T} _name
89
* @param {import('@socketsecurity/sdk').SocketSdkErrorType<T>} result
910
* @param {import('ora').Ora} spinner
1011
* @returns {void}
1112
*/
12-
export function handleUnsuccessfulApiResponse (result, spinner) {
13+
export function handleUnsuccessfulApiResponse (_name, result, spinner) {
1314
const resultError = 'error' in result && result.error && typeof result.error === 'object' ? result.error : {}
1415
const message = 'message' in resultError && typeof resultError.message === 'string' ? resultError.message : 'No error message returned'
1516

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
"dependencies": {
7777
"@apideck/better-ajv-errors": "^0.3.6",
7878
"@socketsecurity/config": "^2.0.0",
79-
"@socketsecurity/sdk": "^0.5.2",
79+
"@socketsecurity/sdk": "^0.5.4",
8080
"chalk": "^5.1.2",
8181
"globby": "^13.1.3",
8282
"hpagent": "^1.2.0",

0 commit comments

Comments
 (0)