Skip to content

Commit 9fa941d

Browse files
committed
Add commits and minor cleanup
1 parent 400d5cb commit 9fa941d

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/utils/package-environment.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -286,13 +286,13 @@ export async function detectPackageEnvironment({
286286
}
287287
const browserslistQuery = pkgJson['browserslist'] as string[] | undefined
288288
if (Array.isArray(browserslistQuery)) {
289-
const browserslistTargets = browserslist(browserslistQuery)
290-
.map(s => s.toLowerCase())
291-
.sort(naturalCompare)
292-
const browserslistNodeTargets = browserslistTargets
293-
.filter(v => v.startsWith('node '))
289+
// List Node targets in ascending version order.
290+
const browserslistNodeTargets = browserslist(browserslistQuery)
291+
.filter(v => /^node /i.test(v))
294292
.map(v => v.slice(5 /*'node '.length*/))
293+
.sort(naturalCompare)
295294
if (browserslistNodeTargets.length) {
295+
// browserslistNodeTargets[0] is the lowest Node target version.
296296
const coerced = semver.coerce(browserslistNodeTargets[0])
297297
if (coerced && semver.lt(coerced, pkgMinNodeVersion)) {
298298
pkgMinNodeVersion = coerced.version
@@ -307,7 +307,7 @@ export async function detectPackageEnvironment({
307307
lockName = undefined
308308
lockPath = undefined
309309
}
310-
// Does system agent version meet our minimum supported agent version?
310+
// Does the system agent version meet our minimum supported agent version?
311311
const agentSupported =
312312
!!agentVersion &&
313313
semver.satisfies(agentVersion, `>=${minSupportedAgentVersion}`)

0 commit comments

Comments
 (0)