Skip to content

Commit d20589b

Browse files
committed
Standardize coverage script spinner handling with other Socket projects
Consolidate spinner management to be consistent across all Socket projects. Instead of stopping spinner at each output point, prevent it from starting when using --json or --simple flags. Changes: - Only start/stop spinner in default output mode - Remove redundant spinner.stop() calls in output branches - Maintains consistent pattern across socket-registry, socket-cli, socket-sdk-js
1 parent d99a1ac commit d20589b

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

scripts/get-coverage-percentage.mjs

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,24 @@ async function logCoveragePercentage(argv) {
2929
// Get code coverage metrics (statements, branches, functions, lines).
3030
let codeCoverage
3131
try {
32-
if (!existsSync(coverageJsonPath)) {
33-
spinner.start('Generating coverage data...')
34-
} else {
35-
spinner.start('Reading coverage data...')
32+
// Only show spinner in default output mode (not JSON or simple).
33+
if (!argv.json && !argv.simple) {
34+
if (!existsSync(coverageJsonPath)) {
35+
spinner.start('Generating coverage data...')
36+
} else {
37+
spinner.start('Reading coverage data...')
38+
}
3639
}
3740

3841
codeCoverage = await getCodeCoverage()
3942

40-
spinner.stop()
43+
if (!argv.json && !argv.simple) {
44+
spinner.stop()
45+
}
4146
} catch (error) {
42-
spinner.stop()
47+
if (!argv.json && !argv.simple) {
48+
spinner.stop()
49+
}
4350
logger.error('Failed to get code coverage:', error.message)
4451
throw error
4552
}
@@ -123,15 +130,11 @@ async function logCoveragePercentage(argv) {
123130

124131
jsonOutput.overall = overall
125132

126-
// Stop spinner before outputting JSON.
127-
spinner.stop()
128133
console.log(JSON.stringify(jsonOutput, null, 2))
129134
} else if (argv.simple) {
130135
// Simple format: just the statement coverage percentage.
131-
spinner.stop()
132136
console.log(codeCoverage.statements.percent)
133137
} else {
134-
spinner.stop()
135138
// Default format: human-readable formatted output.
136139
logger.info(`Coverage Summary:`)
137140
logger.info(

0 commit comments

Comments
 (0)