Skip to content

Commit 30574b8

Browse files
mtorpdacoburn
andauthored
remove process timeout from reachability analysis (#141)
* remove process timeout from reachability analysis * Fixing version for build --------- Co-authored-by: Douglas Coburn <[email protected]>
1 parent 7329f50 commit 30574b8

File tree

5 files changed

+8
-6
lines changed

5 files changed

+8
-6
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# Changelog
2+
3+
## 2.2.56
4+
5+
- Removed process timeout from reachability analysis subprocess. Timeouts are now only passed to the Coana CLI via the `--analysis-timeout` flag.

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -527,3 +527,4 @@ pre-commit install
527527
```
528528
529529
> **Note**: This manual setup is an alternative to the streamlined Make targets described above. For most development workflows, using `make first-time-setup` or `make first-time-local-setup` is recommended.
530+

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ build-backend = "hatchling.build"
66

77
[project]
88
name = "socketsecurity"
9-
version = "2.2.55"
9+
version = "2.2.56"
1010
requires-python = ">= 3.10"
1111
license = {"file" = "LICENSE"}
1212
dependencies = [

socketsecurity/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
__author__ = 'socket.dev'
2-
__version__ = '2.2.55'
2+
__version__ = '2.2.56'
33
USER_AGENT = f'SocketPythonCLI/{__version__}'

socketsecurity/core/tools/reachability.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,6 @@ def run_reachability_analysis(
220220
cwd=target_directory,
221221
stdout=sys.stderr, # Send stdout to stderr so user sees it
222222
stderr=sys.stderr, # Send stderr to stderr
223-
timeout=timeout + 60 if timeout else None # Add buffer to subprocess timeout
224223
)
225224

226225
if result.returncode != 0:
@@ -240,9 +239,6 @@ def run_reachability_analysis(
240239
"tar_hash_used": tar_hash
241240
}
242241

243-
except subprocess.TimeoutExpired:
244-
log.error(f"Reachability analysis timed out after {timeout} seconds")
245-
raise Exception(f"Reachability analysis timed out after {timeout} seconds")
246242
except Exception as e:
247243
log.error(f"Failed to run reachability analysis: {str(e)}")
248244
raise Exception(f"Failed to run reachability analysis: {str(e)}")

0 commit comments

Comments
 (0)