Skip to content

Commit 3ef84ac

Browse files
committed
about to optimize for memory
1 parent ebf977f commit 3ef84ac

File tree

5 files changed

+9
-12
lines changed

5 files changed

+9
-12
lines changed

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ test = [
4242
dev = [
4343
"ruff>=0.3.0",
4444
"pip-tools>=7.4.0", # for pip-compile
45+
"twine"
4546
]
4647

4748
[project.scripts]

socketsecurity/config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class CliConfig:
3131
integration_type: IntegrationType = "api"
3232
integration_org_slug: Optional[str] = None
3333
pending_head: bool = False
34-
timeout: Optional[int] = None
34+
timeout: Optional[int] = 1200
3535
@classmethod
3636
def from_args(cls, args_list: Optional[List[str]] = None) -> 'CliConfig':
3737
parser = create_argument_parser()

socketsecurity/core/__init__.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ def get_head_scan_for_repo(self, repo_slug: str) -> str:
350350
repo_info = self.get_repo_info(repo_slug)
351351
return repo_info.head_full_scan_id if repo_info.head_full_scan_id else None
352352

353-
def get_added_and_removed_packages(self, head_full_scan: Optional[FullScan], new_full_scan: FullScan) -> Tuple[Dict[str, Package], Dict[str, Package]]:
353+
def get_added_and_removed_packages(self, head_full_scan_id: Optional[str], new_full_scan: FullScan) -> Tuple[Dict[str, Package], Dict[str, Package]]:
354354
"""
355355
Get packages that were added and removed between scans.
356356
@@ -361,12 +361,12 @@ def get_added_and_removed_packages(self, head_full_scan: Optional[FullScan], new
361361
Returns:
362362
Tuple of (added_packages, removed_packages) dictionaries
363363
"""
364-
if head_full_scan is None:
364+
if head_full_scan_id is None:
365365
log.info(f"No head scan found. New scan ID: {new_full_scan.id}")
366366
return new_full_scan.packages, {}
367367

368-
log.info(f"Comparing scans - Head scan ID: {head_full_scan.id}, New scan ID: {new_full_scan.id}")
369-
diff_report = self.sdk.fullscans.stream_diff(self.config.org_slug, head_full_scan.id, new_full_scan.id).data
368+
log.info(f"Comparing scans - Head scan ID: {head_full_scan_id}, New scan ID: {new_full_scan.id}")
369+
diff_report = self.sdk.fullscans.stream_diff(self.config.org_slug, head_full_scan_id, new_full_scan.id).data
370370

371371
log.info(f"Diff report artifact counts:")
372372
log.info(f"Added: {len(diff_report.artifacts.added)}")
@@ -453,12 +453,8 @@ def create_new_diff(
453453
new_scan_end = time.time()
454454
log.info(f"Total time to create new full scan: {new_scan_end - new_scan_start:.2f}")
455455

456-
457-
head_full_scan = None
458-
if head_full_scan_id:
459-
head_full_scan = self.get_full_scan(head_full_scan_id)
460456

461-
added_packages, removed_packages = self.get_added_and_removed_packages(head_full_scan, new_full_scan)
457+
added_packages, removed_packages = self.get_added_and_removed_packages(head_full_scan_id, new_full_scan)
462458

463459
diff = self.create_diff_report(added_packages, removed_packages)
464460

socketsecurity/core/socket_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
class SocketConfig:
1010
api_key: str
1111
api_url: str = "https://api.socket.dev/v0"
12-
timeout: int = 30
12+
timeout: int = 1200
1313
allow_unverified_ssl: bool = False
1414
org_id: Optional[str] = None
1515
org_slug: Optional[str] = None

socketsecurity/socketcli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def main_code():
4848
print(f"config: {config.to_dict()}")
4949
output_handler = OutputHandler(blocking_disabled=config.disable_blocking)
5050

51-
sdk = socketdev(token=config.api_token)
51+
sdk = socketdev(token=config.api_token, timeout=config.timeout)
5252
print("sdk loaded")
5353

5454
if config.enable_debug:

0 commit comments

Comments
 (0)