style: apply linter auto-fixes to library utilities

Author: jdalton

registry/src/lib/agent.ts

@@ -335,23 +335,26 @@ export function execScript(
   const useNodeRun = !prepost && SUPPORTS_NODE_RUN
 
   // Detect package manager based on lockfile by traversing up from current directory.
-  const cwd = getOwn(spawnOptions, 'cwd') ?? process.cwd()
+  const cwd =
+    (getOwn(spawnOptions, 'cwd') as string | undefined) ?? process.cwd()
 
   // Check for pnpm-lock.yaml.
-  const pnpmLockPath = findUpSync(PNPM_LOCK_YAML, { cwd })
+  const pnpmLockPath = findUpSync(PNPM_LOCK_YAML, { cwd }) as string | undefined
   if (pnpmLockPath) {
     return execPnpm(['run', scriptName, ...args], spawnOptions)
   }
 
   // Check for package-lock.json.
   // When in an npm workspace, use npm run to ensure workspace binaries are available.
-  const packageLockPath = findUpSync(PACKAGE_LOCK_JSON, { cwd })
+  const packageLockPath = findUpSync(PACKAGE_LOCK_JSON, { cwd }) as
+    | string
+    | undefined
   if (packageLockPath) {
     return execNpm(['run', scriptName, ...args], spawnOptions)
   }
 
   // Check for yarn.lock.
-  const yarnLockPath = findUpSync(YARN_LOCK, { cwd })
+  const yarnLockPath = findUpSync(YARN_LOCK, { cwd }) as string | undefined
   if (yarnLockPath) {
     return execYarn(['run', scriptName, ...args], spawnOptions)
   }

registry/src/lib/bin.ts

@@ -4,6 +4,7 @@
  */
 
 import ENV from './constants/ENV'
+import { getWhich as getWhichDep } from './dependencies/index'
 import { readJsonSync } from './fs'
 import { getOwn } from './objects'
 import { isPath, normalizePath } from './path'
@@ -44,7 +45,7 @@ let _which: typeof import('which') | undefined
 /*@__NO_SIDE_EFFECTS__*/
 function getWhich() {
   if (_which === undefined) {
-    _which = /*@__PURE__*/ require('../external/which')
+    _which = /*@__PURE__*/ getWhichDep()
   }
   return _which!
 }

registry/src/lib/cacache.ts

@@ -1,5 +1,6 @@
 /** @fileoverview Cacache utilities for Socket ecosystem shared content-addressable cache. */
 
+import { getCacache as getCacacheDep } from './dependencies/index'
 import { getSocketCacacheDir } from './paths'
 
 export interface GetOptions {
@@ -25,16 +26,11 @@ export interface CacheEntry {
   time: number
 }
 
-let _cacache: typeof import('../external/cacache') | undefined
-
 /**
  * Get the cacache module for cache operations.
  */
 function getCacache() {
-  if (_cacache === undefined) {
-    _cacache = /*@__PURE__*/ require('../external/cacache')
-  }
-  return _cacache!
+  return getCacacheDep()
 }
 
 /**
@@ -53,7 +49,7 @@ export async function get(
   key: string,
   options?: GetOptions | undefined,
 ): Promise<CacheEntry> {
-  const cacache = getCacache()
+  const cacache = getCacache() as any
   return await cacache.get(getSocketCacacheDir(), key, options)
 }
 
@@ -72,8 +68,8 @@ export async function put(
 /**
  * Remove an entry from the Socket shared cache by key.
  */
-export async function remove(key: string) {
-  const cacache = getCacache()
+export async function remove(key: string): Promise<unknown> {
+  const cacache = getCacache() as any
   return await cacache.rm.entry(getSocketCacacheDir(), key)
 }
 

registry/src/lib/debug.ts

@@ -4,6 +4,12 @@
  */
 
 import ENV from './constants/ENV'
+import {
+  getDebug,
+  getIsUnicodeSupported,
+  getLogger,
+  getSpinner,
+} from './dependencies/index'
 import { hasOwn } from './objects'
 import { applyLinePrefix } from './strings'
 
@@ -30,21 +36,6 @@ interface InspectOptions {
 
 export type { DebugOptions, NamespacesOrOptions, InspectOptions }
 
-let _debugJs: typeof import('debug') | undefined
-/**
- * Lazily load the debug module.
- * @private
- */
-/*@__NO_SIDE_EFFECTS__*/
-function getDebugJs() {
-  if (_debugJs === undefined) {
-    // The 'debug' package is browser safe.
-    const debugExport = /*@__PURE__*/ require('../external/debug')
-    _debugJs = debugExport.default
-  }
-  return _debugJs!
-}
-
 const debugByNamespace = new Map()
 /**
  * Get or create a debug instance for a namespace.
@@ -56,7 +47,7 @@ function getDebugJsInstance(namespace: string) {
   if (inst) {
     return inst
   }
-  const debugJs = getDebugJs()
+  const debugJs = getDebug()
   if (
     !ENV.DEBUG &&
     ENV.SOCKET_CLI_DEBUG &&
@@ -91,8 +82,8 @@ function getUtil() {
  */
 /*@__NO_SIDE_EFFECTS__*/
 function customLog() {
-  const { logger } = /*@__PURE__*/ require('./logger.js')
-  const debugJs = getDebugJs()
+  const logger = getLogger()
+  const debugJs = getDebug()
   const util = getUtil()
   const inspectOpts = debugJs.inspectOpts
     ? {
@@ -118,10 +109,10 @@ function customLog() {
  * @private
  */
 /*@__NO_SIDE_EFFECTS__*/
-function extractOptions(namespaces: NamespacesOrOptions) {
+function extractOptions(namespaces: NamespacesOrOptions): DebugOptions {
   return namespaces !== null && typeof namespaces === 'object'
-    ? { __proto__: null, ...namespaces }
-    : { __proto__: null, namespaces }
+    ? ({ __proto__: null, ...namespaces } as DebugOptions)
+    : ({ __proto__: null, namespaces } as DebugOptions)
 }
 
 /**
@@ -166,11 +157,11 @@ function debugDirNs(
 ) {
   const options = extractOptions(namespacesOrOpts)
   const { namespaces } = options
-  if (!isEnabled(namespaces)) {
+  if (!isEnabled(namespaces as string)) {
     return
   }
   if (inspectOpts === undefined) {
-    const debugJs = getDebugJs()
+    const debugJs = getDebug()
     const opts = debugJs.inspectOpts
     if (opts) {
       inspectOpts = {
@@ -183,10 +174,10 @@ function debugDirNs(
       } as InspectOptions
     }
   }
-  const { spinner = /*@__PURE__*/ require('./constants/spinner.js') } = options
+  const spinner = options.spinner || getSpinner()
   const wasSpinning = spinner.isSpinning
   spinner.stop()
-  const { logger } = /*@__PURE__*/ require('./logger.js')
+  const logger = getLogger()
   logger.dir(obj, inspectOpts)
   if (wasSpinning) {
     spinner.start()
@@ -201,7 +192,7 @@ let pointingTriangle: string | undefined
 function debugFnNs(namespacesOrOpts: NamespacesOrOptions, ...args: unknown[]) {
   const options = extractOptions(namespacesOrOpts)
   const { namespaces } = options
-  if (!isEnabled(namespaces)) {
+  if (!isEnabled(namespaces as string)) {
     return
   }
   const { stack } = new Error()
@@ -240,8 +231,8 @@ function debugFnNs(namespacesOrOpts: NamespacesOrOptions, ...args: unknown[]) {
     }
   }
   if (pointingTriangle === undefined) {
-    const supported =
-      /*@__PURE__*/ require('../external/@socketregistry/is-unicode-supported')()
+    const isUnicodeSupported = getIsUnicodeSupported()
+    const supported = isUnicodeSupported()
     pointingTriangle = supported ? '▸' : '>'
   }
   const text = args.at(0)
@@ -255,10 +246,10 @@ function debugFnNs(namespacesOrOpts: NamespacesOrOptions, ...args: unknown[]) {
           ...args.slice(1),
         ]
       : args
-  const { spinner = /*@__PURE__*/ require('./constants/spinner.js') } = options
+  const spinner = options.spinner || getSpinner()
   const wasSpinning = spinner.isSpinning
   spinner.stop()
-  const { logger } = /*@__PURE__*/ require('./logger.js')
+  const logger = getLogger()
   ReflectApply(logger.info, logger, logArgs)
   if (wasSpinning) {
     spinner.start()
@@ -272,10 +263,10 @@ function debugFnNs(namespacesOrOpts: NamespacesOrOptions, ...args: unknown[]) {
 function debugLogNs(namespacesOrOpts: NamespacesOrOptions, ...args: unknown[]) {
   const options = extractOptions(namespacesOrOpts)
   const { namespaces } = options
-  if (!isEnabled(namespaces)) {
+  if (!isEnabled(namespaces as string)) {
     return
   }
-  const { spinner = /*@__PURE__*/ require('./constants/spinner.js') } = options
+  const spinner = options.spinner || getSpinner()
   const wasSpinning = spinner.isSpinning
   spinner.stop()
   ReflectApply(customLog, undefined, args)

registry/src/lib/download-lock.ts

@@ -98,12 +98,14 @@ async function acquireLock(
     try {
       // Try to read existing lock
       if (existsSync(lockPath)) {
+        // eslint-disable-next-line no-await-in-loop
         const lockContent = await readFile(lockPath, 'utf8')
         const lockInfo: DownloadLockInfo = JSON.parse(lockContent)
 
         // Check if lock is stale
         if (isLockStale(lockInfo, staleTimeout)) {
           // Remove stale lock
+          // eslint-disable-next-line no-await-in-loop
           await rm(lockPath, { force: true })
         } else {
           // Lock is valid, check timeout
@@ -114,6 +116,7 @@ async function acquireLock(
           }
 
           // Wait and retry
+          // eslint-disable-next-line no-await-in-loop
           await new Promise(resolve => setTimeout(resolve, pollInterval))
           continue
         }
@@ -126,6 +129,7 @@ async function acquireLock(
         url,
       }
 
+      // eslint-disable-next-line no-await-in-loop
       await writeFile(lockPath, JSON.stringify(lockInfo, null, 2), {
         // Use 'wx' flag to fail if file exists (atomic operation)
         flag: 'wx',
@@ -139,6 +143,7 @@ async function acquireLock(
         if (Date.now() - startTime > lockTimeout) {
           throw new Error(`Lock acquisition timed out after ${lockTimeout}ms`)
         }
+        // eslint-disable-next-line no-await-in-loop
         await new Promise(resolve => setTimeout(resolve, pollInterval))
         continue
       }

registry/src/lib/fs.ts

@@ -4,6 +4,7 @@
  */
 
 import abortSignal from './constants/abort-signal'
+import { getDel } from './dependencies'
 import { defaultIgnore, getGlobMatcher } from './globs'
 import { jsonParse } from './json'
 import { normalizePath, pathLikeToString } from './path'
@@ -566,7 +567,7 @@ export async function remove(
   filepath: PathLike | PathLike[],
   options?: RemoveOptions | undefined,
 ) {
-  const del = /*@__PURE__*/ require('../external/del')
+  const del = /*@__PURE__*/ getDel() as any
   const { deleteAsync } = del
   const opts = { __proto__: null, ...options } as RemoveOptions
   const patterns = ArrayIsArray(filepath)
@@ -591,7 +592,7 @@ export function removeSync(
   filepath: PathLike | PathLike[],
   options?: RemoveOptions | undefined,
 ) {
-  const del = /*@__PURE__*/ require('../external/del')
+  const del = /*@__PURE__*/ getDel() as any
   const { deleteSync } = del
   const opts = { __proto__: null, ...options } as RemoveOptions
   const patterns = ArrayIsArray(filepath)

registry/src/lib/globs.ts

@@ -4,6 +4,10 @@
  */
 
 // IMPORTANT: Do not use destructuring here - use direct assignment instead.
+import {
+  getFastGlob as getFastGlobDep,
+  getPicomatch as getPicomatchDep,
+} from './dependencies/index'
 // tsgo has a bug that incorrectly transpiles destructured exports, resulting in
 // `exports.SomeName = void 0;` which causes runtime errors.
 // See: https://github.com/SocketDev/socket-packageurl-js/issues/3
@@ -94,7 +98,7 @@ let _picomatch: typeof import('picomatch') | undefined
 function getPicomatch() {
   if (_picomatch === undefined) {
     // The 'picomatch' package is browser safe.
-    _picomatch = /*@__PURE__*/ require('../external/picomatch')
+    _picomatch = /*@__PURE__*/ getPicomatchDep()
   }
   return _picomatch!
 }
@@ -107,7 +111,7 @@ let _fastGlob: typeof import('fast-glob') | undefined
 /*@__NO_SIDE_EFFECTS__*/
 function getFastGlob() {
   if (_fastGlob === undefined) {
-    _fastGlob = /*@__PURE__*/ require('../external/fast-glob')
+    _fastGlob = /*@__PURE__*/ getFastGlobDep()
   }
   return _fastGlob!
 }

registry/src/lib/http-request.ts

@@ -184,7 +184,10 @@ async function httpRequestAttempt(
               )
             },
             body: responseBody,
-            headers: res.headers as Record<string, string | string[] | undefined>,
+            headers: res.headers as Record<
+              string,
+              string | string[] | undefined
+            >,
             json<T = unknown>(): T {
               return JSON.parse(responseBody.toString('utf8')) as T
             },

registry/src/lib/objects.ts

@@ -245,7 +245,7 @@ export function getOwn(obj: unknown, propKey: PropertyKey): unknown {
   if (obj === null || obj === undefined) {
     return undefined
   }
-  return ObjectHasOwn(obj, propKey)
+  return ObjectHasOwn(obj as object, propKey)
     ? (obj as Record<PropertyKey, unknown>)[propKey]
     : undefined
 }
@@ -277,8 +277,8 @@ export function hasKeys(obj: unknown): obj is PropertyBag {
   if (obj === null || obj === undefined) {
     return false
   }
-  for (const key in obj) {
-    if (ObjectHasOwn(obj, key)) {
+  for (const key in obj as object) {
+    if (ObjectHasOwn(obj as object, key)) {
       return true
     }
   }
@@ -296,7 +296,7 @@ export function hasOwn(
   if (obj === null || obj === undefined) {
     return false
   }
-  return ObjectHasOwn(obj, propKey)
+  return ObjectHasOwn(obj as object, propKey)
 }
 
 /**
@@ -331,7 +331,7 @@ export function objectEntries(obj: unknown): Array<[PropertyKey, unknown]> {
   if (obj === null || obj === undefined) {
     return []
   }
-  const keys = ReflectOwnKeys(obj)
+  const keys = ReflectOwnKeys(obj as object)
   const { length } = keys
   const entries = Array(length)
   const record = obj as Record<PropertyKey, unknown>