Skip to content

Commit 2eafb6a

Browse files
committed
chore: fix crashing job-worker on startup
the job worker crashes on startup when moving from release51
1 parent c1a9a02 commit 2eafb6a

File tree

1 file changed

+20
-6
lines changed

1 file changed

+20
-6
lines changed

packages/job-worker/src/jobs/studio.ts

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,25 @@ export function convertStudioToJobStudio(studio: DBStudio): JobStudio {
4848
'routeSetExclusivityGroupsWithOverrides',
4949
'packageContainersWithOverrides'
5050
),
51-
mappings: applyAndValidateOverrides(studio.mappingsWithOverrides).obj,
52-
blueprintConfig: applyAndValidateOverrides(studio.blueprintConfigWithOverrides).obj,
53-
settings: applyAndValidateOverrides(studio.settingsWithOverrides).obj,
54-
routeSets: applyAndValidateOverrides(studio.routeSetsWithOverrides).obj,
55-
routeSetExclusivityGroups: applyAndValidateOverrides(studio.routeSetExclusivityGroupsWithOverrides).obj,
56-
// packageContainers: applyAndValidateOverrides(studio.packageContainersWithOverrides).obj,
51+
// Note: checking for the overrides properties to exist first,
52+
// because if they might not exist when migrating from an older version
53+
// and this would crash the job-worker, creating a catch-22 situation.
54+
55+
mappings: studio.mappingsWithOverrides
56+
? applyAndValidateOverrides(studio.mappingsWithOverrides).obj
57+
: (studio as any).mappings || {},
58+
blueprintConfig: studio.blueprintConfigWithOverrides
59+
? applyAndValidateOverrides(studio.blueprintConfigWithOverrides).obj
60+
: (studio as any).blueprintConfig || {},
61+
settings: studio.settingsWithOverrides
62+
? applyAndValidateOverrides(studio.settingsWithOverrides).obj
63+
: (studio as any).settings || {},
64+
routeSets: studio.routeSetsWithOverrides
65+
? applyAndValidateOverrides(studio.routeSetsWithOverrides).obj
66+
: (studio as any).routeSets || {},
67+
routeSetExclusivityGroups: studio.routeSetExclusivityGroupsWithOverrides
68+
? applyAndValidateOverrides(studio.routeSetExclusivityGroupsWithOverrides).obj
69+
: (studio as any).routeSetExclusivityGroups || {},
70+
// packageContainers: studio.packageContainersWithOverrides ? applyAndValidateOverrides(studio.packageContainersWithOverrides).obj : (studio as any).packageContainers || {},
5771
}
5872
}

0 commit comments

Comments
 (0)