chore: improve code comments around the added logging

Author: jstarpl

packages/job-worker/src/ingest/commit.ts

@@ -178,9 +178,13 @@ export async function CommitIngestOperation(
 			// Ensure any adlibbed parts are updated to follow the segmentId of the previous part
 			await updateSegmentIdsForAdlibbedPartInstances(context, ingestModel, beforePartMap)
 
+			// TODO: This whole section can probably be removed later, it's really unneccessary in the grand scheme of
+			// things, it's here only to debug some problems
 			if (data.renamedSegments && data.renamedSegments.size > 0) {
 				logger.verbose(`Renamed segments: ${JSON.stringify(Array.from(data.renamedSegments.entries()))}`)
 			}
+			// End of temporary section
+
 			// ensure instances have matching segmentIds with the parts
 			await updatePartInstancesSegmentIds(context, ingestModel, data.renamedSegments, beforePartMap)
 

packages/job-worker/src/ingest/lock.ts

@@ -22,8 +22,11 @@ export interface CommitIngestData {
 	removedSegmentIds: SegmentId[]
 	/**
 	 * Segments that had their ids changed. This helps then be orphaned in the correct place
-	 * eg, whole segment is renamed and middle part deleted
-	 * Note: Only supported for MOS, not 'normal' ingest operations
+	 * eg, whole segment is renamed and middle part deleted.
+	 *
+	 * Maps fromSegmentId to toSegmentId.
+	 *
+	 * _Note: Only supported for MOS, not 'normal' ingest operations_
 	 */
 	renamedSegments: Map<SegmentId, SegmentId> | null
 

packages/job-worker/src/playout/adlibJobs.ts

@@ -438,6 +438,7 @@ export async function handleDisableNextPiece(context: JobContext, data: DisableN
 
 				return sortedPieces.find((piece) => {
 					return (
+						piece.pieceInstance.piece.enable.start !== 'now' &&
 						piece.pieceInstance.piece.enable.start >= nowInPart &&
 						((!data.undo && !piece.pieceInstance.disabled) || (data.undo && piece.pieceInstance.disabled))
 					)

packages/job-worker/src/playout/infinites.ts

@@ -332,6 +332,9 @@ export function getPieceInstancesForPart(
 
 		playingSegment = playingRundown.getSegment(playingPartInstance.partInstance.segmentId)
 		if (!playingSegment) {
+			// Double check that there are no parts using the old segment ids:
+			// TODO: This whole section can probably be removed later, it's really unneccessary in the grand scheme of
+			// things, it's here only to debug some problems
 			const rundownId = playingRundown.rundown._id
 			context.directCollections.Segments.findFetch({
 				rundownId: rundownId,
@@ -344,6 +347,7 @@ export function getPieceInstancesForPart(
 					)
 				})
 				.catch((e) => logger.error(e))
+			// End of temporary section
 
 			throw new Error(
 				`Segment "${playingPartInstance.partInstance.segmentId}" in Rundown "${