fix: only run onPart/PiecePlaybackStarted/Stopped on current, next or previous parts

Since these are the only ones loaded into the PlayoutModel, we should not try to update any others

Author: nytamin

packages/job-worker/src/playout/timings/partPlayback.ts

@@ -26,6 +26,18 @@ export async function onPartPlaybackStarted(
 		startedPlayback: Time
 	}
 ): Promise<void> {
+	if (
+		// We only expect to be able to update the current, next, or previous part:
+		data.partInstanceId !== playoutModel.playlist.currentPartInfo?.partInstanceId ||
+		data.partInstanceId !== playoutModel.playlist.nextPartInfo?.partInstanceId ||
+		data.partInstanceId !== playoutModel.playlist.previousPartInfo?.partInstanceId
+	) {
+		logger.debug(
+			`onPartPlaybackStarted PartInstance "${data.partInstanceId}" is neither current, next nor previous (current: ${playoutModel.playlist.currentPartInfo?.partInstanceId}, next: ${playoutModel.playlist.nextPartInfo?.partInstanceId}, previous: ${playoutModel.playlist.previousPartInfo?.partInstanceId}, timestamp: ${data.startedPlayback}`
+		)
+		return
+	}
+
 	const playingPartInstance = playoutModel.getPartInstance(data.partInstanceId)
 	if (!playingPartInstance)
 		throw new Error(
@@ -136,6 +148,18 @@ export function onPartPlaybackStopped(
 		stoppedPlayback: Time
 	}
 ): void {
+	if (
+		// We only expect to be able to update the current, next, or previous part:
+		data.partInstanceId !== playoutModel.playlist.currentPartInfo?.partInstanceId ||
+		data.partInstanceId !== playoutModel.playlist.nextPartInfo?.partInstanceId ||
+		data.partInstanceId !== playoutModel.playlist.previousPartInfo?.partInstanceId
+	) {
+		logger.debug(
+			`onPartPlaybackStopped PartInstance "${data.partInstanceId}" is neither current, next nor previous (current: ${playoutModel.playlist.currentPartInfo?.partInstanceId}, next: ${playoutModel.playlist.nextPartInfo?.partInstanceId}, previous: ${playoutModel.playlist.previousPartInfo?.partInstanceId}, timestamp: ${data.stoppedPlayback}`
+		)
+		return
+	}
+
 	const playlist = playoutModel.playlist
 
 	const partInstance = playoutModel.getPartInstance(data.partInstanceId)

packages/job-worker/src/playout/timings/piecePlayback.ts

@@ -23,6 +23,18 @@ export function onPiecePlaybackStarted(
 ): void {
 	const playlist = playoutModel.playlist
 
+	if (
+		// We only expect to be able to update the current, next, or previous part:
+		data.partInstanceId !== playoutModel.playlist.currentPartInfo?.partInstanceId ||
+		data.partInstanceId !== playoutModel.playlist.nextPartInfo?.partInstanceId ||
+		data.partInstanceId !== playoutModel.playlist.previousPartInfo?.partInstanceId
+	) {
+		logger.debug(
+			`onPiecePlaybackStarted PartInstance "${data.partInstanceId}" is neither current, next nor previous (current: ${playoutModel.playlist.currentPartInfo?.partInstanceId}, next: ${playoutModel.playlist.nextPartInfo?.partInstanceId}, previous: ${playoutModel.playlist.previousPartInfo?.partInstanceId}), timestamp: ${data.startedPlayback}`
+		)
+		return
+	}
+
 	const partInstance = playoutModel.getPartInstance(data.partInstanceId)
 	if (!partInstance) {
 		if (!playlist.activationId) {
@@ -38,7 +50,10 @@ export function onPiecePlaybackStarted(
 		if (!playlist.activationId) {
 			logger.warn(`onPiecePlaybackStarted: Received for inactive RundownPlaylist "${playlist._id}"`)
 		} else {
-			throw new Error(`PieceInstance "${data.partInstanceId}" in RundownPlaylist "${playlist._id}" not found!`)
+			const otherPieceInstanceIds = partInstance.pieceInstances.map((p) => p.pieceInstance._id)
+			throw new Error(
+				`PieceInstance "${data.pieceInstanceId}" in PartInstance "${partInstance.partInstance._id}" in RundownPlaylist "${playlist._id}" not found! (other pieceInstanceIds in PartInstance: ${otherPieceInstanceIds})`
+			)
 		}
 		return
 	}
@@ -75,6 +90,18 @@ export function onPiecePlaybackStopped(
 ): void {
 	const playlist = playoutModel.playlist
 
+	if (
+		// We only expect to be able to update the current, next, or previous part:
+		data.partInstanceId !== playoutModel.playlist.currentPartInfo?.partInstanceId ||
+		data.partInstanceId !== playoutModel.playlist.nextPartInfo?.partInstanceId ||
+		data.partInstanceId !== playoutModel.playlist.previousPartInfo?.partInstanceId
+	) {
+		logger.debug(
+			`onPiecePlaybackStarted PartInstance "${data.partInstanceId}" is neither current, next nor previous (current: ${playoutModel.playlist.currentPartInfo?.partInstanceId}, next: ${playoutModel.playlist.nextPartInfo?.partInstanceId}, previous: ${playoutModel.playlist.previousPartInfo?.partInstanceId}), timestamp: ${data.stoppedPlayback}`
+		)
+		return
+	}
+
 	const partInstance = playoutModel.getPartInstance(data.partInstanceId)
 	if (!partInstance) {
 		// PartInstance not found, so we can rely on the onPartPlaybackStopped callback erroring
@@ -86,7 +113,10 @@ export function onPiecePlaybackStopped(
 		if (!playlist.activationId) {
 			logger.warn(`onPiecePlaybackStopped: Received for inactive RundownPlaylist "${playlist._id}"`)
 		} else {
-			throw new Error(`PieceInstance "${data.partInstanceId}" in RundownPlaylist "${playlist._id}" not found!`)
+			const otherPieceInstanceIds = partInstance.pieceInstances.map((p) => p.pieceInstance._id)
+			throw new Error(
+				`PieceInstance "${data.pieceInstanceId}" in PartInstance "${partInstance.partInstance._id}" in RundownPlaylist "${playlist._id}" not found!  (other pieceInstanceIds in PartInstance: ${otherPieceInstanceIds})`
+			)
 		}
 		return
 	}