fix: track all reasons why a worker does not support an expectation.

Author: nytamin

shared/packages/expectationManager/src/evaluationRunner/evaluateExpectationStates/new.ts

@@ -63,13 +63,21 @@ export async function evaluateExpectationStateNew({ manager, tracker, trackedExp
 				})
 			}
 		} else {
+			let anyNoAvailableWorkersReasonUser = 'Unknown reason'
+			const allNoAvailableWorkersReasonsTech: string[] = []
+
+			for (const reason of trackedExp.noAvailableWorkersReasons.values()) {
+				if (!anyNoAvailableWorkersReasonUser) anyNoAvailableWorkersReasonUser = reason.user // Just pick the first one
+				allNoAvailableWorkersReasonsTech.push(reason.tech)
+			}
+
 			tracker.trackedExpectationAPI.updateTrackedExpectationStatus(trackedExp, {
 				state: ExpectedPackageStatusAPI.WorkStatusState.NEW,
 				reason: {
-					user: `Found no workers who supports this Expectation, due to: ${trackedExp.noAvailableWorkersReason.user}`,
-					tech: `Found no workers who supports this Expectation: "${
-						trackedExp.noAvailableWorkersReason.tech
-					}", have asked workers: [${Array.from(trackedExp.queriedWorkers.keys()).join(',')}]`,
+					user: `Found no workers who supports this Expectation, due to: ${anyNoAvailableWorkersReasonUser}`,
+					tech: `Found no workers who supports this Expectation. Reasons why: ${allNoAvailableWorkersReasonsTech.join(
+						', '
+					)}, have asked workers: [${Array.from(trackedExp.queriedWorkers.keys()).join(',')}]`,
 				},
 				// Don't update the package status, since we don't know anything about the package yet:
 				dontUpdatePackage: true,

shared/packages/expectationManager/src/evaluationRunner/evaluateExpectationStates/restarted.ts

@@ -30,6 +30,7 @@ export async function evaluateExpectationStateRestarted({
 			})
 		} else {
 			// Something went wrong when trying to remove
+			// Todo: Should we go to NEW here, if it happens multiple times?
 			tracker.trackedExpectationAPI.updateTrackedExpectationStatus(trackedExp, {
 				state: ExpectedPackageStatusAPI.WorkStatusState.RESTARTED,
 				reason: removed.reason,

shared/packages/expectationManager/src/internalManager/lib/trackedWorkerAgents.ts

@@ -60,18 +60,22 @@ export class TrackedWorkerAgents {
 
 						if (support.support) {
 							trackedExp.availableWorkers.add(workerId)
+							trackedExp.noAvailableWorkersReasons.delete(workerId)
 						} else {
 							trackedExp.availableWorkers.delete(workerId)
-							trackedExp.noAvailableWorkersReason = support.reason
+							trackedExp.noAvailableWorkersReasons.set(workerId, {
+								user: support.reason.user,
+								tech: `${workerId}: ${support.reason.tech}`,
+							})
 						}
 					} catch (err) {
 						trackedExp.availableWorkers.delete(workerId)
 
 						if ((err + '').match(/timeout/i)) {
-							trackedExp.noAvailableWorkersReason = {
+							trackedExp.noAvailableWorkersReasons.set(workerId, {
 								user: 'Worker timed out',
-								tech: `Worker "${workerId} timeout"`,
-							}
+								tech: `Worker "${workerId} timeout in doYouSupportExpectation()"`,
+							})
 						} else throw err
 					}
 				}
@@ -94,7 +98,7 @@ export class TrackedWorkerAgents {
 	}> {
 		/** How many requests to send out simultaneously */
 		const BATCH_SIZE = 10
-		/** How many answers we want to have before continuing with picking one */
+		/** If we've gotten this amount of positive answers, we won't be asking more workers */
 		const minWorkerCount = 5
 
 		let countQueried = 0

shared/packages/expectationManager/src/lib/trackedExpectation.ts

@@ -23,8 +23,8 @@ export interface TrackedExpectation {
 	queriedWorkers: Map<WorkerAgentId, number>
 	/** List of worker ids that supports this Expectation */
 	availableWorkers: Set<WorkerAgentId>
-	/** Contains the latest reason why a worker refused to support an Expectation */
-	noAvailableWorkersReason: Reason
+	/** Contains the reasons why a worker refused to support an Expectation */
+	noAvailableWorkersReasons: Map<WorkerAgentId, Reason>
 	/** Timestamp of the last time the expectation was evaluated. */
 	lastEvaluationTime: number
 	/**
@@ -113,10 +113,7 @@ export function getDefaultTrackedExpectation(
 		state: existingtrackedExp?.state || ExpectedPackageStatusAPI.WorkStatusState.NEW,
 		queriedWorkers: new Map(),
 		availableWorkers: new Set(),
-		noAvailableWorkersReason: {
-			user: 'Unknown reason',
-			tech: 'N/A (init)',
-		},
+		noAvailableWorkersReasons: new Map(),
 		lastEvaluationTime: 0,
 		skipEvaluationCount: 0,
 		waitingForWorkerTime: null,

shared/packages/expectationManager/src/lib/types.ts

@@ -13,6 +13,7 @@ export interface ExpectationStateHandlerSession {
 
 	/** The Worker assigned to the Expectation during this evaluation-session */
 	assignedWorker?: WorkerAgentAssignment
+	/** If no Worker was assigned, a Reason why */
 	noAssignedWorkerReason?: Reason
 }
 export interface WorkerAgentAssignment {