fix(nix): windows build of mt-kahypar

Author: uulm-janbaudisch

flake.lock

@@ -16,6 +16,9 @@
         "x86_64-linux"
       ];
 
+      # The Windows build of Boost seems to be broken, so we use an older version instead.
+      boost = pkgs: if pkgs.stdenv.hostPlatform.isWindows then pkgs.boost183 else pkgs.boost;
+
       # If building for Windows, appends -windows, otherwise nothing.
       windowsSuffix = pkgs: name: if pkgs.stdenv.hostPlatform.isWindows then "${name}-windows" else name;
 
@@ -107,11 +110,13 @@
           arjun = pkgs-static.callPackage ./nix/arjun.nix {
             cryptominisat = self.packages.${system}.cryptominisat;
             sbva = self.packages.${system}.sbva;
+            boost = boost pkgs-static;
           };
 
           arjun-windows = pkgs-windows.callPackage ./nix/arjun.nix {
             cryptominisat = self.packages.${system}.cryptominisat-windows;
             sbva = self.packages.${system}.sbva-windows;
+            boost = boost pkgs-windows;
           };
 
           gpmc = pkgs-static.callPackage ./nix/gpmc.nix {
@@ -124,8 +129,8 @@
             cryptominisat = self.packages.${system}.cryptominisat-windows;
           };
 
-          mt-kahypar = pkgs.callPackage ./nix/mt-kahypar.nix { };
-          mt-kahypar-windows = pkgs-windows.callPackage ./nix/mt-kahypar.nix { };
+          mt-kahypar = pkgs.callPackage ./nix/mt-kahypar.nix { boost = boost pkgs; };
+          mt-kahypar-windows = pkgs-windows.callPackage ./nix/mt-kahypar.nix { boost = boost pkgs-windows; };
 
           d4 = pkgs.callPackage ./nix/d4.nix {
             mt-kahypar = self.packages.${system}.mt-kahypar;
@@ -136,6 +141,7 @@
             glucose = self.packages.${system}.glucose;
             cadical = self.packages.${system}.cadical;
             cadiback = self.packages.${system}.cadiback;
+            boost = boost pkgs;
           };
 
           d4-windows = pkgs-windows.callPackage ./nix/d4.nix {
@@ -147,6 +153,7 @@
             glucose = self.packages.${system}.glucose-windows;
             cadical = self.packages.${system}.cadical-windows;
             cadiback = self.packages.${system}.cadiback-windows;
+            boost = boost pkgs-windows;
           };
 
           container = pkgs.dockerTools.buildLayeredImage {

flake.nix

@@ -1,8 +1,8 @@
 diff --git a/CMakeLists.txt b/CMakeLists.txt
-index 62b55d3a..22d067f9 100644
+index 854e52a6..64064719 100644
 --- a/CMakeLists.txt
 +++ b/CMakeLists.txt
-@@ -262,30 +262,32 @@ set(KAHYPAR_PYBIND11_VERSION     v2.13.6)
+@@ -263,30 +263,27 @@ set(KAHYPAR_PYBIND11_VERSION     v2.13.6)
  message(STATUS "Fetching dependencies...")
 
  # Include header-only dependencies
@@ -15,38 +15,34 @@ index 62b55d3a..22d067f9 100644
 +  OVERRIDE_FIND_PACKAGE
  )
 -FetchContent_Populate(
-+
 +FetchContent_Declare(
    WHFC QUIET EXLUDE_FROM_ALL
    GIT_REPOSITORY https://github.com/larsgottesbueren/WHFC.git
    GIT_TAG        ${KAHYPAR_WHFC_TAG}
    SOURCE_DIR     external_tools/WHFC
-+  OVERRIDE_FIND_PACKAGE
- )
+-)
 -FetchContent_Populate(
 -  growt QUIET EXLUDE_FROM_ALL
 -  GIT_REPOSITORY https://github.com/TooBiased/growt.git
 -  GIT_TAG        ${KAHYPAR_GROWT_TAG}
 -  SOURCE_DIR     external_tools/growt
--)
-+
-+find_package(kahypar-shared-resources)
-+find_package(WHFC)
-+
-+include(CMakePrintHelpers)
++  OVERRIDE_FIND_PACKAGE
+ )
 
- target_include_directories(MtKaHyPar-Include INTERFACE
+-target_include_directories(MtKaHyPar-Include INTERFACE
 -                           ${CMAKE_CURRENT_BINARY_DIR}/external_tools/kahypar-shared-resources
 -                           ${CMAKE_CURRENT_BINARY_DIR}/external_tools/growt
 -                           ${CMAKE_CURRENT_BINARY_DIR}/external_tools/WHFC)
++find_package(kahypar-shared-resources)
++find_package(WHFC)
+ 
++target_include_directories(MtKaHyPar-Include INTERFACE
 +                           ${kahypar-shared-resources_SOURCE_DIR}
 +                           ${WHFC_SOURCE_DIR})
 
-+cmake_print_properties(TARGETS ${PROJECT_NAME} PROPERTIES LOCATION INCLUDE_DIRECTORIES)
- 
  if (KAHYPAR_ENABLE_TESTING)
    FetchContent_Declare(
-@@ -437,11 +439,6 @@ if (KAHYPAR_X86 AND KAHYPAR_ENABLE_EXTENDED_INSTRUCTIONS)
+@@ -438,11 +435,6 @@ if (KAHYPAR_X86 AND KAHYPAR_ENABLE_EXTENDED_INSTRUCTIONS)
    if(BUILTIN_POPCNT)
      target_compile_options(MtKaHyPar-BuildFlags INTERFACE -msse4.2)
    endif()
@@ -58,3 +54,16 @@ index 62b55d3a..22d067f9 100644
  endif()
 
  if(KAHYPAR_ENABLE_ARCH_COMPILE_OPTIMIZATIONS)
+@@ -506,10 +498,8 @@ if(${CMAKE_SOURCE_DIR} STREQUAL ${CMAKE_CURRENT_SOURCE_DIR})
+       DEPENDS MtKaHyPar-CLI)
+   endif()
+ 
+-  if(NOT WIN32 AND BUILD_SHARED_LIBS)
+-    # library installation target
+-    include(SetupInstallation)
+-  endif()
++  # library installation target
++  include(SetupInstallation)
+ 
+   if(KAHYPAR_BUILD_DEBIAN_PACKAGE)
+     # packaging via CPack

nix/mt-kahypar-cmake.patch

@@ -59,7 +59,7 @@ stdenv.mkDerivation rec {
   cmakeFlags = [
     "-D FETCHCONTENT_SOURCE_DIR_KAHYPAR-SHARED-RESOURCES=${shared-resources}"
     "-D FETCHCONTENT_SOURCE_DIR_WHFC=${WHFC}"
-  ];
+  ] ++ lib.optionals stdenv.hostPlatform.isWindows [ "-D BUILD_SHARED_LIBS=ON" ];
 
   buildPhase = "cmake --build . --target mtkahypar --parallel $NIX_BUILD_CORES";
   installPhase = "cmake --install .";