Lint fixes for type safety.

Author: dishantlangayan

src/types/broker.ts

@@ -1,22 +1,22 @@
 export interface EventBrokerCreateDetail {
-  completedTime: string
-  createdBy: string
-  createdTime: string
+  completedTime?: string
+  createdBy?: string
+  createdTime?: string
   error?: {
     errorId: string
     message: string
   }
   id: string
-  operationType: string
-  progressLogs: {
+  operationType?: string
+  progressLogs?: {
     message: string
     step: string
     timestamp: string
   }[]
-  resourceId: string
-  resourceType: string
-  status: string
-  type: string
+  resourceId?: string
+  resourceType?: string
+  status?: string
+  type?: string
 }
 
 export interface EventBrokerCreateApiResponse {
@@ -47,18 +47,18 @@ export interface EventBrokerListApiResponse {
 }
 
 export interface EventBrokerServiceDetail {
-  adminState: string
-  createdTime: string
-  creationState: string
-  datacenterId: string
-  environmentId: string
-  eventBrokerServiceVersion: string
+  adminState?: string
+  createdTime?: string
+  creationState?: string
+  datacenterId?: string
+  environmentId?: string
+  eventBrokerServiceVersion?: string
   id: string
-  infrastructureId: string
-  locked: boolean
-  msgVpnName: string
+  infrastructureId?: string
+  locked?: boolean
+  msgVpnName?: string
   name: string
-  ownedBy: string
-  serviceClassId: string
-  type: string
+  ownedBy?: string
+  serviceClassId?: string
+  type?: string
 }

src/types/environment.ts

@@ -2,25 +2,25 @@
 // It is used to define the structure of the environment data returned by the API.
 // The interfaces are used to ensure that the data returned by the API matches the expected structure.
 export interface Environment {
-  bgColor: string
-  createdBy: string
-  createdTime: string
-  description: string
-  fgColor: string
-  icon: string
-  id: string
-  isDefault: boolean
-  isProduction: boolean
+  bgColor?: string
+  createdBy?: string
+  createdTime?: string
+  description?: string
+  fgColor?: string
+  icon?: string
+  id?: string
+  isDefault?: boolean
+  isProduction?: boolean
   name: string
-  organization: {
+  organization?: {
     id: string
     internal: boolean
     name: string
     organizationType: string
   }
-  type: string
-  updatedBy: string
-  updatedTime: string
+  type?: string
+  updatedBy?: string
+  updatedTime?: string
 }
 // Example of an Environment object
 // {

test/commands/missionctrl/broker/list.test.ts

@@ -3,6 +3,7 @@ import { expect } from 'chai'
 import * as sinon from 'sinon'
 import { table } from 'table'
 
+import { EventBrokerServiceDetail } from '../../../../src/types/broker.js'
 import { ScConnection } from '../../../../src/util/sc-connection.js'
 
 function anBroker(brokerName: string, brokerId: string) {
@@ -11,6 +12,7 @@ function anBroker(brokerName: string, brokerId: string) {
     createdBy: 'test',
     createdTime: '2024-09-05T19:54:42.766',
     id: brokerId,
+    name: brokerName,
     operationType: '',
     resourceId: '',
     resourceType: '',
@@ -32,7 +34,7 @@ describe('missionctrl:broker:list', () => {
 
   it('runs missionctrl:broker:list cmd', async () => {
     // Arrange
-    const envs = {
+    const brokers = {
       data: [anBroker('Broker1', 'BrokerId1'), anBroker('Broker1', 'BrokerId1'),
       anBroker('Broker3', 'BrokerId3')],
       meta: {
@@ -45,12 +47,12 @@ describe('missionctrl:broker:list', () => {
         }
       }
     }
-    scConnStub.returns(Promise.resolve(envs))
+    scConnStub.returns(Promise.resolve(brokers))
 
     // Expected
     const brokerArray = [
       ['Name', 'Id', 'Type', 'Version', 'Owned By', 'Datacenter Id', 'Service Class Id'],
-      ...envs.data.map((item: any) => [
+      ...brokers.data.map((item: EventBrokerServiceDetail) => [
         item.name,
         item.id,
         item.type,

test/commands/platform/env/list.test.ts

@@ -3,6 +3,7 @@ import { expect } from 'chai'
 import * as sinon from 'sinon'
 import { table } from 'table'
 
+import { Environment } from '../../../../src/types/environment'
 import { ScConnection } from '../../../../src/util/sc-connection'
 
 function anEnv(name: string, isDefault: boolean, isProd: boolean) {
@@ -49,7 +50,7 @@ describe('platform:env:list', () => {
     // Expected
     const envArray = [
       ['Name', 'Id', 'Is Default', 'Is Production', 'Description'],
-      ...envs.data.map((item: any) => [
+      ...envs.data.map((item: Environment) => [
         item.name,
         item.id,
         item.isDefault,
@@ -86,7 +87,7 @@ describe('platform:env:list', () => {
     // Expected
     const envArray = [
       ['Name', 'Id', 'Is Default', 'Is Production', 'Description'],
-      ...envs.data.map((item: any) => [
+      ...envs.data.map((item: Environment) => [
         item.name,
         item.id,
         item.isDefault,