use pathlib for test data

Author: lboeman

MANIFEST.in

@@ -26,4 +26,4 @@ global-exclude \#*
 global-exclude .ipynb_checkpoints
 
 include versioneer.py
-include solarforecastarbiter/_version.py
+include solarforecastarbiter/_version.py

solarforecastarbiter/io/reference_observations/tests/conftest.py

@@ -1,6 +1,6 @@
 import copy
 import json
-from pkg_resources import resource_filename, Requirement
+from pathlib import Path
 
 
 import numpy as np
@@ -157,7 +157,4 @@ def mock_fetch(mocker, fake_ghi_data):
 
 @pytest.fixture
 def test_json_site_file():
-    return resource_filename(
-        Requirement.parse('solarforecastarbiter'),
-        'solarforecastarbiter/io/reference_observations/'
-        'tests/data/test_site.json')
+    return Path(__file__).resolve().parents[0] / 'data/test_site.json'

solarforecastarbiter/io/reference_observations/tests/test_common.py

@@ -788,3 +788,14 @@ def test_apply_json_site_parameters_plant(test_json_site_file, params):
         {'extra_parameters': params},
     )
     assert 'modeling_parameters' in new_site
+
+
+@pytest.mark.parametrize('params', [
+    {'network_api_id': 'not_plant'},
+])
+def test_apply_json_site_parameters_no_modeling(test_json_site_file, params):
+    new_site = common.apply_json_site_parameters(
+        test_json_site_file,
+        {'extra_parameters': params},
+    )
+    assert 'modeling_parameters' not in new_site