Skip to content

Commit a5b8267

Browse files
Update CHANGELOG, and add regression test for issue 72. (#75)
1 parent c8aaf87 commit a5b8267

File tree

2 files changed

+61
-0
lines changed

2 files changed

+61
-0
lines changed

CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
## 1.10.2
2+
3+
#### FIXES
4+
- `comment` on `dependencytrack_team_apikey` resource was improperly set upon creation to an empty string.
5+
- Thanks to `@acidghost` for contributing a fix.
6+
- Added regression test within `team_apikey_resource_test.go`.
7+
8+
#### DEPENDENCIES
9+
- `actions/download-artifact` `4.2.1` -> `4.3.0`
10+
111
## 1.10.1
212

313
#### MISC
@@ -7,6 +17,9 @@
717
- Update `docker_compose.yml` file to use an external `postgres` database, as recommended.
818
- GitHub actions are lagging, due to inability to manage dependencies between job services.
919

20+
#### ISSUES
21+
- [Fixed in `1.10.2`] Comments on API keys are set to an empty string in state upon creation. Thanks to `@acidghost` for reporting.
22+
1023
## 1.10.0
1124

1225
#### FEATURES

internal/provider/team_apikey_resource_test.go

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,3 +68,51 @@ resource "dependencytrack_team_apikey" "test" {
6868
},
6969
})
7070
}
71+
72+
func TestAccAPIKeyResourceCommentRegression72(t *testing.T) {
73+
// Regression test for https://github.com/SolarFactories/terraform-provider-dependencytrack/issues/72
74+
resource.Test(t, resource.TestCase{
75+
ProtoV6ProviderFactories: testAccProtoV6ProviderFactories,
76+
Steps: []resource.TestStep{
77+
// Create and Read testing
78+
{
79+
Config: providerConfig + `
80+
resource "dependencytrack_team" "test" {
81+
name = "Test_Team"
82+
}
83+
resource "dependencytrack_team_apikey" "test" {
84+
team = dependencytrack_team.test.id
85+
comment = "Sample Creation Comment"
86+
}
87+
`,
88+
Check: resource.ComposeAggregateTestCheckFunc(
89+
resource.TestCheckResourceAttr("dependencytrack_team_apikey.test", "comment", "Sample Creation Comment"),
90+
),
91+
},
92+
// ImportState testing
93+
{
94+
ResourceName: "dependencytrack_team_apikey.test",
95+
ImportState: true,
96+
ImportStateVerify: true,
97+
// TODO: Ignore in only 4.13+ API versions
98+
ImportStateVerifyIgnore: []string{"key"},
99+
},
100+
// Update and Read testing
101+
{
102+
Config: providerConfig + `
103+
resource "dependencytrack_team" "test" {
104+
name = "Test_Team"
105+
}
106+
resource "dependencytrack_team_apikey" "test" {
107+
team = dependencytrack_team.test.id
108+
comment = "Sample Update Comment"
109+
}
110+
111+
`,
112+
Check: resource.ComposeAggregateTestCheckFunc(
113+
resource.TestCheckResourceAttr("dependencytrack_team_apikey.test", "comment", "Sample Update Comment"),
114+
),
115+
},
116+
},
117+
})
118+
}

0 commit comments

Comments
 (0)