feat: Returned the internal types restriction

When not using any filter (like Inherits), this adds a lot of unnecessary types to the drop-down. Better off adding an option to TypeOptionsAttribute than allowing internal types in all cases

Author: SolidAlloy

Editor/Util/TypeCollector.cs

@@ -143,24 +143,12 @@ public static Assembly TryLoadAssembly(string assemblyName)
 
         private static List<Type> GetFilteredTypesFromAssembly(Assembly assembly, TypeOptionsAttribute filter)
         {
-            Type[] assemblyTypes;
-
-            try
-            {
-                assemblyTypes = assembly.GetTypes();
-            }
-            catch (ReflectionTypeLoadException e)
-            {
-                Debug.LogError($"Types could not be extracted from assembly {assembly}: {e.Message}");
-                return new List<Type>(0);
-            }
-
+            var visibleTypes = GetVisibleTypesFromAssembly(assembly);
             var filteredTypes = new List<Type>();
-
-            for (int i = 0; i < assemblyTypes.Length; i++)
+            int visibleTypesCount = visibleTypes.Count;
+            for (int i = 0; i < visibleTypesCount; i++)
             {
-                Type type = assemblyTypes[i];
-
+                Type type = visibleTypes[i];
                 if (FilterConstraintIsSatisfied(filter, type))
                 {
                     filteredTypes.Add(type);
@@ -170,6 +158,27 @@ private static List<Type> GetFilteredTypesFromAssembly(Assembly assembly, TypeOp
             return filteredTypes;
         }
 
+        private static List<Type> GetVisibleTypesFromAssembly(Assembly assembly)
+        {
+            try
+            {
+                var assemblyTypes = assembly.GetTypes();
+                var visibleTypes = new List<Type>(assemblyTypes.Length);
+                for (int i = 0; i < assemblyTypes.Length; i++)
+                {
+                    Type type = assemblyTypes[i];
+                    if (type.IsVisible)
+                        visibleTypes.Add(type);
+                }
+                return visibleTypes;
+            }
+            catch (ReflectionTypeLoadException e)
+            {
+                Debug.LogError($"Types could not be extracted from assembly {assembly}: {e.Message}");
+                return new List<Type>(0);
+            }
+        }
+
         private static bool FilterConstraintIsSatisfied(TypeOptionsAttribute filter, Type type)
         {
             return filter == null || filter.MatchesRequirements(type);