style: Minor refactorings

Author: SolidAlloy

Editor/Drawers/TypeReferencePropertyDrawer.cs

@@ -35,7 +35,7 @@ private static Rect GetPositionWithoutLabel(Rect position, GUIContent label)
 
         private void DrawTypeReferenceField(Rect position, SerializedProperty property)
         {
-            var typeOptionsAttribute = attribute as TypeOptionsAttribute ?? TypeOptionsAttribute.Default;
+            var typeOptionsAttribute = attribute as TypeOptionsAttribute ?? new TypeOptionsAttribute();
             var serializedTypeRef = new SerializedTypeReference(property);
 
             var selectedType = TypeCache.GetType(serializedTypeRef.TypeNameAndAssembly);

Editor/Util/TypeCollector.cs

@@ -27,39 +27,38 @@ internal static class TypeCollector
         /// </remarks>
         public static List<Assembly> GetAssembliesTypeHasAccessTo(Type type)
         {
-            List<Assembly> assemblies;
+            Assembly typeAssembly;
 
             try
             {
-                Assembly typeAssembly = type == null ? Assembly.Load("Assembly-CSharp") : type.Assembly;
-
-                var referencedAssemblies = typeAssembly.GetReferencedAssemblies();
-                assemblies = new List<Assembly>(referencedAssemblies.Length + 1);
-
-                for (int i = 0; i < referencedAssemblies.Length; i++)
-                {
-                    assemblies[i] = Assembly.Load(referencedAssemblies[i]);
-                }
-
-                assemblies[referencedAssemblies.Length] = typeAssembly;
+                typeAssembly = type == null ? Assembly.Load("Assembly-CSharp") : type.Assembly;
             }
             catch (FileNotFoundException)
             {
-                assemblies = new List<Assembly>(AppDomain.CurrentDomain.GetAssemblies());
+                return GetAllAssemblies();
+            }
+
+            var referencedAssemblies = typeAssembly.GetReferencedAssemblies();
+            var assemblies = new List<Assembly>(referencedAssemblies.Length + 1);
+
+            for (int i = 0; i < referencedAssemblies.Length; i++)
+            {
+                assemblies[i] = Assembly.Load(referencedAssemblies[i]);
             }
 
+            assemblies[referencedAssemblies.Length] = typeAssembly;
             return assemblies;
         }
 
-        public static List<Assembly> GetAssembliesTypeHasAccessTo(Type type, out bool containsMSCorLib)
+        public static List<Assembly> GetAssembliesTypeHasAccessTo(Type type, out bool containsMscorlib)
         {
             if (type == null)
             {
-                containsMSCorLib = true;
+                containsMscorlib = true;
                 return GetAllAssemblies();
             }
 
-            containsMSCorLib = false;
+            containsMscorlib = false;
             Assembly typeAssembly = type.Assembly;
 
             var referencedAssemblies = typeAssembly.GetReferencedAssemblies();
@@ -69,17 +68,17 @@ public static List<Assembly> GetAssembliesTypeHasAccessTo(Type type, out bool co
             {
                 var assemblyName = referencedAssemblies[i];
 
-                if ( ! containsMSCorLib && assemblyName.Name == "mscorlib")
+                if ( ! containsMscorlib && assemblyName.Name == "mscorlib")
                 {
-                    containsMSCorLib = true;
+                    containsMscorlib = true;
                 }
 
                 assemblies.Add(Assembly.Load(assemblyName));
             }
 
-            if ( ! containsMSCorLib && typeAssembly.FullName.Contains("mscorlib"))
+            if ( ! containsMscorlib && typeAssembly.FullName.Contains("mscorlib"))
             {
-                containsMSCorLib = true;
+                containsMscorlib = true;
             }
 
             assemblies.Add(typeAssembly);

Runtime/Attributes/TypeOptionsAttribute.cs

@@ -13,10 +13,6 @@
     [AttributeUsage(AttributeTargets.Field)]
     public class TypeOptionsAttribute : PropertyAttribute
     {
-        private static readonly TypeOptionsAttribute _defaultInstance = new TypeOptionsAttribute();
-
-        public static TypeOptionsAttribute Default => _defaultInstance;
-
         /// <summary>
         /// Gets or sets grouping of selectable types. Defaults to <see><cref>Grouping.ByNamespaceFlat</cref></see>
         /// unless explicitly specified.
@@ -42,7 +38,10 @@ public class TypeOptionsAttribute : PropertyAttribute
         /// </summary>
         [PublicAPI] public string[] IncludeAdditionalAssemblies;
 
-        /// <summary>Gets or sets the height of the dropdown. Default is zero.</summary>
+        /// <summary>
+        /// Gets or sets the height of the dropdown. If not set, the height is dynamic (min 100, max 600 pixels).
+        /// If set outside the height limits, the height will be clamped.
+        /// </summary>
         [PublicAPI] public int DropdownHeight;
 
         /// <summary>