Revamped pop-up for deleteButtonWithCheck, returns a plain img elelemnt as it used to

Author: Tim Berners-Lee

src/style.js

@@ -22,7 +22,9 @@ export const style = { // styleModule
       'background-color: #fff; padding: 0.7em;  border: .01em solid white;  border-radius:0.2em; font-size: 100%; margin: 0.3em;', // 'background-color: #eef;
   commentStyle: 'padding: 0.7em;  border: none; font-size: 100%; white-space: pre-wrap;',
   iconStyle: 'width: 3em; height: 3em; margin: 0.1em; border-radius: 1em;',
+  smallButtonStyle: 'margin: 0.2em; width: 1em; height:1em',
   classIconStyle: 'width: 3em; height: 3em; margin: 0.1em; border-radius: 0.2em; border: 0.1em solid green; padding: 0.2em; background-color: #efe;', // combine with buttonStyle
+  confirmPopupStyle: 'padding: 0.7em; border-radius: 0.2em; border: 0.1em solid orange; background-color: white; box-shadow: 0.5em 0.9em #888;',
   tabBorderRadius: '0.2em',
   messageBodyStyle:
     'white-space: pre-wrap; width: 99%; font-size:100%; border: 0.07em solid #eee; border-radius:0.2em; padding: .3em 0.5em; margin: 0.1em;',

src/widgets/buttons.ts

@@ -435,84 +435,96 @@ export function faviconOrDefault (dom: HTMLDocument, x: NamedNode) {
   }
 }
 
+/* Two-option dialog pop-up
+*/
+
+function renderDeleteConfirmPopup (dom, refererenceElement, prompt, deleteFunction) {
+  function removePopup () {
+    refererenceElement.parentElement.removeChild(refererenceElement)
+  }
+  function removePopupAndDoDeletion () {
+    removePopup()
+    deleteFunction()
+  }
+  const popup = dom.createElement('div')
+  popup.style = style.confirmPopupStyle
+  popup.style.position = 'absolute'
+  popup.style.top = '-1em' // try leaving original button clear
+
+  popup.style.display = 'grid'
+  popup.style.gridTemplateColumns = 'auto auto'
+  const affirm = dom.createElement('div')
+  affirm.style.gridColumn = '1/2'
+  affirm.style.gridRow = '1' // @@ sigh; TS. could pass number in fact
+  const cancel = dom.createElement('div')
+  cancel.style.gridColumn = '1/2'
+  cancel.style.gridRow = '2'
+
+  const xButton = cancelButton(dom, removePopup)
+  popup.appendChild(xButton)
+  xButton.style.gridColumn = '1'
+  xButton.style.gridRow = '2'
+
+  const cancelPrompt = popup.appendChild(dom.createElement('button'))
+  cancelPrompt.style = style.buttonStyle
+  cancelPrompt.style.gridRow = '2'
+  cancelPrompt.style.gridColumn = '2'
+  cancelPrompt.textContent = 'Cancel' // @@ I18n
+
+  const affirmIcon = button(dom, icons.iconBase + 'noun_925021.svg', 'Delete it') // trashcan
+  popup.appendChild(affirmIcon)
+  affirmIcon.style.gridRow = '1'
+  affirmIcon.style.gridColumn = '1'
+
+  const sureButtonElt = popup.appendChild(dom.createElement('button'))
+  sureButtonElt.style = style.buttonStyle
+  sureButtonElt.style.gridRow = '1'
+  sureButtonElt.style.gridColumn = '2'
+  sureButtonElt.textContent = prompt
+  popup.appendChild(sureButtonElt)
+
+  affirmIcon.addEventListener('click', removePopupAndDoDeletion)
+  sureButtonElt.addEventListener('click', removePopupAndDoDeletion)
+
+  // xButton.addEventListener('click', removePopup)
+  cancelPrompt.addEventListener('click', removePopup)
+
+  return popup
+}
 /**
  * Delete button with a check you really mean it
  * @@ Supress check if command key held down?
  */
 export function deleteButtonWithCheck (
   dom: HTMLDocument,
-  container: HTMLElement | null, // Used to interfere with style of this
+  container: HTMLElement,
   noun: string,
   deleteFunction: () => any
 ) {
-  function setStyle () {
-    buttonDiv.style.border = ''
-    buttonDiv.style.margin = '0.3em'
-    buttonDiv.style.borderRadius = '0'
-    buttonDiv.style.padding = '0.3em white'
-    buttonDiv.style.boxShadow = ''
+  function createPopup () {
+    const refererenceElement = dom.createElement('div')
+    container.insertBefore(refererenceElement, deleteButton)
+    refererenceElement.style.position = 'relative' // Needed as reference for popup
+    refererenceElement.appendChild(renderDeleteConfirmPopup(dom, refererenceElement, prompt, deleteFunction))
   }
-  const buttonDiv = dom.createElement('div')
   const minusIconURI = iconBase + 'noun_2188_red.svg' // white minus in red #cc0000 circle
-  const img = dom.createElement('img')
-  let sureButtonElt, cancelButtonElt
-  img.setAttribute('src', minusIconURI) //  plus sign
-  img.setAttribute('style', 'margin: 0.2em; width: 1em; height:1em')
-  img.title = 'Remove this ' + noun
-  const deleteButtonElt = img
-
-  buttonDiv.appendChild(deleteButtonElt)
-  buttonDiv.setAttribute('class', 'hoverControl') // See tabbedtab.css (sigh global CSS)
-  setStyle()
-
-  deleteButtonElt.setAttribute('class', 'hoverControlHide')
-
-  deleteButtonElt.addEventListener(
-    'click',
-    function (_event) {
-      buttonDiv.style.borderRadius = '0.5em'
-      buttonDiv.style.border = 'orange 0.05em;'
-      buttonDiv.style.boxShadow = '0.2em 0.5em #888888'
-      buttonDiv.style.padding = '0.3em'
-
-      buttonDiv.removeChild(deleteButtonElt) // Ask -- are you sure?
-      cancelButtonElt = dom.createElement('button')
-      // cancelButton.textContent = 'cancel'
-      cancelButtonElt.setAttribute('style', style.buttonStyle)
-      const img = cancelButtonElt.appendChild(dom.createElement('img'))
-      img.setAttribute('src', cancelIconURI)
-      img.setAttribute('style', style.buttonStyle)
-
-      buttonDiv.appendChild(cancelButtonElt).addEventListener(
-        'click',
-        function (_event) {
-          buttonDiv.removeChild(sureButtonElt)
-          buttonDiv.removeChild(cancelButtonElt)
-          setStyle()
-          buttonDiv.appendChild(deleteButtonElt)
-        },
-        false
-      )
-      sureButtonElt = dom.createElement('button')
-      sureButtonElt.textContent = 'Delete ' + noun
-      sureButtonElt.setAttribute('style', style.buttonStyle)
-      buttonDiv.appendChild(sureButtonElt).addEventListener(
-        'click',
-        function (_event) {
-          buttonDiv.removeChild(sureButtonElt)
-          buttonDiv.removeChild(cancelButtonElt)
-          setStyle()
-          deleteFunction()
-        },
-        false
-      )
-    },
-    false
-  )
-  if (container) { // Old API
-    container.appendChild(buttonDiv)
-  }
-  return buttonDiv // deleteButtonElt
+  const deleteButton = dom.createElement('img')
+  deleteButton.setAttribute('src', minusIconURI)
+
+  deleteButton.setAttribute('style', style.smallButtonStyle) // @@tsc - would set deleteButton.style
+  deleteButton.style.float = 'right' // Historically this has alwaus floated right
+
+  const prompt = 'Remove this ' + noun
+  deleteButton.title = prompt
+  // @@ In an ideal world, make use of hover an accessibility option
+  deleteButton.classList.add('hoverControlHide')
+
+  deleteButton.addEventListener('click', createPopup)
+
+  container.classList.add('hoverControl')
+  container.appendChild(deleteButton)
+  deleteButton.setAttribute('data-testid', 'deleteButtonWithCheck')
+  return deleteButton // or button div?  caller may change size of image
 }
 
 /**
@@ -567,7 +579,7 @@ function getButtonStyle (options: ButtonWidgetOptions = {}) {
  * @returns <dDomElement> - the button
  */
 export function button (dom: HTMLDocument, iconURI: string | undefined, text: string,
-  handler?: (event: any) => void,
+  handler?: (_event: any) => void,
   options: ButtonWidgetOptions = { buttonColor: 'Primary', needsBorder: false }) {
   const button = dom.createElement('button')
   button.setAttribute('type', 'button')
@@ -600,7 +612,7 @@ export function button (dom: HTMLDocument, iconURI: string | undefined, text: st
  *
  * @returns <dDomElement> - the button
  */
-export function cancelButton (dom: HTMLDocument, handler: (event: any) => void) {
+export function cancelButton (dom: HTMLDocument, handler: (_event?: any) => void) {
   return button(dom, cancelIconURI, 'Cancel', handler)
 }
 
@@ -611,7 +623,7 @@ export function cancelButton (dom: HTMLDocument, handler: (event: any) => void)
  *
  * @returns <dDomElement> - the button
  */
-export function continueButton (dom: HTMLDocument, handler: (event: any) => void) {
+export function continueButton (dom: HTMLDocument, handler: (_event: any) => void) {
   return button(dom, checkIconURI, 'Continue', handler)
 }
 
@@ -1093,8 +1105,8 @@ export function selectorPanel (
   inverse: boolean,
   possible: NamedNode[],
   options: { connectIcon?: string },
-  callbackFunction: (x: NamedNode, e: Event, selected: boolean) => void,
-  linkCallback: (x: NamedNode, e: Event, inverse: boolean, setStyleFunction: () => void) => void
+  callbackFunction: (_x: NamedNode, _e: Event, _selected: boolean) => void,
+  linkCallback: (_x: NamedNode, _e: Event, _inverse: boolean, _setStyleFunction: () => void) => void
 ) {
   return selectorPanelRefresh(
     dom.createElement('div'),
@@ -1119,8 +1131,8 @@ export function selectorPanelRefresh (
   inverse: boolean,
   possible: NamedNode[],
   options: { connectIcon?: string },
-  callbackFunction: (x: NamedNode, e: Event, selected: boolean) => void,
-  linkCallback: (x: NamedNode, e: Event, inverse: boolean, setStyleFunction: () => void) => void
+  callbackFunction: (_x: NamedNode, _e: Event, _selected: boolean) => void,
+  linkCallback: (_x: NamedNode, _e: Event, _inverse: boolean, _setStyleFunction: () => void) => void
 ) {
   const style0 =
     'border: 0.1em solid #ddd; border-bottom: none; width: 95%; height: 2em; padding: 0.5em;'
@@ -1223,7 +1235,7 @@ function twoLineDefault (dom: HTMLDocument, x: NamedNode): HTMLElement {
  * Find a function that can create a widget for a given class
  * @param c The RDF class for which we want a widget generator function
  */
-function twoLineWidgetForClass (c: NamedNode): (dom: HTMLDocument, x: NamedNode) => HTMLElement {
+function twoLineWidgetForClass (c: NamedNode): (_dom: HTMLDocument, _x: NamedNode) => HTMLElement {
   let widget = index.twoLine[c.uri]
   const kb = store
   if (widget) return widget
@@ -1355,7 +1367,7 @@ export function isImage (file?: NamedNode, kind?: string): boolean {
 // See https://developer.mozilla.org/en-US/docs/Web/API/File/Using_files_from_web_applications
 export function fileUploadButtonDiv (
   dom: HTMLDocument,
-  droppedFileHandler: (files: FileList) => void
+  droppedFileHandler: (_files: FileList) => void
 ) {
   const div = dom.createElement('div')
   const input = div.appendChild(dom.createElement('input'))

test/unit/utils/label.test.ts

@@ -2,7 +2,7 @@ import { lit, sym } from 'rdflib'
 import { label } from '../../../src/utils'
 import { silenceDebugMessages } from '../../helpers/setup'
 import { store } from '../../../src/logic'
-import * as ns from '../../../src/ns'
+
 silenceDebugMessages()
 jest.mock('solid-auth-client', () => ({
   currentSession: () => Promise.resolve(),

test/unit/widgets/forms/autocomplete/__snapshots__/autocomplete.test.ts.snap

@@ -95,19 +95,16 @@ exports[`autocompleteField clicking on row of greenn table then accecpt button s
             title="Edit"
           />
         </button>
-        <div>
-          <div
-            class="hoverControl"
+        <div
+          class="hoverControl"
+        >
+          <img
+            class="hoverControlHide"
             data-testid="delete-button"
-            style="margin: 0.3em; border-radius: 0;"
-          >
-            <img
-              class="hoverControlHide"
-              src="https://solid.github.io/solid-ui/src/icons/noun_2188_red.svg"
-              style="margin: 0.2em; width: 1em; height:1em"
-              title="Remove this Q6881511"
-            />
-          </div>
+            src="https://solid.github.io/solid-ui/src/icons/noun_2188_red.svg"
+            style="margin: 0.2em; width: 1em; height: 1em; float: right;"
+            title="Remove this Q6881511"
+          />
         </div>
       </div>
     </div>
@@ -189,19 +186,16 @@ exports[`autocompleteField creates a autocomplete field 1`] = `
             title="Edit"
           />
         </button>
-        <div>
-          <div
-            class="hoverControl"
+        <div
+          class="hoverControl"
+        >
+          <img
+            class="hoverControlHide"
             data-testid="delete-button"
-            style="margin: 0.3em; border-radius: 0;"
-          >
-            <img
-              class="hoverControlHide"
-              src="https://solid.github.io/solid-ui/src/icons/noun_2188_red.svg"
-              style="margin: 0.2em; width: 1em; height:1em"
-              title="Remove this Q6881511"
-            />
-          </div>
+            src="https://solid.github.io/solid-ui/src/icons/noun_2188_red.svg"
+            style="margin: 0.2em; width: 1em; height: 1em; float: right;"
+            title="Remove this Q6881511"
+          />
         </div>
       </div>
     </div>
@@ -318,19 +312,16 @@ exports[`autocompleteField typing more search term till unique selects the whole
             title="Edit"
           />
         </button>
-        <div>
-          <div
-            class="hoverControl"
+        <div
+          class="hoverControl"
+        >
+          <img
+            class="hoverControlHide"
             data-testid="delete-button"
-            style="margin: 0.3em; border-radius: 0;"
-          >
-            <img
-              class="hoverControlHide"
-              src="https://solid.github.io/solid-ui/src/icons/noun_2188_red.svg"
-              style="margin: 0.2em; width: 1em; height:1em"
-              title="Remove this Q6881511"
-            />
-          </div>
+            src="https://solid.github.io/solid-ui/src/icons/noun_2188_red.svg"
+            style="margin: 0.2em; width: 1em; height: 1em; float: right;"
+            title="Remove this Q6881511"
+          />
         </div>
       </div>
     </div>