File: fix assignment ambiguity.

Author: SolidWallOfCode

code/include/swoc/swoc_file.h

@@ -127,6 +127,15 @@ class path {
   /// Assign @a p as the path.
   self_type &operator=(std::string_view p);
 
+  /// Assign @a s as the path.
+  self_type &operator=(std::string const& s);
+
+  /// Move @a s to be the path.
+  self_type &operator=(std::string && s);
+
+  /// Copy @a s as the path.
+  self_type &operator=(char const * s);
+
   /** Append or replace path with @a that.
    *
    * If @a that is absolute, it replaces @a this. Otherwise @a that is appended with exactly one
@@ -368,6 +377,24 @@ path::operator=(std::string_view p) {
   return *this;
 }
 
+inline path &
+path::operator=(std::string const& s) {
+  _path.assign(s);
+  return *this;
+}
+
+inline path &
+path::operator=(std::string && s) {
+  _path.assign(std::move(s));
+  return *this;
+}
+
+inline path &
+path::operator=(char const * s) {
+  _path.assign(s);
+  return *this;
+}
+
 inline char const *
 path::c_str() const {
   return _path.c_str();

unit_tests/test_swoc_file.cc

@@ -74,6 +74,8 @@ TEST_CASE("swoc_file", "[libswoc][swoc_file]") {
   [[maybe_unused]] auto mtime = file::last_write_time(s1, ec);
   REQUIRE(ec.value() != 0);
 
+  fp = s1; // Make sure this isn't ambiguous
+
   // Verify path can be used as a hashed key for STL containers.
   [[maybe_unused]] std::unordered_map<file::path, std::string> container;
 }