ci(pages): update GitHub Actions to artifact-v4-compatible workflow

- Use actions/upload-pages-artifact@v3 to avoid deprecated upload-artifact v3
- Use actions/deploy-pages@v4 for robust Pages deploy
- Keep caching and ruby setup for reproducible Jekyll builds

Signed-off-by: https://github.com/Someshdiwan <[email protected]>

Author: Someshdiwan

.github/workflows/jekyll-gh-pages.yml

@@ -1,33 +1,27 @@
-# .github/workflows/deploy-pages.yml
-name: "Deploy Jekyll with GitHub Pages (robust)"
+name: "Deploy Jekyll with GitHub Pages (robust & artifact-v4 compatible)"
 
-# Triggers: push to main/master, manual dispatch, and periodic schedule (UTC)
 on:
   push:
     branches:
-      - main
       - master
+      - main
   workflow_dispatch: {}
   schedule:
-    - cron: '0 12 * * *' # daily at 12:00 UTC (adjust if needed)
+    - cron: '0 12 * * *' # daily at 12:00 UTC (adjust as needed)
 
-# Least privilege for required tokens
 permissions:
-  contents: read        # read repo contents to build
-  pages: write          # allow publishing to GitHub Pages
-  id-token: write       # for OIDC if you need it later (optional)
+  contents: read
+  pages: write
+  id-token: write
 
-# Prevent concurrent runs for the same ref (avoids race conditions)
 concurrency:
-  group: "pages-${{ github.ref }}"  # isolate per-branch/ref
+  group: "pages-${{ github.ref }}"
   cancel-in-progress: false
 
 jobs:
   build:
     name: Build site (Jekyll)
     runs-on: ubuntu-latest
-    outputs:
-      page_artifact: ${{ steps.upload-artifact.outputs.artifact-path || '' }}
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -38,10 +32,9 @@ jobs:
       - name: Set up Ruby (for Jekyll)
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.2'          # pick an appropriate Ruby version for your site
-          bundler-cache: true         # optional: automatically caches gems (fallback)
+          ruby-version: '3.2'
+          bundler-cache: true
 
-      # If you prefer explicit caching control, here's a cache step for vendor/bundle:
       - name: Cache bundler gems
         uses: actions/cache@v4
         with:
@@ -50,34 +43,29 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-gems-
 
-      - name: Configure Bundler & install dependencies
+      - name: Install dependencies
         run: |
-          # Use vendor/bundle for reproducible builds and to make cache effective
           bundle config set --local path 'vendor/bundle'
-          # Install with retries for network resilience
           bundle install --jobs 4 --retry 3
 
       - name: Build Jekyll site
         run: |
-          # Explicit source/destination keeps things deterministic
           bundle exec jekyll build --source site --destination _site
         env:
-          # Ensure Jekyll sees production-like environment
           JEKYLL_ENV: production
 
-      - name: Validate _site exists
+      - name: Validate build
         run: |
           if [ ! -d "_site" ]; then
             echo "_site wasn't generated — failing the job."
             exit 1
           fi
 
-      - name: Upload GitHub Pages artifact
-        id: upload-artifact
-        uses: actions/upload-pages-artifact@v1
+      # Use upload-pages-artifact v3 (recent) which is compatible with artifact v4 backend
+      - name: Upload Pages artifact
+        uses: actions/upload-pages-artifact@v3
         with:
           path: ./_site
-          # name is not required to be unique across repos; keep conservative naming
           name: java-evolution-pages
 
   deploy:
@@ -86,13 +74,13 @@ jobs:
     runs-on: ubuntu-latest
     environment:
       name: github-pages
-      url: ${{ steps.deploy.outputs.page_url || '' }}
     steps:
       - name: Deploy to GitHub Pages
         id: deploy
         uses: actions/deploy-pages@v4
         with:
           artifact_name: java-evolution-pages
 
-      - name: Output deploy URL
-        run: echo "Deployed to ${{ steps.deploy.outputs.page_url }}"
+      - name: Announce deploy URL
+        run: |
+          echo "Deployed to ${{ steps.deploy.outputs.page_url }}"