Merge pull request #2925 from guwirth/cppcheck-2.17

Cppcheck 2.17 support

Author: guwirth

cxx-sensors/src/main/resources/cppcheck.xml

@@ -8154,6 +8154,81 @@ Pointer arithmetic overflow.
     <tag>cwe</tag>
     <severity>MINOR</severity>
     </rule>
+  <!-- ########### New in Cppcheck 2.17.1 ########### -->
+  <rule>
+    <key>class_X_Y</key>
+    <name>The code '   ' is not handled. You can use -I or --include to add handling of this code</name>
+    <description><![CDATA[
+        The code '   ' is not handled. You can use -I or --include to add handling of this code.
+        ]]></description>
+    <severity>MINOR</severity>
+    <remediationFunction>CONSTANT_ISSUE</remediationFunction>
+    <remediationFunctionBaseEffort>5min</remediationFunctionBaseEffort>
+  </rule>
+  <rule>
+    <key>invalidConstFunctionType</key>
+    <name>It is unspecified behavior to const qualify a function type</name>
+    <description><![CDATA[
+        It is unspecified behavior to const qualify a function type.
+        ]]></description>
+    <severity>MINOR</severity>
+    <type>BUG</type>
+    <remediationFunction>CONSTANT_ISSUE</remediationFunction>
+    <remediationFunctionBaseEffort>5min</remediationFunctionBaseEffort>
+  </rule>
+  <rule>
+    <key>macroWithSemicolon</key>
+    <name>Ensure that '' is defined either using -I, --include or -D</name>
+    <description><![CDATA[
+        Ensure that '' is defined either using -I, --include or -D.
+        ]]></description>
+    <severity>MINOR</severity>
+    <remediationFunction>CONSTANT_ISSUE</remediationFunction>
+    <remediationFunctionBaseEffort>5min</remediationFunctionBaseEffort>
+  </rule>
+  <rule>
+    <key>nonStandardCharLiteral</key>
+    <name>Non-standard character literal. </name>
+    <description><![CDATA[
+        Non-standard character literal. 
+        ]]></description>
+    <severity>MINOR</severity>
+    <type>BUG</type>
+    <remediationFunction>CONSTANT_ISSUE</remediationFunction>
+    <remediationFunctionBaseEffort>5min</remediationFunctionBaseEffort>
+  </rule>
+  <rule>
+    <key>nullPointerOutOfMemory</key>
+    <name>Null pointer dereference</name>
+    <description><![CDATA[
+        <p>
+  Null pointer dereference
+  </p>
+  <h2>References</h2>
+  <p><a href="https://cwe.mitre.org/data/definitions/476.html" target="_blank">CWE-476</a></p>
+        ]]></description>
+    <tag>cwe</tag>
+    <severity>MINOR</severity>
+    <type>BUG</type>
+    <remediationFunction>CONSTANT_ISSUE</remediationFunction>
+    <remediationFunctionBaseEffort>5min</remediationFunctionBaseEffort>
+  </rule>
+  <rule>
+    <key>nullPointerOutOfResources</key>
+    <name>Null pointer dereference</name>
+    <description><![CDATA[
+        <p>
+  Null pointer dereference
+  </p>
+  <h2>References</h2>
+  <p><a href="https://cwe.mitre.org/data/definitions/476.html" target="_blank">CWE-476</a></p>
+        ]]></description>
+    <tag>cwe</tag>
+    <severity>MINOR</severity>
+    <type>BUG</type>
+    <remediationFunction>CONSTANT_ISSUE</remediationFunction>
+    <remediationFunctionBaseEffort>5min</remediationFunctionBaseEffort>
+  </rule>
   <!-- ########### Internal Cppcheck errors (not in errorlist) ########### -->
   <rule>
     <key>internalAstError</key>

cxx-sensors/src/test/java/org/sonar/cxx/sensors/cppcheck/CxxCppCheckRuleRepositoryTest.java

@@ -37,7 +37,7 @@ void createRulesTest() {
     def.define(context);
 
     RulesDefinition.Repository repo = context.repository(CxxCppCheckRuleRepository.KEY);
-    assertThat(repo.rules()).hasSize(688);
+    assertThat(repo.rules()).hasSize(694);
   }
 
 }

cxx-sensors/src/tools/cwec_latest.xml.zip

@@ -3,7 +3,7 @@ cls
 
 SET SCRIPT_DIR=%~dp0
 SET CPPCHECK_DIR=C:\Program Files\Cppcheck\
-SET PYTHON_DIR=C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\
+SET PYTHON_DIR=C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\
 
 setlocal ENABLEDELAYEDEXPANSION
 
@@ -22,7 +22,7 @@ ECHO create Cppcheck errorlist cppcheck-errorlist.xml...
 "%CPPCHECK_DIR%cppcheck.exe" %CPPCHECK_LIBRARY_ARGS% --errorlist --xml-version=2 > cppcheck-errorlist.xml
 
 ECHO create SonarQube rules file cppcheck.xml...
-"%CPPCHECK_DIR%cppcheck.exe" %CPPCHECK_LIBRARY_ARGS% --errorlist --xml-version=2 | "%PYTHON_DIR%python.exe" cppcheck_createrules.py rules cwec_v4.13.xml > cppcheck.xml
+"%CPPCHECK_DIR%cppcheck.exe" %CPPCHECK_LIBRARY_ARGS% --errorlist --xml-version=2 | "%PYTHON_DIR%python.exe" cppcheck_createrules.py rules cwec_v4.17.xml > cppcheck.xml
 
 ECHO create cppcheck-comparison.md...
 "%PYTHON_DIR%python.exe" utils_createrules.py comparerules "%SCRIPT_DIR%\..\main\resources\cppcheck.xml" .\cppcheck.xml > cppcheck-comparison.md