Merge pull request #2915 from guwirth/cppcheck-iterateByValue

Support Cppcheck rule iterateByValue

Author: guwirth

cxx-sensors/src/main/resources/cppcheck.xml

@@ -2753,6 +2753,23 @@ const reference which is usually faster and recommended in C++.
 </p>
 <h2>References</h2>
 <p><a href="https://cwe.mitre.org/data/definitions/398.html" target="_blank">CWE-398: 7PK - Code Quality</a></p>
+]]>
+    </description>
+    <tag>cwe</tag>
+    <severity>MINOR</severity>
+    <type>BUG</type>
+  </rule>
+  <rule>
+    <key>iterateByValue</key>
+    <name>Range variable 'var' should be declared as const reference</name>
+    <description>
+      <![CDATA[
+      <p>      
+Variable 'var' is used to iterate by value. It could be declared as a
+const reference which is usually faster and recommended in C++.
+</p>
+<h2>References</h2>
+<p><a href="https://cwe.mitre.org/data/definitions/398.html" target="_blank">CWE-398: 7PK - Code Quality</a></p>
 ]]>
     </description>
     <tag>cwe</tag>

cxx-sensors/src/test/java/org/sonar/cxx/sensors/cppcheck/CxxCppCheckRuleRepositoryTest.java

@@ -37,7 +37,7 @@ void createRulesTest() {
     def.define(context);
 
     RulesDefinition.Repository repo = context.repository(CxxCppCheckRuleRepository.KEY);
-    assertThat(repo.rules()).hasSize(687);
+    assertThat(repo.rules()).hasSize(688);
   }
 
 }