fix directories metrics

- https://community.sonarsource.com/t/pre-sq7-6-different-directories-metric-value/6190
- In SQ 7.6 the old “Maven/Java like” filesystem layout has been replaced by a more modern hierarchy, without modules, but with a hierarchy of folders (instead of having flat package-like folders).
- This new approach will change the value of the metric “directories” because this metric count the number of directory “nodes” in the SonarQube component tree. This is misleading since I guess most people expect the value to be the number of physical sub-directories. In my example above, pre-7.6 value would be 3, and post 7.6 value will be 5 (another pitfall of this metric is that folders containing test files are not counted).

Author: guwirth

.travis.yml

@@ -14,6 +14,7 @@ env:
         - SONARHOME=/tmp/sonarqube-7.3     SONARAPI=SqApi67
         - SONARHOME=/tmp/sonarqube-7.4     SONARAPI=SqApi67
         - SONARHOME=/tmp/sonarqube-7.5     SONARAPI=SqApi75
+        - SONARHOME=/tmp/sonarqube-7.6     SONARAPI=SqApi76
 
 matrix:
     fast_finish: true
@@ -61,6 +62,8 @@ install:
         - unzip -qq sonarqube-7.4.zip
         - travis_retry wget -q https://binaries.sonarsource.com/Distribution/sonarqube/sonarqube-7.5.zip
         - unzip -qq sonarqube-7.5.zip
+        - travis_retry wget -q https://binaries.sonarsource.com/Distribution/sonarqube/sonarqube-7.6.zip
+        - unzip -qq sonarqube-7.6.zip
         - travis_retry wget -q https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-3.3.0.1492.zip
         - unzip -qq sonar-scanner-cli-3.3.0.1492.zip
         - travis_retry wget -q https://github.com/htacg/tidy-html5/archive/5.6.0.zip --output-document=tidy-html5.zip

integration-tests/features/smoketest.feature

@@ -82,3 +82,43 @@ Feature: Smoketest
       | test_failures            | 2     |
       | test_errors              | 0     |
       | tests                    | 4     |
+
+ @SqApi76
+  Scenario: Smoketest
+    Given the project "smoketest_project"
+    When I run "sonar-scanner -X"
+    Then the analysis finishes successfully
+    And the analysis in server has completed
+    And the analysis log contains no error/warning messages except those matching:
+      """
+      .*WARN.*Unable to get a valid mac address, will use a dummy address
+      .*WARN.*cannot find the sources for '#include <gtest/gtest\.h>'
+      .*WARN.*cannot find the sources for '#include <iostream>'
+      .*WARN.*Cannot find the file '.*component_XXX.cc', skipping violations
+      .*WARN.*Cannot find a report for '.*'
+      .*WARN.*Already created edge from 'src/cli/main.cc'.*
+      """
+    And the following metrics have following values:
+      | metric                   | value |
+      | ncloc                    | 56    |
+      | lines                    | 151   |
+      | statements               | 36    |
+      | classes                  | 1     |
+      | files                    | 8     |
+      | directories              | 5     |
+      | functions                | 5     |
+      | comment_lines_density    | 30    |
+      | comment_lines            | 24    |
+      | duplicated_lines_density | 45.7  |
+      | duplicated_lines         | 84    |
+      | duplicated_blocks        | 2     |
+      | duplicated_files         | 2     |
+      | complexity               | 7     |
+      | file_complexity          | 0.9   |
+      | violations               | 12    |
+      | coverage                 | 53.8  |
+      | line_coverage            | 54.8  |
+      | branch_coverage          | 50    |
+      | test_failures            | 2     |
+      | test_errors              | 0     |
+      | tests                    | 4     |