use FilenameUtils.getName because this works on Windows and Linux also if report is generated on the one and consumed on the other

Author: guwirth

cxx-squid/src/main/java/org/sonar/cxx/utils/CxxReportLocation.java

@@ -19,9 +19,9 @@
  */
 package org.sonar.cxx.utils;
 
-import java.nio.file.Paths;
 import java.util.Objects;
 import javax.annotation.Nullable;
+import org.apache.commons.io.FilenameUtils;
 import org.sonar.api.utils.PathUtils;
 
 /**
@@ -42,10 +42,13 @@ public CxxReportLocation(@Nullable String file, @Nullable String line, @Nullable
     // FilenameUtils.normalize internally, relative paths starting with a double dot will cause that path segment
     // and the one before to be removed. If the double dot has no parent path segment to work with, null is returned.
     // null would mean 'project issue' which is wrong in this context. To avoid this we extract the filename to
-    // generate at least a meningful error message.
+    // generate at least a meningful error message (#2747).
     var normalized = PathUtils.sanitize(file);
     if (normalized == null && (file != null && !file.isBlank())) {
-      normalized = Paths.get(file).getFileName().toString();
+
+      // use FilenameUtils.getName because this works on Windows and Linux also if
+      // report is generated on the one and consumed on the other
+      normalized = FilenameUtils.getName(file);
     }
 
     this.file = normalized;