Merge pull request #2854 from guwirth/td-28

fix technical debt

Author: guwirth

cxx-sslr/sslr-core/src/main/java/com/sonar/cxx/sslr/api/AstNode.java

@@ -27,7 +27,6 @@
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
-import javax.annotation.CheckForNull;
 import javax.annotation.Nullable;
 import org.sonar.cxx.sslr.internal.grammar.MutableParsingRule;
 
@@ -142,7 +141,6 @@ public int getNumberOfChildren() {
    *
    * @since 1.17
    */
-  @CheckForNull
   public AstNode getNextAstNode() {
     var nextSibling = getNextSibling();
     if (nextSibling != null) {
@@ -162,7 +160,6 @@ public AstNode getNextAstNode() {
    *
    * @since 1.17
    */
-  @CheckForNull
   public AstNode getPreviousAstNode() {
     var previousSibling = getPreviousSibling();
     if (previousSibling != null) {
@@ -181,7 +178,6 @@ public AstNode getPreviousAstNode() {
    *
    * @since 1.17
    */
-  @CheckForNull
   public AstNode getNextSibling() {
     if (parent == null) {
       return null;
@@ -199,7 +195,6 @@ public AstNode getNextSibling() {
    *
    * @since 1.17
    */
-  @CheckForNull
   public AstNode getPreviousSibling() {
     if (parent == null) {
       return null;
@@ -366,7 +361,6 @@ public boolean isNot(AstNodeType... types) {
    *
    * @since 1.17
    */
-  @CheckForNull
   public AstNode getFirstChild(AstNodeType... nodeTypes) {
     for (var child : children) {
       for (var nodeType : nodeTypes) {
@@ -396,7 +390,6 @@ public AstNode getFirstChild(AstNodeType... nodeTypes) {
    *
    * @since 1.17
    */
-  @CheckForNull
   public AstNode getFirstDescendant(AstNodeType... nodeTypes) {
     for (var child : children) {
       if (child.is(nodeTypes)) {
@@ -508,11 +501,11 @@ public AstNode getLastChild() {
    * </pre>
    *
    * @param nodeTypes to be checked
-   * @return last child of one of specified types, or null if not found
+   * @return last child of one of specified types, or null if not found (@CheckForNull -> normally already ensured via
+   * grammar)
    *
    * @since 1.20
    */
-  @CheckForNull // -> normally already ensured via grammar
   public AstNode getLastChild(AstNodeType... nodeTypes) {
     for (int i = children.size() - 1; i >= 0; i--) {
       var child = children.get(i);
@@ -592,7 +585,6 @@ public boolean hasAncestor(AstNodeType... nodeTypes) {
    *
    * @since 1.17
    */
-  @CheckForNull
   public AstNode getFirstAncestor(AstNodeType nodeType) {
     if (parent == null) {
       return null;
@@ -612,7 +604,6 @@ public AstNode getFirstAncestor(AstNodeType nodeType) {
    *
    * @since 1.19.2
    */
-  @CheckForNull
   public AstNode getFirstAncestor(AstNodeType... nodeTypes) {
     var result = parent;
     while (result != null) {
@@ -687,7 +678,6 @@ public String toString() {
    *
    * @return last token of this node (@CheckForNull -> normally already ensured via grammar)
    */
-  @CheckForNull
   public Token getLastToken() {
     if (!this.hasToken()) {
       return null;