Fix missing packages problem (#262)

Author: vilchik-elena

README.md

@@ -14,7 +14,7 @@ Rules in this category aim to find places in code which have a high chance of be
 * Function calls should not pass extra arguments ([`no-extra-arguments`])
 * Related "if/else if" statements should not have the same condition ([`no-identical-conditions`])
 * Identical expressions should not be used on both sides of a binary operator ([`no-identical-expressions`])
-* Return values from functions without side effects should not be ignored ([`no-ignored-return`])
+* Return values from functions without side effects should not be ignored ([`no-ignored-return`]) (*uses-types*)
 * Loops with at most one iteration should be refactored ([`no-one-iteration-loop`])
 * The output of functions that don't return anything should not be used ([`no-use-of-empty-return-value`])
 * Non-existent operators '=+', '=-' and '=!' should not be used ([`non-existent-operator`])
@@ -27,7 +27,7 @@ Code Smells, or maintainability issues, are raised for places of code which migh
 * "if ... else if" constructs should end with "else" clauses ([`elseif-without-else`]) (*disabled*)
 * "switch" statements should not have too many "case" clauses ([`max-switch-cases`])
 * Collapsible "if" statements should be merged ([`no-collapsible-if`])
-* Collection sizes and array length comparisons should make sense ([`no-collection-size-mischeck`])
+* Collection sizes and array length comparisons should make sense ([`no-collection-size-mischeck`]) (*uses-types*)
 * String literals should not be duplicated ([`no-duplicate-string`])
 * Two branches in a conditional structure should not have exactly the same implementation ([`no-duplicated-branches`])
 * Boolean expressions should not be gratuitous ([`no-gratuitous-expressions`])
@@ -81,7 +81,8 @@ Code Smells, or maintainability issues, are raised for places of code which migh
 
 ## Prerequisites
 
-Node.js (>=10.x).
+* Node.js (>=10.x).
+* ESLint 5.x, 6.x or 7.x (peer dependency for the plugin).
 
 ## Usage
 
@@ -120,6 +121,7 @@ npm install eslint-plugin-sonarjs -g         # or install globally
   }
 }
 ```
+* To enable all rules of this plugin use `@typescript-eslint/parser` as a parser for ESLint ([like we do](https://github.com/SonarSource/eslint-plugin-sonarjs/blob/6e06d59a233e07b28fbbd6398e08b9b0c63b18f9/.eslintrc.js#L4)). Thanks to it, type information is available, which is beneficial or even essential for some rules.
 
 ## Available Configurations
 

src/index.ts

@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software Foundation,
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
-import { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/experimental-utils';
 
 const sonarjsRules: string[] = [
   'cognitive-complexity',

src/rules/cognitive-complexity.ts

@@ -19,7 +19,7 @@
  */
 // https://sonarsource.github.io/rspec/#/rspec/S3776
 
-import { TSESTree } from '@typescript-eslint/experimental-utils';
+import type { TSESTree } from '@typescript-eslint/experimental-utils';
 import { isArrowFunctionExpression, isIfStatement, isLogicalExpression } from '../utils/nodes';
 import {
   getMainFunctionTokenLocation,

src/rules/elseif-without-else.ts

@@ -19,7 +19,7 @@
  */
 // https://sonarsource.github.io/rspec/#/rspec/S126
 
-import { TSESTree } from '@typescript-eslint/experimental-utils';
+import type { TSESTree } from '@typescript-eslint/experimental-utils';
 import { Rule } from '../utils/types';
 import docsUrl from '../utils/docs-url';
 

src/rules/max-switch-cases.ts

@@ -19,7 +19,7 @@
  */
 // https://sonarsource.github.io/rspec/#/rspec/S1479
 
-import { TSESTree } from '@typescript-eslint/experimental-utils';
+import type { TSESTree } from '@typescript-eslint/experimental-utils';
 import { Rule } from '../utils/types';
 import docsUrl from '../utils/docs-url';
 

src/rules/no-all-duplicated-branches.ts

@@ -19,7 +19,7 @@
  */
 // https://sonarsource.github.io/rspec/#/rspec/S3923
 
-import { TSESTree } from '@typescript-eslint/experimental-utils';
+import type { TSESTree } from '@typescript-eslint/experimental-utils';
 import { Rule } from '../utils/types';
 import { isIfStatement } from '../utils/nodes';
 import { areEquivalent } from '../utils/equivalence';

src/rules/no-collapsible-if.ts

@@ -19,7 +19,7 @@
  */
 // https://sonarsource.github.io/rspec/#/rspec/S1066
 
-import { TSESTree } from '@typescript-eslint/experimental-utils';
+import type { TSESTree } from '@typescript-eslint/experimental-utils';
 import { Rule } from '../utils/types';
 import { isIfStatement, isBlockStatement } from '../utils/nodes';
 import { report, issueLocation } from '../utils/locations';

src/rules/no-collection-size-mischeck.ts

@@ -19,7 +19,7 @@
  */
 // https://sonarsource.github.io/rspec/#/rspec/S3981
 
-import { TSESTree } from '@typescript-eslint/experimental-utils';
+import type { TSESTree } from '@typescript-eslint/experimental-utils';
 import { Rule } from '../utils/types';
 import { isRequiredParserServices, RequiredParserServices } from '../utils/parser-services';
 import docsUrl from '../utils/docs-url';

src/rules/no-duplicate-string.ts

@@ -19,7 +19,7 @@
  */
 // https://sonarsource.github.io/rspec/#/rspec/S1192
 
-import { TSESTree } from '@typescript-eslint/experimental-utils';
+import type { TSESTree } from '@typescript-eslint/experimental-utils';
 import { Rule } from '../utils/types';
 import docsUrl from '../utils/docs-url';
 

src/rules/no-duplicated-branches.ts

@@ -19,7 +19,7 @@
  */
 // https://sonarsource.github.io/rspec/#/rspec/S1871
 
-import { TSESTree } from '@typescript-eslint/experimental-utils';
+import type { TSESTree } from '@typescript-eslint/experimental-utils';
 import { Rule } from '../utils/types';
 import { isIfStatement, isBlockStatement } from '../utils/nodes';
 import { areEquivalent } from '../utils/equivalence';