Do not report on 'for' without condition (#248)

Author: vilchik-elena

ruling/snapshots/prefer-while

@@ -1,5 +1,2 @@
-src/brackets/src/extensions/default/QuickView/main.js: 302
-src/create-react-app/packages/react-error-overlay/src/utils/getSourceMap.js: 84
-src/react-native/Libraries/Renderer/ReactFabric-prod.js: 616,619,621,1249,1252,1347,1366,2197,3462,3513,3724,4090,4572,4678,4681,4782,4927,4944,5046,5065
-src/react-native/Libraries/Renderer/ReactNativeRenderer-prod.js: 712,715,717,1465,1468,1563,1582,2453,3855,3931,4166,4188,4227,4323,4365,4970,5076,5079,5180,5325,5342,5444,5463
-src/three.js/src/renderers/webgl/WebGLUniforms.js: 493
+src/react-native/Libraries/Renderer/ReactFabric-prod.js: 616,619,621,1249,1252,1347,1366,2197,3462,3513,3724,4090,4678,4681,4782,4927,4944,5046,5065
+src/react-native/Libraries/Renderer/ReactNativeRenderer-prod.js: 712,715,717,1465,1468,1563,1582,2453,3855,3931,4166,4227,4323,4365,5076,5079,5180,5325,5342,5444,5463

src/rules/prefer-while.ts

@@ -32,7 +32,7 @@ const rule: Rule.RuleModule = {
       ForStatement(node: TSESTree.Node) {
         const forLoop = node as TSESTree.ForStatement;
         const forKeyword = context.getSourceCode().getFirstToken(node);
-        if (!forLoop.init && !forLoop.update && forKeyword) {
+        if (!forLoop.init && !forLoop.update && forLoop.test && forKeyword) {
           context.report({
             message: `Replace this "for" loop with a "while" loop.`,
             loc: forKeyword.loc,

tests/rules/prefer-while.test.ts

@@ -32,6 +32,7 @@ ruleTester.run('prefer-while', rule, {
     { code: 'while (i < length) { }' },
     { code: 'for (a in b) { }' },
     { code: 'for (a of b) { }' },
+    { code: 'for(;;) {}' },
   ],
   invalid: [
     {
@@ -53,10 +54,5 @@ ruleTester.run('prefer-while', rule, {
         while (i < 10)
           doSomething();`,
     },
-    {
-      code: 'for(;;) {}',
-      errors: [{ message }],
-      output: 'for(;;) {}', // no fix
-    },
   ],
 });