no-identical-conditions: provide secondary issue locations (#103)

Author: andrea-guarino-sonarsource

src/rules/no-identical-conditions.ts

@@ -23,8 +23,17 @@ import { Rule } from "eslint";
 import * as estree from "estree";
 import { isIfStatement } from "../utils/nodes";
 import { areEquivalent } from "../utils/equivalence";
+import { report, issueLocation } from "../utils/locations";
 
 const rule: Rule.RuleModule = {
+  meta: {
+    schema: [
+      {
+        // internal parameter
+        enum: ["sonar-runtime"],
+      },
+    ],
+  },
   create(context: Rule.RuleContext) {
     return {
       IfStatement(node: estree.Node) {
@@ -35,8 +44,15 @@ const rule: Rule.RuleModule = {
           if (isIfStatement(statement)) {
             if (areEquivalent(condition, statement.test, context.getSourceCode())) {
               const line = ifStmt.loc && ifStmt.loc.start.line;
-              if (line !== undefined) {
-                context.report({ message: `This branch duplicates the one on line ${line}`, node: statement.test });
+              if (line && condition.loc) {
+                report(
+                  context,
+                  {
+                    message: `This branch duplicates the one on line ${line}`,
+                    node: statement.test,
+                  },
+                  [issueLocation(condition.loc, condition.loc, "Original")],
+                );
               }
             }
             statement = statement.alternate;

tests/rules/no-identical-conditions.test.ts

@@ -39,6 +39,29 @@ ruleTester.run("no-identical-conditions", rule, {
       `,
       errors: [{ message: "This branch duplicates the one on line 2", line: 3, column: 18, endColumn: 19 }],
     },
+    {
+      code: `
+        if (a) {} 
+        //  ^>
+        else if (a) {}
+        //       ^
+      `,
+      options: ["sonar-runtime"],
+      errors: [
+        JSON.stringify({
+          secondaryLocations: [
+            {
+              line: 2,
+              column: 12,
+              endLine: 2,
+              endColumn: 13,
+              message: "Original",
+            },
+          ],
+          message: "This branch duplicates the one on line 2",
+        }),
+      ],
+    },
     {
       code: `
         if (b) {}