Fix no-unused-collection: should not fire if collection is exported (#244)

Co-authored-by: Dmytro Pustovit <[email protected]>

Author: yassin-kammoun-sonarsource

src/rules/no-unused-collection.ts

@@ -61,7 +61,15 @@ function collectUnusedCollections(
   });
 }
 
+function isExported(variable: TSESLint.Scope.Variable) {
+  const definition = variable.defs[0];
+  return definition && definition.node.parent?.parent?.type.startsWith('Export');
+}
+
 function isUnusedCollection(variable: TSESLint.Scope.Variable) {
+  if (isExported(variable)) {
+    return false;
+  }
   if (variable.references.length <= 1) {
     return false;
   }

tests/rules/no-unused-collection.test.ts

@@ -160,6 +160,16 @@ ruleTester.run('Primitive return types should be used.', rule, {
           console.log(i);
         }`,
     },
+    {
+      code: `
+        export const array = [];
+
+        array.push(1);
+      `,
+    },
+    {
+      code: `export const collection = new Map()`,
+    },
   ],
   invalid: [
     {