SONARHTML-174 Fix NPE in S4084 VideoTrackCheck (#246)

Author: saberduck

sonar-html-plugin/src/main/java/org/sonar/plugins/html/checks/sonar/VideoTrackCheck.java

@@ -61,7 +61,8 @@ private static boolean isSourceTag(TagNode node) {
   }
 
   private static boolean isAccessibilityTrackTag(TagNode node) {
-    return node.equalsElementName("TRACK") && ACCESSIBILITY_TRACK_KINDS.contains(node.getPropertyValue("KIND"));
+    var kind = node.getPropertyValue("KIND");
+    return node.equalsElementName("TRACK") && kind != null && ACCESSIBILITY_TRACK_KINDS.contains(kind);
   }
 
 }

sonar-html-plugin/src/test/java/org/sonar/plugins/html/checks/sonar/VideoTrackCheckTest.java

@@ -38,7 +38,8 @@ public void detected() {
       .next().atLine(33)
       .next().atLine(38)
       .next().atLine(43)
-      .next().atLine(49);
+      .next().atLine(49)
+      .next().atLine(58);
   }
 
 }

sonar-html-plugin/src/test/resources/checks/VideoTrackCheck.html

@@ -54,5 +54,9 @@
       <track src="subtitles_en.vtt" [kind]="subtitles" srclang="en" label="English" />
       Your browser does not support HTML5 video.
   </video>
+
+ <video src="bla"> <!-- Non-Compliant -->
+   <track src="" default>
+ </video>
 </body>
 </html>