Skip to content

Commit 4c08633

Browse files
SONARHTML-189 Require SonarHTML download on JavaScript and PHP languages (#261)
1 parent dbf9c94 commit 4c08633

File tree

3 files changed

+1
-16
lines changed

3 files changed

+1
-16
lines changed

its/plugin/src/test/java/com/sonar/it/web/FileSuffixesTest.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -64,16 +64,6 @@ public void filesSuffixesHtmlPhp() {
6464
assertThat(getAnalyzedFilesNumber(projectKey)).isEqualTo(2);
6565
}
6666

67-
@Test
68-
public void should_analyze_only_php_files_with_empty_suffixes() {
69-
String projectKey = "FileSuffixesTest-empty_suffixes";
70-
SonarScanner build = getSonarRunner(projectKey)
71-
.setProperty("sonar.sourceEncoding", "UTF-8")
72-
.setProperty("sonar.html.file.suffixes", "");
73-
orchestrator.executeBuild(build);
74-
assertThat(getAnalyzedFilesNumber(projectKey)).isEqualTo(1);
75-
}
76-
7767
private Integer getAnalyzedFilesNumber(String projectKey) {
7868
return getMeasureAsInt(orchestrator, projectKey, FILES_METRIC);
7969
}

its/plugin/src/test/java/com/sonar/it/web/PhpFilesTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,6 @@ public void plugin_should_not_conflict_with_php_analyzer() {
7777
analyzeFileAndCheckIssues(orchestratorWithPhp);
7878
}
7979

80-
@Test
81-
public void file_should_get_analyzed_even_without_php() {
82-
analyzeFileAndCheckIssues(orchestrator);
83-
}
84-
8580
private void analyzeFileAndCheckIssues(Orchestrator orchestrator) {
8681
SonarScanner build = getSonarRunner();
8782
orchestrator.executeBuild(build);

sonar-html-plugin/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@
161161
<!-- this value is translated to Sonar-Version property in META-INF/MANIFEST.MF file inside jar. It is used at runtime
162162
by products to detect compatibility. We keep LTS -->
163163
<pluginApiMinVersion>9.9</pluginApiMinVersion>
164-
<requiredForLanguages>web,jsp</requiredForLanguages>
164+
<requiredForLanguages>web,jsp,js,php</requiredForLanguages>
165165
</configuration>
166166
</plugin>
167167

0 commit comments

Comments
 (0)