Skip to content

Commit ccf71c4

Browse files
committed
Update sonar-plugin-api
1 parent 93448f2 commit ccf71c4

File tree

6 files changed

+24
-27
lines changed

6 files changed

+24
-27
lines changed

its/plugin/pom.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,12 @@
3131
<version>${analyzerCommons.version}</version>
3232
<scope>test</scope>
3333
</dependency>
34+
<dependency>
35+
<groupId>org.sonarsource.sonarqube</groupId>
36+
<artifactId>sonar-ws</artifactId>
37+
<version>${sonarqube.sonar.ws.version}</version>
38+
<scope>test</scope>
39+
</dependency>
3440
<dependency>
3541
<groupId>org.sonarsource.sonarlint.core</groupId>
3642
<artifactId>sonarlint-core</artifactId>
@@ -43,12 +49,6 @@
4349
<version>${orchestrator.version}</version>
4450
<scope>test</scope>
4551
</dependency>
46-
<dependency>
47-
<groupId>org.sonarsource.sonarqube</groupId>
48-
<artifactId>sonar-ws</artifactId>
49-
<version>${sonarqube.sonar.ws.version}</version>
50-
<scope>test</scope>
51-
</dependency>
5252
<dependency>
5353
<groupId>junit</groupId>
5454
<artifactId>junit</artifactId>

pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,11 @@
6666
<jakarta.el.version>4.0.2</jakarta.el.version>
6767
<sslr.version>1.24.0.633</sslr.version>
6868
<analyzerCommons.version>2.5.0.1358</analyzerCommons.version>
69-
<sonar.plugin.api.version>7.9</sonar.plugin.api.version>
69+
<sonar.plugin.api.version>10.1.0.809</sonar.plugin.api.version>
7070

7171
<sonarlint.api.impl.version>6.3.0.36253</sonarlint.api.impl.version>
72-
<sonarqube.api.impl.version>9.9.0.65466</sonarqube.api.impl.version>
73-
<sonarqube.sonar.ws.version>9.9.0.65466</sonarqube.sonar.ws.version>
72+
<sonarqube.api.impl.version>10.1.0.73491</sonarqube.api.impl.version>
73+
<sonarqube.sonar.ws.version>10.1.0.73491</sonarqube.sonar.ws.version>
7474
<orchestrator.version>3.40.0.183</orchestrator.version>
7575
<junit.version>4.13.2</junit.version>
7676
<assertj.version>3.23.1</assertj.version>

sonar-html-plugin/pom.xml

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939

4040
<dependencies>
4141
<dependency>
42-
<groupId>org.sonarsource.sonarqube</groupId>
42+
<groupId>org.sonarsource.api.plugin</groupId>
4343
<artifactId>sonar-plugin-api</artifactId>
4444
<version>${sonar.plugin.api.version}</version>
4545
<scope>provided</scope>
@@ -121,6 +121,14 @@
121121
</exclusion>
122122
</exclusions>
123123
</dependency>
124+
125+
<dependency>
126+
<groupId>org.sonarsource.api.plugin</groupId>
127+
<artifactId>sonar-plugin-api-test-fixtures</artifactId>
128+
<version>${sonar.plugin.api.version}</version>
129+
<scope>test</scope>
130+
</dependency>
131+
124132
</dependencies>
125133

126134

@@ -150,6 +158,9 @@
150158
<!-- SonarHTML replaces SonarWeb but we keep the plugin key "web" to make it easier for users to migrate -->
151159
<pluginKey>web</pluginKey>
152160
<jreMinVersion>${jdk.min.version}</jreMinVersion>
161+
<!-- this value is translated to Sonar-Version property in META-INF/MANIFEST.MF file inside jar. It is used at runtime
162+
by products to detect compatibility. We keep LTS -->
163+
<sonarQubeMinVersion>9.9</sonarQubeMinVersion>
153164
</configuration>
154165
</plugin>
155166

sonar-html-plugin/src/main/java/org/sonar/plugins/html/core/HtmlSensor.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,12 +89,7 @@ private void processesFilesIndependently(SensorDescriptor descriptor) {
8989
|| !sonarRuntime.getApiVersion().isGreaterThanOrEqual(Version.create(9, 3))) {
9090
return;
9191
}
92-
try {
93-
Method method = descriptor.getClass().getMethod("processesFilesIndependently");
94-
method.invoke(descriptor);
95-
} catch (ReflectiveOperationException e) {
96-
LOG.warn("Could not call SensorDescriptor.processesFilesIndependently() method", e);
97-
}
92+
descriptor.processesFilesIndependently();
9893
}
9994

10095
@Override

sonar-html-plugin/src/test/java/org/sonar/plugins/html/core/HtmlSensorTest.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@
5050
import org.sonar.api.measures.FileLinesContextFactory;
5151
import org.sonar.api.rule.RuleKey;
5252
import org.sonar.api.server.rule.RulesDefinition;
53+
import org.sonar.api.testfixtures.log.LogTesterJUnit5;
5354
import org.sonar.api.utils.Version;
54-
import org.sonar.api.utils.log.LogTesterJUnit5;
5555
import org.sonar.plugins.html.api.HtmlConstants;
5656
import org.sonar.plugins.html.rules.HtmlRulesDefinition;
5757

@@ -190,15 +190,6 @@ public SensorDescriptor processesFilesIndependently() {
190190
assertTrue(called[0]);
191191
}
192192

193-
@Test
194-
public void test_descriptor_sonarqube_9_3_reflection_failure() {
195-
DefaultSensorDescriptor sensorDescriptor = new DefaultSensorDescriptor();
196-
SonarRuntime sonarRuntime = SonarRuntimeImpl.forSonarQube(Version.create(9, 3), SonarQubeSide.SCANNER, SonarEdition.COMMUNITY);
197-
new HtmlSensor(sonarRuntime, null, null, new CheckFactory(new DefaultActiveRules(Collections.emptyList()))).describe(sensorDescriptor);
198-
assertThat(sensorDescriptor.name()).isEqualTo("HTML");
199-
assertThat(sensorDescriptor.languages()).isEmpty();
200-
assertTrue(logTester.logs().contains("Could not call SensorDescriptor.processesFilesIndependently() method"));
201-
}
202193

203194
@Test
204195
public void php_file_should_not_have_metrics() {

sonar-html-plugin/src/test/java/org/sonar/plugins/html/rules/HtmlRulesDefinitionTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public void test() {
4141
rulesDefinition.define(context);
4242
RulesDefinition.Repository repository = context.repository("Web");
4343

44-
assertThat(repository.name()).isEqualTo("SonarAnalyzer");
44+
assertThat(repository.name()).isEqualTo("Sonar");
4545
assertThat(repository.language()).isEqualTo("web");
4646
assertThat(repository.rules()).hasSize(CheckClasses.getCheckClasses().size());
4747

0 commit comments

Comments
 (0)