JACOCO-95 Fix warning log for multi-value property (#166)

Author: leonardo-pilastri-sonarsource

src/main/java/org/sonar/plugins/jacoco/JacocoPlugin.java

@@ -40,8 +40,7 @@ public void define(Context context) {
     context.addExtension(JacocoAggregateSensor.class);
     context.addExtension(PropertyDefinition.builder(ReportPathsProvider.AGGREGATE_REPORT_PATHS_PROPERTY_KEY)
       .onQualifiers(Qualifiers.PROJECT)
-      .type(PropertyType.STRING)
-      .multiValues(false)
+      .multiValues(true)
       .category("JaCoCo")
       .description("Paths to JaCoCo XML aggregate coverage report files. Each path can be either absolute or relative" +
               " to the project base directory. Wildcard patterns are accepted (*, ** and ?).")

src/test/java/org/sonar/plugins/jacoco/JacocoPluginTest.java

@@ -50,19 +50,20 @@ void should_add_sensors_and_property_definitions() {
     PropertyDefinition multiValueReportPaths = (PropertyDefinition) arg.getAllValues().get(2);
     assertThat(multiValueReportPaths.key()).isEqualTo("sonar.coverage.jacoco.xmlReportPaths");
     assertThat(multiValueReportPaths.multiValues()).isTrue();
+    assertThat(multiValueReportPaths.type()).isEqualTo(PropertyType.STRING);
     assertThat(multiValueReportPaths.category()).isEqualTo("JaCoCo");
     assertThat(multiValueReportPaths.description()).isEqualTo("Paths to JaCoCo XML coverage report files. Each path can be either absolute or relative" +
             " to the project base directory. Wildcard patterns are accepted (*, ** and ?).");
     assertThat(multiValueReportPaths.qualifiers()).containsOnly(Qualifiers.PROJECT);
 
     assertThat(arg.getAllValues().get(3)).isEqualTo(JacocoAggregateSensor.class);
-    PropertyDefinition aggregateReportPath = (PropertyDefinition) arg.getAllValues().get(4);
-    assertThat(aggregateReportPath.key()).isEqualTo("sonar.coverage.jacoco.aggregateXmlReportPaths");
-    assertThat(aggregateReportPath.type()).isEqualTo(PropertyType.STRING);
-    assertThat(aggregateReportPath.multiValues()).isFalse();
-    assertThat(aggregateReportPath.category()).isEqualTo("JaCoCo");
-    assertThat(aggregateReportPath.description()).isEqualTo("Paths to JaCoCo XML aggregate coverage report files. Each path can be either absolute or relative" +
+    PropertyDefinition aggregateReportPaths = (PropertyDefinition) arg.getAllValues().get(4);
+    assertThat(aggregateReportPaths.key()).isEqualTo("sonar.coverage.jacoco.aggregateXmlReportPaths");
+    assertThat(aggregateReportPaths.type()).isEqualTo(PropertyType.STRING);
+    assertThat(aggregateReportPaths.multiValues()).isTrue();
+    assertThat(aggregateReportPaths.category()).isEqualTo("JaCoCo");
+    assertThat(aggregateReportPaths.description()).isEqualTo("Paths to JaCoCo XML aggregate coverage report files. Each path can be either absolute or relative" +
             " to the project base directory. Wildcard patterns are accepted (*, ** and ?).");
-    assertThat(aggregateReportPath.qualifiers()).containsOnly(Qualifiers.PROJECT);
+    assertThat(aggregateReportPaths.qualifiers()).containsOnly(Qualifiers.PROJECT);
   }
 }