JACOCO-74 Import coverage for files whose name and package clashes across different nested modules

Collect sources for every module we traverse in order for the aggregate sensor to re-map properly source files in aggregate reports to files indexed by the scanner.

This sharing of information among sensors is necessary because:
1. Aggregate reports contain the name of the module, package and filename but lack the source directories where the package is declared
2. Information about source files and directories is not accessible at the project sensor level

Author: dorian-burihabwa-sonarsource

its/src/test/java/org/sonar/plugins/jacoco/its/JacocoTest.java

@@ -36,7 +36,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class JacocoTest {
+class JacocoTest {
   private final static String PROJECT_KEY = "jacoco-test-project";
   private static final String FILE_KEY = "jacoco-test-project:src/main/java/org/sonarsource/test/Calc.java";
   private static final String KOTLIN_FILE_KEY = "org.sonarsource.it.projects:kotlin-jacoco-project:src/main/kotlin/CoverMe.kt";
@@ -223,6 +223,23 @@ void aggregate_and_module_based_reports_complement_each_over_to_build_total_cove
             .containsEntry("uncovered_conditions", 0.0)
             .containsEntry("coverage", 100.0);
 
+    Map<String, Double> measuresForLibraryClash = getCoverageMeasures("org.example:aggregate-and-module-based-mixed-coverage:library-clash/src/main/java/org/example/Library.java");
+    assertThat(measuresForLibraryClash)
+            .containsEntry("line_coverage", 100.0)
+            .containsEntry("lines_to_cover", 2.0)
+            .containsEntry("uncovered_lines", 0.0)
+            .containsEntry("coverage", 100.0);
+
+    Map<String, Double> measuresForLibraryNested = getCoverageMeasures("org.example:aggregate-and-module-based-mixed-coverage:nested/library/src/main/java/org/example/Library.java");
+    assertThat(measuresForLibraryNested)
+            .containsEntry("branch_coverage", 100.0)
+            .containsEntry("conditions_to_cover", 2.0)
+            .containsEntry("coverage", 100.0)
+            .containsEntry("line_coverage", 100.0)
+            .containsEntry("lines_to_cover", 7.0)
+            .containsEntry("uncovered_conditions", 0.0)
+            .containsEntry("uncovered_lines", 0.0);
+
     Map<String, Double> measuresForSquarer = getCoverageMeasures("org.example:aggregate-and-module-based-mixed-coverage:self-covered/src/main/java/org/example/Squarer.java");
     assertThat(measuresForSquarer)
             .containsEntry("line_coverage", 100.0)

its/src/test/resources/aggregate-and-module-based-mixed-coverage/README.md

@@ -1,11 +1,14 @@
 # Aggregate Maven project
 
-A project with 4 modules:
+A project with 7 modules with 100% coverage:
 
 1. [library](./library) - containing code but no tests
-2. [library.test](./library.test) - containing test code that uses code from `library`
-3. [report](./report) - generating the aggregate coverage report
-4. [self-covered](./self-covered) - containing code, tests and generating its own module-based coverage report
+2. [library-clash](./library-clash) - containing a class whose name clashes with the one in `library`
+3. [nested](./nested) - containing one subproject
+4. [library-nested](./nested/library) -  a nested subproject containing a class whose name clashes with the one in `library`
+5. [library-test](./library.test) - containing test code that uses code from `library`
+6. [report](./report) - generating the aggregate coverage report
+7[self-covered](./self-covered) - containing code, tests and generating its own module-based coverage report
 
 
 The report can be generated by running the following command:

its/src/test/resources/aggregate-and-module-based-mixed-coverage/library-clash/pom.xml

@@ -0,0 +1,23 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <parent>
+        <groupId>org.example</groupId>
+        <artifactId>aggregate-and-module-based-mixed-coverage</artifactId>
+        <version>1.0-SNAPSHOT</version>
+    </parent>
+
+    <artifactId>library-clash</artifactId>
+    <packaging>jar</packaging>
+
+    <dependencies>
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter-api</artifactId>
+            <version>6.0.1</version>
+            <scope>test</scope>
+        </dependency>
+    </dependencies>
+</project>

its/src/test/resources/aggregate-and-module-based-mixed-coverage/library-clash/src/main/java/org/example/Library.java

@@ -0,0 +1,7 @@
+package org.example;
+
+public final class Library {
+  String greet(String name) {
+    return String.format("Hello, %s!", name);
+  }
+}

its/src/test/resources/aggregate-and-module-based-mixed-coverage/library-clash/src/test/java/org/example/LibraryTest.java

@@ -0,0 +1,12 @@
+package org.example;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+class LibraryTest {
+  @Test
+  void incompleteTest() {
+    Library library = new Library();
+    Assertions.assertEquals("Hello, World!", library.greet("World"));
+  }
+}

its/src/test/resources/aggregate-and-module-based-mixed-coverage/nested/library/pom.xml

@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <parent>
+        <groupId>org.example</groupId>
+        <artifactId>nested</artifactId>
+        <version>1.0-SNAPSHOT</version>
+    </parent>
+
+    <artifactId>library-nested</artifactId>
+    <packaging>jar</packaging>
+
+    <dependencies>
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter-api</artifactId>
+            <version>6.0.1</version>
+            <scope>test</scope>
+        </dependency>
+    </dependencies>
+
+</project>

its/src/test/resources/aggregate-and-module-based-mixed-coverage/nested/library/src/main/java/org/example/Library.java

@@ -0,0 +1,27 @@
+package org.example;
+
+import java.util.Objects;
+
+/**
+ * This class contains code that has very little to do with the libraries
+ * It is also shaped in a way that applying coverage metrics from the other files should not work.
+ */
+public final class Library {
+  public final String name;
+
+  public Library(String name) {
+    this.name = name;
+  }
+
+  @Override
+  public boolean equals(Object o) {
+    if (!(o instanceof Library)) return false;
+    Library library = (Library) o;
+    return Objects.equals(name, library.name);
+  }
+
+  @Override
+  public int hashCode() {
+    return Objects.hashCode(name);
+  }
+}

its/src/test/resources/aggregate-and-module-based-mixed-coverage/nested/library/src/test/java/org/example/LibraryTest.java

@@ -0,0 +1,20 @@
+package org.example;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+class LibraryTest {
+  @Test
+  void test() {
+    Library library = new Library("City");
+    Assertions.assertEquals("City", library.name);
+
+    Library similarLibrary = new Library("City");
+    Assertions.assertEquals(library, similarLibrary);
+    Assertions.assertEquals(library.hashCode(), library.hashCode());
+    Assertions.assertEquals(library.hashCode(), similarLibrary.hashCode());
+
+    Assertions.assertNotEquals(library, new Object());
+    Assertions.assertNotEquals(library, new Library("Other"));
+  }
+}

its/src/test/resources/aggregate-and-module-based-mixed-coverage/nested/pom.xml

@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <parent>
+        <groupId>org.example</groupId>
+        <artifactId>aggregate-and-module-based-mixed-coverage</artifactId>
+        <version>1.0-SNAPSHOT</version>
+    </parent>
+
+    <artifactId>nested</artifactId>
+    <packaging>pom</packaging>
+
+    <modules>
+        <module>library</module>
+    </modules>
+</project>

its/src/test/resources/aggregate-and-module-based-mixed-coverage/nested/src/main/java/org/example/Library.java

@@ -0,0 +1,7 @@
+package org.example;
+
+public final class Library {
+  String greet(String name) {
+    return String.format("Hello, %s!", name);
+  }
+}