Fix issue, improve coverage

Author: leonardo-pilastri-sonarsource

java-frontend/src/test/java/org/sonar/java/ast/JavaAstScannerTest.java

@@ -480,7 +480,7 @@ public void scanFile(JavaFileScannerContext context) {
   }
 
   @Test
-  void test_should_fail_on_stackoverflow() {
+  void test_should_fail_on_stackoverflow_by_default() {
     InputFile trivialCompilationUnit = TestUtils.inputFile("src/test/resources/AstScannerNoParseError.txt");
     var files = List.of(trivialCompilationUnit);
     var problematicVisitor = new JavaFileScanner(){
@@ -492,8 +492,22 @@ public void scanFile(JavaFileScannerContext context) {
     List<JavaFileScanner> visitors = List.of(problematicVisitor);
 
     // Assert that by default, StackOverflowError is propagated
+    var emptySettings = new MapSettings();
     assertThrows(StackOverflowError.class, () ->
-      scanFilesWithVisitorsAndContext(files, visitors, new MapSettings(), JavaVersionImpl.MAX_SUPPORTED));
+      scanFilesWithVisitorsAndContext(files, visitors, emptySettings, JavaVersionImpl.MAX_SUPPORTED));
+  }
+
+  @Test
+  void test_should_not_fail_on_stackoverflow_when_set() {
+    InputFile trivialCompilationUnit = TestUtils.inputFile("src/test/resources/AstScannerNoParseError.txt");
+    var files = List.of(trivialCompilationUnit);
+    var problematicVisitor = new JavaFileScanner(){
+      @Override
+      public void scanFile(JavaFileScannerContext context) {
+        throw new StackOverflowError();
+      }
+    };
+    List<JavaFileScanner> visitors = List.of(problematicVisitor);
 
     // Assert that when configured to not fail on exception, StackOverflowError is swallowed, but logged
     MapSettings settings = new MapSettings().setProperty(SonarComponents.SONAR_FAIL_ON_STACKOVERFLOW, false);
@@ -502,6 +516,23 @@ public void scanFile(JavaFileScannerContext context) {
       .containsExactly("A stack overflow error occurred while analyzing file: 'src/test/resources/AstScannerNoParseError.txt'");
   }
 
+  @Test
+  void test_should_fail_on_stackoverflow_when_sonar_components_null() {
+    InputFile trivialCompilationUnit = TestUtils.inputFile("src/test/resources/AstScannerNoParseError.txt");
+    var files = List.of(trivialCompilationUnit);
+    var problematicVisitor = new JavaFileScanner(){
+      @Override
+      public void scanFile(JavaFileScannerContext context) {
+        throw new StackOverflowError();
+      }
+    };
+    List<JavaFileScanner> visitors = List.of(problematicVisitor);
+    JavaAstScanner scanner = new JavaAstScanner(null, new NoOpTelemetry(), TelemetryKey.JAVA_ANALYSIS_MAIN);
+    VisitorsBridge visitorBridge = new VisitorsBridge(visitors, new ArrayList<>(), null, new JavaVersionImpl(JavaVersionImpl.MAX_SUPPORTED));
+    scanner.setVisitorBridge(visitorBridge);
+    assertThrows(StackOverflowError.class, () -> scanner.scan(files));
+  }
+
   private void scanSingleFile(InputFile file, boolean failOnException) {
     scanFilesWithVisitors(Collections.singletonList(file), Collections.emptyList(), -1, failOnException, false);
   }