Use functional prog to avoid low branch coverage, fix test format

Author: rombirli

java-checks/src/main/java/org/sonar/java/checks/IncDecOnFloatingPointCheck.java

@@ -17,6 +17,7 @@
 package org.sonar.java.checks;
 
 import java.util.List;
+import java.util.Optional;
 import org.sonar.check.Rule;
 import org.sonar.plugins.java.api.IssuableSubscriptionVisitor;
 import org.sonar.plugins.java.api.semantic.Type;
@@ -40,20 +41,24 @@ public List<Tree.Kind> nodesToVisit() {
 
   @Override
   public void visitNode(Tree tree) {
-    if (
-      tree instanceof UnaryExpressionTree unaryExpr &&
-        unaryExpr.expression() instanceof IdentifierTree identifier &&
-        // above condition should always be true, just used to pattern match safely
-        isFloatingPoint(identifier.symbolType())
-    ) {
-      reportIssue(
-        unaryExpr,
-        "%s operator (%s) should not be used with floating point variables".formatted(
-          isIncrement(unaryExpr) ? "Increment" : "Decrement",
-          unaryExpr.operatorToken().text()
-        )
-      );
-    }
+    var unaryExprOpt = Optional.of(tree)
+      .filter(UnaryExpressionTree.class::isInstance)
+      .map(UnaryExpressionTree.class::cast);
+    unaryExprOpt
+      .map(UnaryExpressionTree::expression)
+      .filter(IdentifierTree.class::isInstance)
+      .map(IdentifierTree.class::cast)
+      .filter(identifier -> isFloatingPoint(identifier.symbolType()))
+      .ifPresent(identifier -> {
+        var unaryExpr = unaryExprOpt.get(); // safe get
+        reportIssue(
+          unaryExpr,
+          "%s operator (%s) should not be used with floating point variables".formatted(
+            isIncrement(unaryExpr) ? "Increment" : "Decrement",
+            unaryExpr.operatorToken().text()
+          )
+        );
+      });
   }
 
   private static boolean isFloatingPoint(Type type) {

java-checks/src/test/java/org/sonar/java/checks/IncDecOnFloatingPointCheckTest.java

@@ -28,6 +28,7 @@ void test() {
       .withCheck(new IncDecOnFloatingPointCheck())
       .verifyIssues();
   }
+
   @Test
   void testNoSemantic() {
     CheckVerifier.newVerifier()