SONARJAVA-5797 Fix FP on fail("msg")

Author: tomasz-tylenda-sonarsource

java-checks-test-sources/default/src/test/java/checks/tests/AssertionsWithoutMessageCheckSample.java

@@ -17,6 +17,10 @@ void foo() {
     org.testng.Assert.assertTrue(true, "msg"); // Compliant
     org.testng.Assert.assertTrue(true); // Noncompliant
     org.testng.AssertJUnit.assertTrue(true); // Noncompliant
+
+    org.testng.Assert.fail(); // Noncompliant
+    org.testng.Assert.fail("msg"); // Compliant
+
     org.assertj.core.api.Assertions.assertThat("").usingComparator(null).as("a").isEqualTo(222); // Compliant
     org.junit.Assert.assertTrue(true); // Noncompliant {{Add a message to this assertion.}}
 //                   ^^^^^^^^^^

java-checks/src/main/java/org/sonar/java/checks/tests/AssertionsWithoutMessageCheck.java

@@ -115,7 +115,14 @@ protected void onMethodInvocationFound(MethodInvocationTree mit) {
    * and it is the first of the last argument (depending on the assertion library).
    */
   private static boolean hasMessageArg(MethodInvocationTree mit, Type type) {
-    int expectedMessageArgIndex = (type.is("org.testng.Assert") || type.is("org.testng.AssertJUnit")) ? 1 : 0;
+    int expectedMessageArgIndex;
+    if (mit.methodSymbol().name().equals("fail")) {
+      expectedMessageArgIndex = 0;
+    } else if (type.is("org.testng.Assert") || type.is("org.testng.AssertJUnit")) {
+      expectedMessageArgIndex = 1;
+    } else {
+      expectedMessageArgIndex = 0;
+    }
     List<ExpressionTree> args = mit.arguments();
     return expectedMessageArgIndex < args.size() && isString(args.get(expectedMessageArgIndex));
   }