Fix quality flaw: use immutable List instead of mutable List (#401)

Author: erwan-serandour

sonar-kotlin-checks/src/main/java/org/sonarsource/kotlin/checks/CipherModeOperationCheck.kt

@@ -78,7 +78,7 @@ class CipherModeOperationCheck : CallAbstractCheck() {
     }
 }
 
-private fun generateSecondaryLocations(secondaries: MutableList<PsiElement>, kotlinFileContext: KotlinFileContext) =
+private fun generateSecondaryLocations(secondaries: List<PsiElement>, kotlinFileContext: KotlinFileContext) =
     secondaries.mapIndexed { i, secondary ->
         if (i < secondaries.size - 1) {
             SecondaryLocation(kotlinFileContext.textRange(secondary), "Initialization vector is configured here.")

sonar-kotlin-checks/src/main/java/org/sonarsource/kotlin/checks/RedundantMethodsInDataClassesCheck.kt

@@ -206,7 +206,7 @@ private fun findParameter(
 private fun checkDotExpression(
     expression: KtExpression?,
     klassParameter: KtParameter,
-    methodParameters: MutableList<KtParameter>,
+    methodParameters: List<KtParameter>,
 ): Boolean =
     if (expression is KtDotQualifiedExpression) {
         ((expression.receiverExpression as KtNameReferenceExpression).getReferencedName() == methodParameters[0].name