SONARKT-401 K2 should not create non-daemon threads

Author: Godin

sonar-kotlin-api/build.gradle.kts

@@ -55,3 +55,9 @@ task<JavaExec>("printAst") {
     classpath = sourceSets.main.get().runtimeClasspath
     mainClass.set("org.sonarsource.kotlin.ast.AstPrinterKt")
 }
+
+task<JavaExec>("patchKotlinCompiler") {
+    outputs.dir(layout.buildDirectory.dir("patch"))
+    classpath = sourceSets.main.get().runtimeClasspath
+    mainClass.set("org.sonarsource.kotlin.tools.PatchKotlinCompilerKt")
+}

sonar-kotlin-api/src/main/java/org/sonarsource/kotlin/tools/PatchKotlinCompiler.kt

@@ -0,0 +1,76 @@
+/*
+ * SonarSource Kotlin
+ * Copyright (C) 2018-2025 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the Sonar Source-Available License Version 1, as published by SonarSource SA.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+ * See the Sonar Source-Available License for more details.
+ *
+ * You should have received a copy of the Sonar Source-Available License
+ * along with this program; if not, see https://sonarsource.com/license/ssal/
+ */
+package org.sonarsource.kotlin.tools
+
+import org.jetbrains.org.objectweb.asm.ClassReader
+import org.jetbrains.org.objectweb.asm.ClassVisitor
+import org.jetbrains.org.objectweb.asm.ClassWriter
+import org.jetbrains.org.objectweb.asm.MethodVisitor
+import org.jetbrains.org.objectweb.asm.Opcodes
+import java.io.File
+
+/**
+ * Patches [com.intellij.util.concurrency.AppScheduledExecutorService.MyThreadFactory].
+ */
+fun main() {
+
+    var patched = false
+
+    class MyMethodVisitor(mv: MethodVisitor) : MethodVisitor(Opcodes.API_VERSION, mv) {
+        override fun visitMethodInsn(
+            opcode: Int,
+            owner: String?,
+            name: String?,
+            descriptor: String?,
+            isInterface: Boolean
+        ) {
+            super.visitMethodInsn(opcode, owner, name, descriptor, isInterface)
+            if (name == "newThread") { // INVOKEINTERFACE java/util/concurrent/ThreadFactory.newThread (Ljava/lang/Runnable;)Ljava/lang/Thread; (itf)
+                mv.visitInsn(Opcodes.DUP)
+                mv.visitInsn(Opcodes.ICONST_1)
+                mv.visitMethodInsn(Opcodes.INVOKEVIRTUAL, "java/lang/Thread", "setDaemon", "(Z)V", false)
+                patched = true
+            }
+        }
+    }
+
+    class MyClassVisitor(cv: ClassVisitor) : ClassVisitor(Opcodes.ASM9, cv) {
+        override fun visitMethod(
+            access: Int,
+            name: String?,
+            descriptor: String?,
+            signature: String?,
+            exceptions: Array<out String>?
+        ): MethodVisitor {
+            return MyMethodVisitor(super.visitMethod(access, name, descriptor, signature, exceptions))
+        }
+    }
+
+    val cls = "com/intellij/util/concurrency/AppScheduledExecutorService\$MyThreadFactory.class"
+    val bytes = object {}.javaClass
+        .getResourceAsStream("/$cls")!!
+        .use { it.readAllBytes() }
+    val classWriter = ClassWriter(0)
+    ClassReader(bytes).accept(MyClassVisitor(classWriter), 0)
+
+    if (!patched) throw AssertionError()
+
+    val output = File("build/patch").resolve(cls)
+    output.parentFile.mkdirs()
+    File("build/patch/test.txt").writeText("test")
+    output.writeBytes(classWriter.toByteArray())
+}

sonar-kotlin-plugin/build.gradle.kts

@@ -96,6 +96,12 @@ tasks.jar {
 val sourcesJar = tasks.sourcesJar
 val javadocJar = tasks.javadocJar
 
+val patchTask = project(":sonar-kotlin-api").tasks.named("patchKotlinCompiler")
+
+sourceSets.main {
+    resources.srcDir(patchTask)
+}
+
 // Note that this task is time-consuming
 // and needed only for integration tests and publishing,
 // so it is not part of `gradle build`.
@@ -104,9 +110,17 @@ task<proguard.gradle.ProGuardTask>("dist") {
     description = "Assembles sonar-kotlin-plugin.jar for integration tests and publishing"
     libraryjars("${System.getProperty("java.home")}/jmods/java.base.jmod")
     injars(
-        mapOf("filter" to "!META-INF/native/**/*jansi*,!org/jline/**,!net/jpountz/**"),
+        mapOf(
+            "filter" to listOf(
+                "!com/intellij/util/concurrency/AppScheduledExecutorService\$MyThreadFactory.class", // patched version is included below
+                "!META-INF/native/**/*jansi*",
+                "!org/jline/**",
+                "!net/jpountz/**"
+            ).joinToString(",")
+        ),
         tasks.shadowJar.get().archiveFile
     )
+    injars(patchTask)
     outjars("build/libs/sonar-kotlin-plugin.jar")
     configuration("proguard.txt")
     doLast {

sonar-kotlin-plugin/src/test/java/org/sonarsource/kotlin/plugin/AppScheduledExecutorServiceTest.kt

@@ -0,0 +1,40 @@
+/*
+ * SonarSource Kotlin
+ * Copyright (C) 2018-2025 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the Sonar Source-Available License Version 1, as published by SonarSource SA.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+ * See the Sonar Source-Available License for more details.
+ *
+ * You should have received a copy of the Sonar Source-Available License
+ * along with this program; if not, see https://sonarsource.com/license/ssal/
+ */
+package org.sonarsource.kotlin.plugin
+
+import com.intellij.util.concurrency.AppScheduledExecutorService
+import org.junit.jupiter.api.Assertions.assertTrue
+import org.junit.jupiter.api.Test
+import java.util.concurrent.ScheduledExecutorService
+
+private class AppScheduledExecutorServiceTest {
+    /**
+     * Non-daemon thread created by
+     * [KaFirSessionProvider](https://github.com/JetBrains/kotlin/blob/v2.1.10/analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/KaFirSessionProvider.kt#L67)
+     * might prevent JVM termination - for example in case of [AssertionError]
+     * [`ScannerMain` does not execute `System.exit`](https://github.com/SonarSource/sonar-enterprise/blob/sqs-10.8.1.101195/sonar-scanner-engine/src/main/java/org/sonar/scanner/bootstrap/ScannerMain.java#L51-L74).
+     */
+    @Test
+    fun `should use daemon threads`() {
+        val getInstanceMethod = AppScheduledExecutorService::class.java.getDeclaredMethod("getInstance")
+        getInstanceMethod.isAccessible = true
+        val instance: ScheduledExecutorService = getInstanceMethod.invoke(null) as ScheduledExecutorService
+        instance.submit {
+            assertTrue(Thread.currentThread().isDaemon)
+        }.get()
+    }
+}